)]}'
{"swift/common/db_replicator.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b7ada021dd75cd9616a0a3c5643f0d375041fe6f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    True if the directory name is a valid partition number, False otherwise."},{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":"    try:"},{"line_number":77,"context_line":"        part \u003d int(dir_name)"},{"line_number":78,"context_line":"        return part \u003e\u003d 0"},{"line_number":79,"context_line":"    except ValueError:"},{"line_number":80,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_e1c135e6","line":77,"updated":"2018-03-03 23:52:08.000000000","message":"Assuming py3 support, this will eat names like \u00271_2_3\u0027 and think it\u0027s valid. Should we add something like\n\n if \u0027_\u0027 in dir_name:\n     return False\n\nahead of this? Might need to be a little more involved if we anticipate ever getting bytes under py3...","commit_id":"2bfd9c6a9b0d9ee5b547a31ba97be74b09ac3afc"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"fd7829985c3f4693474e20070b9faae40fec1474","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    True if the directory name is a valid partition number, False otherwise."},{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":"    try:"},{"line_number":77,"context_line":"        part \u003d int(dir_name)"},{"line_number":78,"context_line":"        return part \u003e\u003d 0"},{"line_number":79,"context_line":"    except ValueError:"},{"line_number":80,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_103e3129","line":77,"in_reply_to":"1f9dbf25_e1c135e6","updated":"2018-03-05 19:19:28.000000000","message":"I\u0027d rather do something like re.search(br\"^\\d+$\", dir_name) at that point. If int() isn\u0027t sufficiently selective for us, let\u0027s explicitly state what we\u0027re after.\n\nAlso, I\u0027m happy to defer that to later once we start doing py3 stuff in here. :)","commit_id":"2bfd9c6a9b0d9ee5b547a31ba97be74b09ac3afc"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b7ada021dd75cd9616a0a3c5643f0d375041fe6f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":"    try:"},{"line_number":77,"context_line":"        part \u003d int(dir_name)"},{"line_number":78,"context_line":"        return part \u003e\u003d 0"},{"line_number":79,"context_line":"    except ValueError:"},{"line_number":80,"context_line":"        return False"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_218e3dd0","line":78,"updated":"2018-03-03 23:52:08.000000000","message":"nit: We could tighten this a bit:\n\n return (2 ** 32) \u003e part \u003e\u003d 0\n\nat least; if we have the part power in our head, we could do even better.","commit_id":"2bfd9c6a9b0d9ee5b547a31ba97be74b09ac3afc"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"fd7829985c3f4693474e20070b9faae40fec1474","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":"    try:"},{"line_number":77,"context_line":"        part \u003d int(dir_name)"},{"line_number":78,"context_line":"        return part \u003e\u003d 0"},{"line_number":79,"context_line":"    except ValueError:"},{"line_number":80,"context_line":"        return False"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_30aed52e","line":78,"in_reply_to":"1f9dbf25_218e3dd0","updated":"2018-03-05 19:19:28.000000000","message":"True. I\u0027d be inclined to defer that to later, though. This change is just about skipping tempdirs and other obvious garbage; I don\u0027t want the scope to creep any more than necessary.","commit_id":"2bfd9c6a9b0d9ee5b547a31ba97be74b09ac3afc"}]}