)]}'
{"test/functional/test_object.py":[{"author":{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},"change_message_id":"8711253ebf01d55f8c0fb2e79ed779c55c0a52d9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.containers \u003d []"},{"line_number":50,"context_line":"        self._create_container(self.container)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if not tf.skip2:"},{"line_number":53,"context_line":"            self._create_container(self.container, use_account\u003d2)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.obj \u003d uuid4().hex"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_62440748","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":24},"updated":"2018-02-21 02:21:28.000000000","message":"tf.skip2 is checked at the beginning of setUp.\nSo tf.skip2 is False at this timing.\nI think this change is not needed.","commit_id":"8dee7db3fc33a59a4a207a4303add66addbba28c"},{"author":{"_account_id":27832,"name":"Gerard Gine","email":"gerard.gine@me.com","username":"gerardgine"},"change_message_id":"21839b20f67a3bf5adabe3006b1f5d97663fe231","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.containers \u003d []"},{"line_number":50,"context_line":"        self._create_container(self.container)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if not tf.skip2:"},{"line_number":53,"context_line":"            self._create_container(self.container, use_account\u003d2)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.obj \u003d uuid4().hex"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_b9030f10","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":24},"in_reply_to":"3fa0c359_62440748","updated":"2018-02-21 22:45:52.000000000","message":"You\u0027re absolutely right. I will revert this.","commit_id":"8dee7db3fc33a59a4a207a4303add66addbba28c"}],"test/functional/test_symlink.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b26980af25da5d51f0f578ce3df9479924157ee0","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @classmethod"},{"line_number":57,"context_line":"    def setUp(cls):"},{"line_number":58,"context_line":"        if tf.skip or tf.skip2:"},{"line_number":59,"context_line":"            raise SkipTest"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        cls._create_container(cls.tgt_cont)  # use_account\u003d1"},{"line_number":62,"context_line":"        cls._create_container(cls.link_cont)  # use_account\u003d1"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_89577fca","line":59,"range":{"start_line":58,"start_character":8,"end_line":59,"end_character":26},"updated":"2018-10-30 23:51:48.000000000","message":"This kinda sucks, but was pre-existing. It would be *way* better if we could only skip the tests that actually *need* the second account when tf.skip2 is set...","commit_id":"e8a7729a0d3a790e180653353d435103161c2c40"}],"test/functional/test_tempurl.py":[{"author":{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},"change_message_id":"8711253ebf01d55f8c0fb2e79ed779c55c0a52d9","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                    \u0027x-container-meta-temp-url-key-2\u0027: cls.tempurl_key2,"},{"line_number":431,"context_line":"                    \u0027x-container-read\u0027: cls.account2.name}):"},{"line_number":432,"context_line":"                raise ResponseError(cls.conn.response)"},{"line_number":433,"context_line":"        else:"},{"line_number":434,"context_line":"            if not cls.container.create({"},{"line_number":435,"context_line":"                    \u0027x-container-meta-temp-url-key\u0027: cls.tempurl_key,"},{"line_number":436,"context_line":"                    \u0027x-container-meta-temp-url-key-2\u0027: cls.tempurl_key2}):"},{"line_number":437,"context_line":"                raise ResponseError(cls.conn.response)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"        cls.obj \u003d cls.container.file(Utils.create_name())"},{"line_number":440,"context_line":"        cls.obj.write(\"obj contents\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_22903f4a","line":437,"range":{"start_line":433,"start_character":0,"end_line":437,"end_character":54},"updated":"2018-02-21 02:21:28.000000000","message":"Why did you add this new process?","commit_id":"8dee7db3fc33a59a4a207a4303add66addbba28c"},{"author":{"_account_id":27832,"name":"Gerard Gine","email":"gerard.gine@me.com","username":"gerardgine"},"change_message_id":"21839b20f67a3bf5adabe3006b1f5d97663fe231","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                    \u0027x-container-meta-temp-url-key-2\u0027: cls.tempurl_key2,"},{"line_number":431,"context_line":"                    \u0027x-container-read\u0027: cls.account2.name}):"},{"line_number":432,"context_line":"                raise ResponseError(cls.conn.response)"},{"line_number":433,"context_line":"        else:"},{"line_number":434,"context_line":"            if not cls.container.create({"},{"line_number":435,"context_line":"                    \u0027x-container-meta-temp-url-key\u0027: cls.tempurl_key,"},{"line_number":436,"context_line":"                    \u0027x-container-meta-temp-url-key-2\u0027: cls.tempurl_key2}):"},{"line_number":437,"context_line":"                raise ResponseError(cls.conn.response)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"        cls.obj \u003d cls.container.file(Utils.create_name())"},{"line_number":440,"context_line":"        cls.obj.write(\"obj contents\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_bfa8cf77","line":437,"range":{"start_line":433,"start_character":0,"end_line":437,"end_character":54},"in_reply_to":"3fa0c359_22903f4a","updated":"2018-02-21 22:45:52.000000000","message":"We need to create the container for most of the tests to run. account2 is actually only used by one of them (test_tempurl_keys_hidden_from_acl_readonly), so I will move the addition of \u0027x-container-read\u0027 into that specific test.","commit_id":"8dee7db3fc33a59a4a207a4303add66addbba28c"},{"author":{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},"change_message_id":"f0e28abab56551f9e8195d0431c183f80fcd5149","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        if not tf.cluster_info.get(\u0027tempauth\u0027):"},{"line_number":592,"context_line":"            raise SkipTest(\u0027TEMP AUTH SPECIFIC TEST\u0027)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        if not self.env.container.create({"},{"line_number":595,"context_line":"                \u0027x-container-meta-temp-url-key\u0027: self.env.tempurl_key,"},{"line_number":596,"context_line":"                \u0027x-container-meta-temp-url-key-2\u0027: self.env.tempurl_key2,"},{"line_number":597,"context_line":"                \u0027x-container-read\u0027: self.env.account2.name}):"},{"line_number":598,"context_line":"            raise ResponseError(self.env.conn.response)"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        original_token \u003d self.env.container.conn.storage_token"},{"line_number":601,"context_line":"        self.env.container.conn.storage_token \u003d self.env.conn2.storage_token"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_ee43e86a","line":598,"range":{"start_line":594,"start_character":0,"end_line":598,"end_character":55},"updated":"2018-02-23 07:18:31.000000000","message":"I think creating container at this timing for only this test is nice.\nBut in this implementation, the metadata of self.env.container is updated and it is not reverted.\nSo in other tests, self.env.container may have \u0027x-container-read\u0027. I think it is bad.\n\nWould you make new container name for this test with Utils.create_name()?","commit_id":"47aede15c4c6f29fcdb2762bd813d49cb4cd45fa"},{"author":{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},"change_message_id":"cfeb90f73bc1a9a07713af4247bcbc9dba102838","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        if not tf.cluster_info.get(\u0027tempauth\u0027):"},{"line_number":592,"context_line":"            raise SkipTest(\u0027TEMP AUTH SPECIFIC TEST\u0027)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        if not self.env.container.create({"},{"line_number":595,"context_line":"                \u0027x-container-meta-temp-url-key\u0027: self.env.tempurl_key,"},{"line_number":596,"context_line":"                \u0027x-container-meta-temp-url-key-2\u0027: self.env.tempurl_key2,"},{"line_number":597,"context_line":"                \u0027x-container-read\u0027: self.env.account2.name}):"},{"line_number":598,"context_line":"            raise ResponseError(self.env.conn.response)"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        original_token \u003d self.env.container.conn.storage_token"},{"line_number":601,"context_line":"        self.env.container.conn.storage_token \u003d self.env.conn2.storage_token"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f9dbf25_35cb20a6","line":598,"range":{"start_line":594,"start_character":0,"end_line":598,"end_character":55},"in_reply_to":"3fa0c359_8eb80b75","updated":"2018-02-27 14:40:29.000000000","message":"I agree that the permission change doesn\u0027t adversely affect other tests FOR NOW.\nI\u0027m worried about future changing or adding tests.\nFor example, if someone want to add another test about tempurl read permission, the person expect the container have no x-container-read, because setup method of env makes container without x-container-read.\nBut this test may break the premise and the break depends on test running order.\nI think the behavior makes debug harder.","commit_id":"47aede15c4c6f29fcdb2762bd813d49cb4cd45fa"},{"author":{"_account_id":27832,"name":"Gerard Gine","email":"gerard.gine@me.com","username":"gerardgine"},"change_message_id":"f966bbd133646c0914eb33220328e264ff6dcca9","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        if not tf.cluster_info.get(\u0027tempauth\u0027):"},{"line_number":592,"context_line":"            raise SkipTest(\u0027TEMP AUTH SPECIFIC TEST\u0027)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        if not self.env.container.create({"},{"line_number":595,"context_line":"                \u0027x-container-meta-temp-url-key\u0027: self.env.tempurl_key,"},{"line_number":596,"context_line":"                \u0027x-container-meta-temp-url-key-2\u0027: self.env.tempurl_key2,"},{"line_number":597,"context_line":"                \u0027x-container-read\u0027: self.env.account2.name}):"},{"line_number":598,"context_line":"            raise ResponseError(self.env.conn.response)"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        original_token \u003d self.env.container.conn.storage_token"},{"line_number":601,"context_line":"        self.env.container.conn.storage_token \u003d self.env.conn2.storage_token"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_8eb80b75","line":598,"range":{"start_line":594,"start_character":0,"end_line":598,"end_character":55},"in_reply_to":"3fa0c359_ee43e86a","updated":"2018-02-25 00:01:56.000000000","message":"The fact that we give account2 read permissions shouldn\u0027t have an effect on the rest of tests. In fact, originally all the tests were setup like that, and now it\u0027s only this one and the ones that come after it. It\u0027s true, we don\u0027t need it in the rest of the tests, but it\u0027s not bad either.","commit_id":"47aede15c4c6f29fcdb2762bd813d49cb4cd45fa"}]}