)]}'
{"swift/common/db_replicator.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2f0aa56e3c06550c70342ef76b7404e628c1e08d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                     walk. The context may be any object; the context is not"},{"line_number":93,"context_line":"                     used by this function but is included with each yielded"},{"line_number":94,"context_line":"                     tuple."},{"line_number":95,"context_line":"    :param datadirs: a list of (path, node_id, partition_filter) to walk"},{"line_number":96,"context_line":"    :returns: A generator of (partition, path_to_db_file, context)"},{"line_number":97,"context_line":"    \"\"\""},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f6a8fd7_700d0d3d","line":95,"range":{"start_line":95,"start_character":4,"end_line":95,"end_character":72},"updated":"2018-04-18 12:32:33.000000000","message":"duplicate","commit_id":"3629ab4034e6818da0534fb139a0e719d8d2f8f0"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ad57a040a7422ecea6fb08fb89c037aebca8f3f2","unresolved":false,"context_lines":[{"line_number":699,"context_line":"                else:"},{"line_number":700,"context_line":"                    self.logger.debug(\u0027Deleted handoff db %s\u0027, broker.db_file)"},{"line_number":701,"context_line":"            else:"},{"line_number":702,"context_line":"                self.logger.debug(\u0027Not deleting handoff db %s\u0027, broker.db_file)"},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"        target_devs_info \u003d set([(target_dev[\u0027replication_ip\u0027],"},{"line_number":705,"context_line":"                                 target_dev[\u0027device\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_e298656b","line":702,"updated":"2018-04-17 19:35:41.000000000","message":"this looks pretty descriptive!\n\nseems like everything gets picked up in unittests...","commit_id":"6a83aeb8cde2dddbb4703df5de8d761d6188d10d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ad498a2a78a159d0cfd2a93435dcd3c5829d3d2e","unresolved":false,"context_lines":[{"line_number":699,"context_line":"                else:"},{"line_number":700,"context_line":"                    self.logger.debug(\u0027Deleted handoff db %s\u0027, broker.db_file)"},{"line_number":701,"context_line":"            else:"},{"line_number":702,"context_line":"                self.logger.debug(\u0027Not deleting handoff db %s\u0027, broker.db_file)"},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"        target_devs_info \u003d set([(target_dev[\u0027replication_ip\u0027],"},{"line_number":705,"context_line":"                                 target_dev[\u0027device\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f6a8fd7_f38d79d3","line":702,"updated":"2018-04-18 20:04:42.000000000","message":"oh good, it\u0027s back","commit_id":"cbc7f207ad2ccf9677323c36bc8bdfd92b8bb6b7"}],"swift/container/sharder.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"fd70bb29094425ef42008af0951cbd6dae269dbd","unresolved":false,"context_lines":[{"line_number":756,"context_line":"                if node[\u0027id\u0027] \u003d\u003d node_id:"},{"line_number":757,"context_line":"                    break"},{"line_number":758,"context_line":"            else:"},{"line_number":759,"context_line":"                node \u003d self.ring.devs[node_id]"},{"line_number":760,"context_line":"                # Set index such that we\u0027ll *never* be selected as a leader"},{"line_number":761,"context_line":"                node[\u0027index\u0027] \u003d \u0027handoff\u0027"},{"line_number":762,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_529b3171","line":759,"range":{"start_line":759,"start_character":16,"end_line":759,"end_character":46},"updated":"2018-03-08 13:42:46.000000000","message":"It\u0027s silly that the node dict is lost via roundrobin_datadirs, and there is no need for that since node_id part of the dirs tuples is treated as a black box.\n\nhttps://gist.github.com/alistairncoles/69533f6dcc16d54c27a3b86da2e15c93","commit_id":"7796ecea02a136a661ee4990026683bd7b786e07"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"fd70bb29094425ef42008af0951cbd6dae269dbd","unresolved":false,"context_lines":[{"line_number":758,"context_line":"            else:"},{"line_number":759,"context_line":"                node \u003d self.ring.devs[node_id]"},{"line_number":760,"context_line":"                # Set index such that we\u0027ll *never* be selected as a leader"},{"line_number":761,"context_line":"                node[\u0027index\u0027] \u003d \u0027handoff\u0027"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"            broker \u003d ContainerBroker(path, logger\u003dself.logger)"},{"line_number":764,"context_line":"            if sharding_enabled(broker):"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_52749135","line":761,"range":{"start_line":761,"start_character":16,"end_line":761,"end_character":41},"updated":"2018-03-08 13:42:46.000000000","message":"I wonder if we could just pass a leader arg to process_broker...but leave it this way for now because I suspect we\u0027ll be refactoring process_broker to support an external \u0027leader\u0027 actor maaging sharding.","commit_id":"7796ecea02a136a661ee4990026683bd7b786e07"}],"test/probe/test_sharder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ad57a040a7422ecea6fb08fb89c037aebca8f3f2","unresolved":false,"context_lines":[{"line_number":827,"context_line":"        # the objects won\u0027t be listed anymore"},{"line_number":828,"context_line":"        self.assert_container_listing([])"},{"line_number":829,"context_line":"        # but root container stats will not yet be aware of the deletions"},{"line_number":830,"context_line":"        self.assert_container_delete_fails()"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        # One server was down while the shard sharded its first two sub-shards,"},{"line_number":833,"context_line":"        # so there may be undeleted handoff db(s) for sub-shard(s) that were"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_bdf5accd","line":830,"updated":"2018-04-17 19:35:41.000000000","message":"good cleanup here","commit_id":"6a83aeb8cde2dddbb4703df5de8d761d6188d10d"}]}