)]}'
{"swift/common/middleware/s3api/acl_handlers.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"84bb4927f63b71894045651c423fc6d45ca38f72","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            try:"},{"line_number":171,"context_line":"                elem \u003d fromstring(body, ACL.root_tag)"},{"line_number":172,"context_line":"                acl \u003d ACL.from_elem("},{"line_number":173,"context_line":"                    elem, True, self.req.allow_no_owner)"},{"line_number":174,"context_line":"            except(XMLSyntaxError, DocumentInvalid):"},{"line_number":175,"context_line":"                raise MalformedACLError()"},{"line_number":176,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_116012a5","line":173,"range":{"start_line":173,"start_character":26,"end_line":173,"end_character":30},"updated":"2018-03-22 00:19:34.000000000","message":"!\n\nSo... are we deciding that s3_acl should always be enabled? Or am I mis-reading this?","commit_id":"b512ff0574a4f03a6289619e991aa1ac1bf83ff7"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"dc3adba854890b77a432026d707e926a897e2245","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            try:"},{"line_number":171,"context_line":"                elem \u003d fromstring(body, ACL.root_tag)"},{"line_number":172,"context_line":"                acl \u003d ACL.from_elem("},{"line_number":173,"context_line":"                    elem, True, self.req.allow_no_owner)"},{"line_number":174,"context_line":"            except(XMLSyntaxError, DocumentInvalid):"},{"line_number":175,"context_line":"                raise MalformedACLError()"},{"line_number":176,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_c59e5006","line":173,"range":{"start_line":173,"start_character":26,"end_line":173,"end_character":30},"in_reply_to":"df7087c5_116012a5","updated":"2018-03-22 05:21:19.000000000","message":"No we didn\u0027t dicide yet. \n\nThe reason we could set True always is that I found the acl_handler module is now only used in S3AclRequest (and its subclasses). that means the ACL model always used as s3_acl is True.\n\nIf we want to use the abstraction of ACL model around here, we may push back it\u0027s choosable by caller but, anyway, the elements should be defined by S3AclRequest(i.e. s3acl \u003d True) for now so it\u0027s safe we can assume the ACL is only from s3_acl\u003dTrue case...\n\nThat is what I thought. does it make you sense?","commit_id":"b512ff0574a4f03a6289619e991aa1ac1bf83ff7"}]}