)]}'
{"swift/container/sharder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dc6ab09efa0a8eead9c63688a320d8a4bc98f767","unresolved":false,"context_lines":[{"line_number":678,"context_line":"                    else:"},{"line_number":679,"context_line":"                        self.logger.debug("},{"line_number":680,"context_line":"                            \u0027Shard ranges found but own shard range is %r: %s\u0027"},{"line_number":681,"context_line":"                            % (own_shard_range.state_text, broker.path))"},{"line_number":682,"context_line":"                elif own_shard_range.state in (ShardRange.SHARDING,"},{"line_number":683,"context_line":"                                               ShardRange.SHRINKING):"},{"line_number":684,"context_line":"                    broker.update_sharding_info({\u0027Scan-Done\u0027: \u0027False\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_5cb9a412","line":681,"updated":"2018-03-22 20:29:01.000000000","message":"is this an ok state tho?","commit_id":"54de111296e8b80f4e3ed54dde88fdc31621dd67"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"45cba9f45d999bb3f6a5b292672dd2948e2c7be2","unresolved":false,"context_lines":[{"line_number":678,"context_line":"                    else:"},{"line_number":679,"context_line":"                        self.logger.debug("},{"line_number":680,"context_line":"                            \u0027Shard ranges found but own shard range is %r: %s\u0027"},{"line_number":681,"context_line":"                            % (own_shard_range.state_text, broker.path))"},{"line_number":682,"context_line":"                elif own_shard_range.state in (ShardRange.SHARDING,"},{"line_number":683,"context_line":"                                               ShardRange.SHRINKING):"},{"line_number":684,"context_line":"                    broker.update_sharding_info({\u0027Scan-Done\u0027: \u0027False\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_57fc1fb4","line":681,"in_reply_to":"df7087c5_5cb9a412","updated":"2018-03-22 21:03:41.000000000","message":"This is the state we\u0027ll be in after externally injecting shard ranges but not yet bumping own shard range state to SHARDING.\n\nI can also imagine in the future we might decide to allow the daemon to find shard ranges automatically but not trigger sharding. Then human comes along and bumps own shard range state to trigger sharding. Maybe not. But I think the state is ok.","commit_id":"54de111296e8b80f4e3ed54dde88fdc31621dd67"}],"test/unit/container/test_sharder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dc6ab09efa0a8eead9c63688a320d8a4bc98f767","unresolved":false,"context_lines":[{"line_number":2060,"context_line":"        with self._mock_sharder() as sharder:"},{"line_number":2061,"context_line":"            sharder._process_broker(broker, node, 99)"},{"line_number":2062,"context_line":"        self.assertIsNone(broker.get_own_shard_range(no_default\u003dTrue))"},{"line_number":2063,"context_line":"        self.assertEqual(UNSHARDED, broker.get_db_state())"},{"line_number":2064,"context_line":"        self.assertFalse(broker.logger.get_lines_for_level(\u0027warning\u0027))"},{"line_number":2065,"context_line":"        self.assertFalse(broker.logger.get_lines_for_level(\u0027error\u0027))"},{"line_number":2066,"context_line":"        broker.logger.clear()"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_9cac1cee","line":2063,"updated":"2018-03-22 20:29:01.000000000","message":"this doesn\u0027t make sense to me - we just added shard_ranges - should we *really* be in UNSHARDED state?","commit_id":"54de111296e8b80f4e3ed54dde88fdc31621dd67"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"45cba9f45d999bb3f6a5b292672dd2948e2c7be2","unresolved":false,"context_lines":[{"line_number":2060,"context_line":"        with self._mock_sharder() as sharder:"},{"line_number":2061,"context_line":"            sharder._process_broker(broker, node, 99)"},{"line_number":2062,"context_line":"        self.assertIsNone(broker.get_own_shard_range(no_default\u003dTrue))"},{"line_number":2063,"context_line":"        self.assertEqual(UNSHARDED, broker.get_db_state())"},{"line_number":2064,"context_line":"        self.assertFalse(broker.logger.get_lines_for_level(\u0027warning\u0027))"},{"line_number":2065,"context_line":"        self.assertFalse(broker.logger.get_lines_for_level(\u0027error\u0027))"},{"line_number":2066,"context_line":"        broker.logger.clear()"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_b7d9fb56","line":2063,"in_reply_to":"df7087c5_9cac1cee","updated":"2018-03-22 21:03:41.000000000","message":"yes - db_state UNSHARDED means we still only have original db. The test is verifying that is the case i.e. even when broker has shard ranges it will not start sharding if own shard range is not in correct state.\n\nI prefer this to just starting sharding process as soon as shard ranges are found. It means we could accumulate shard ranges in the broker db as they are found, then trigger sharding once they are all there, for example.\n\nSo, there\u0027s ONE gate on sharding starting, which is own shard range state. In auto_shard mode the leader node bootstraps own shard range to that state. In manual mode, manage_shard_ranges sets that state.","commit_id":"54de111296e8b80f4e3ed54dde88fdc31621dd67"}]}
