)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"fb9de4270ab6b2a61903eccfa07e4b7a6652d9c1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove race between checking for state shrinking and acting upon it"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I saw a probe test fail during shrinking because the root shard range"},{"line_number":10,"context_line":"table had both the expanded acceptor in active state and the undeleted"},{"line_number":11,"context_line":"donor in shrinking state. No shrinking activity had actually occurred"},{"line_number":12,"context_line":"on any replica of the donor."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf659307_bebba10c","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":52},"updated":"2018-03-23 17:10:59.000000000","message":"I still don\u0027t understand who moved this to active... I thought that part of the story of https://review.openstack.org/#/c/551331/ was to have the donor move it to active when it was done shrinking?\n\nOh... no, I guess we do it on the root, before sending the acceptor to the donor... hmm...","commit_id":"00ae2f4f3f1ac2ce554845754db2c52a4a89405a"}],"swift/container/sharder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"fb9de4270ab6b2a61903eccfa07e4b7a6652d9c1","unresolved":false,"context_lines":[{"line_number":639,"context_line":"            if broker.is_own_shard_range(shard_range):"},{"line_number":640,"context_line":"                break"},{"line_number":641,"context_line":"        else:"},{"line_number":642,"context_line":"            return"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        if shard_range.state \u003d\u003d ShardRange.SHRINKING:"},{"line_number":645,"context_line":"            # only send own shard range while shrinking"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_fe37d9e2","line":642,"updated":"2018-03-23 17:10:59.000000000","message":"I wonder whether this should raise an exception. We *just merged* own_shard_range, if we can\u0027t get it back out (potentially with an updated state), that seems like a bug.","commit_id":"00ae2f4f3f1ac2ce554845754db2c52a4a89405a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b0724fec55445b981d2f7cdac1a3315eaa2e9a7b","unresolved":false,"context_lines":[{"line_number":639,"context_line":"            if broker.is_own_shard_range(shard_range):"},{"line_number":640,"context_line":"                break"},{"line_number":641,"context_line":"        else:"},{"line_number":642,"context_line":"            return"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        if shard_range.state \u003d\u003d ShardRange.SHRINKING:"},{"line_number":645,"context_line":"            # only send own shard range while shrinking"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_01f590cb","line":642,"in_reply_to":"bf659307_fe37d9e2","updated":"2018-03-23 17:48:59.000000000","message":"+1\n\nit felt bad not typing else, but then I ran out of ideas :)","commit_id":"00ae2f4f3f1ac2ce554845754db2c52a4a89405a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"fb9de4270ab6b2a61903eccfa07e4b7a6652d9c1","unresolved":false,"context_lines":[{"line_number":706,"context_line":"                            % (own_shard_range.state_text, broker.path))"},{"line_number":707,"context_line":"                elif own_shard_range.state in (ShardRange.SHARDING,"},{"line_number":708,"context_line":"                                               ShardRange.SHRINKING):"},{"line_number":709,"context_line":"                    broker.update_sharding_info({\u0027Scan-Done\u0027: \u0027False\u0027})"},{"line_number":710,"context_line":"                    if broker.set_sharding_state():"},{"line_number":711,"context_line":"                        state \u003d SHARDING"},{"line_number":712,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_7b675b27","line":709,"updated":"2018-03-23 17:10:59.000000000","message":"Off-topic: What scanning needs to be done when shrinking? Or does _find_shard_ranges sorta short-circuit since we have another range that covers our entire namespace and then some?","commit_id":"00ae2f4f3f1ac2ce554845754db2c52a4a89405a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"fb9de4270ab6b2a61903eccfa07e4b7a6652d9c1","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"        cleave_cursor \u003d cleave_context.get(\u0027cursor\u0027) or \u0027\u0027"},{"line_number":1176,"context_line":"        ranges_todo \u003d broker.get_shard_ranges("},{"line_number":1177,"context_line":"            marker\u003dcleave_cursor + \u0027\\x00\u0027,"},{"line_number":1178,"context_line":"            states\u003d[ShardRange.CREATED, ShardRange.CLEAVED, ShardRange.ACTIVE])"},{"line_number":1179,"context_line":"        if not ranges_todo:"},{"line_number":1180,"context_line":"            self.logger.debug(\u0027No shard ranges to cleave for %s/%s\u0027,"},{"line_number":1181,"context_line":"                              broker.account, broker.container)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_7bf43b5c","line":1178,"updated":"2018-03-23 17:10:59.000000000","message":"No EXPANDING? Or is vacating a shrinking db dealt with over in misplaced_objects?","commit_id":"00ae2f4f3f1ac2ce554845754db2c52a4a89405a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b0724fec55445b981d2f7cdac1a3315eaa2e9a7b","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"        cleave_cursor \u003d cleave_context.get(\u0027cursor\u0027) or \u0027\u0027"},{"line_number":1176,"context_line":"        ranges_todo \u003d broker.get_shard_ranges("},{"line_number":1177,"context_line":"            marker\u003dcleave_cursor + \u0027\\x00\u0027,"},{"line_number":1178,"context_line":"            states\u003d[ShardRange.CREATED, ShardRange.CLEAVED, ShardRange.ACTIVE])"},{"line_number":1179,"context_line":"        if not ranges_todo:"},{"line_number":1180,"context_line":"            self.logger.debug(\u0027No shard ranges to cleave for %s/%s\u0027,"},{"line_number":1181,"context_line":"                              broker.account, broker.container)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_4188681e","line":1178,"in_reply_to":"bf659307_7bf43b5c","updated":"2018-03-23 17:48:59.000000000","message":"the acceptor copy sent to the donor is ACTIVE\n\nit is only EXPANDING in the acceptor container\n\nI\u0027m not in love with the EXPANDING state. It was an improvement over the flawed timestamp trickery.","commit_id":"00ae2f4f3f1ac2ce554845754db2c52a4a89405a"}]}
