)]}'
{"swift/container/backend.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"710d47d2a4c46d9c0da9e703e9a9e67b6f68974a","unresolved":false,"context_lines":[{"line_number":750,"context_line":"        query_args \u003d [storage_policy_index]"},{"line_number":751,"context_line":"        if max_row is not None:"},{"line_number":752,"context_line":"            query_conditions.append(\u0027ROWID \u003c\u003d ?\u0027)"},{"line_number":753,"context_line":"            query_args.append(str(max_row))"},{"line_number":754,"context_line":"        if lower:"},{"line_number":755,"context_line":"            query_conditions.append(\u0027name \u003e ?\u0027)"},{"line_number":756,"context_line":"            query_args.append(str(lower))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_235b9f54","line":753,"range":{"start_line":753,"start_character":30,"end_line":753,"end_character":42},"updated":"2018-03-27 20:34:08.000000000","message":"This should always be an int, yeah? Why str() it?","commit_id":"1da1248d1c00fd4d253bcb80a44d52311baaea02"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"5c9ed31bb64737f5d9648fd894de52bb9b2df71b","unresolved":false,"context_lines":[{"line_number":756,"context_line":"            query_args.append(str(lower))"},{"line_number":757,"context_line":"        if upper:"},{"line_number":758,"context_line":"            query_conditions.append(\u0027name \u003c\u003d ?\u0027)"},{"line_number":759,"context_line":"            query_args.append(str(upper))"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"        query \u003d \u0027DELETE FROM object WHERE deleted in (0, 1)\u0027"},{"line_number":762,"context_line":"        if query_conditions:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_1e511063","line":759,"range":{"start_line":759,"start_character":30,"end_line":759,"end_character":40},"updated":"2018-03-27 21:04:13.000000000","message":"Will upper/lower ever *not* be strings? I thought all callers were already doing things like\n\n str(dest_shard_range.upper)","commit_id":"1da1248d1c00fd4d253bcb80a44d52311baaea02"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"710d47d2a4c46d9c0da9e703e9a9e67b6f68974a","unresolved":false,"context_lines":[{"line_number":759,"context_line":"            query_args.append(str(upper))"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"        query \u003d \u0027DELETE FROM object WHERE deleted in (0, 1)\u0027"},{"line_number":762,"context_line":"        if query_conditions:"},{"line_number":763,"context_line":"            query +\u003d \u0027 AND \u0027 + \u0027 AND \u0027.join(query_conditions)"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        with self.get() as conn:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_e302870b","line":762,"updated":"2018-03-27 20:34:08.000000000","message":"This is always true -- we must have at least a storage_policy_index condition.","commit_id":"1da1248d1c00fd4d253bcb80a44d52311baaea02"}],"swift/container/sharder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"710d47d2a4c46d9c0da9e703e9a9e67b6f68974a","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                broker.remove_objects("},{"line_number":393,"context_line":"                    str(dest_shard_range.lower), str(dest_shard_range.upper),"},{"line_number":394,"context_line":"                    policy_index, info[\u0027max_row\u0027])"},{"line_number":395,"context_line":"                success \u003d True"},{"line_number":396,"context_line":"        if not success:"},{"line_number":397,"context_line":"            self.logger.warning("},{"line_number":398,"context_line":"                \u0027Refused to remove misplaced objects: %s in %s\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_3e7094a5","line":395,"updated":"2018-03-27 20:34:08.000000000","message":"Hmm... so we can even get here if success was previously False? I need to refresh my memory about what\u0027s going on in _replicate_object...","commit_id":"1da1248d1c00fd4d253bcb80a44d52311baaea02"}]}
