)]}'
{"swift/container/backend.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"59ec7de2389cfd7d351a1e1a020b459288f78c60","unresolved":false,"context_lines":[{"line_number":53,"context_line":"SHARD_STATS_STATES \u003d [ShardRange.ACTIVE, ShardRange.SHARDING,"},{"line_number":54,"context_line":"                      ShardRange.SHRINKING, ShardRange.EXPANDING]"},{"line_number":55,"context_line":"SHARD_LISTING_STATES \u003d SHARD_STATS_STATES + [ShardRange.CLEAVED]"},{"line_number":56,"context_line":"SHARD_UPDATE_STATES \u003d SHARD_LISTING_STATES + [ShardRange.CREATED]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def db_state_text(state):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_cdfd89b2","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":19},"updated":"2018-04-04 20:20:06.000000000","message":"Wait, this includes SHRINKING?\n\nSeparately, I really want to use these in the container-server, too, even if it\u0027s just as something like\n\n aliases \u003d {\u0027listing\u0027: {ShardRange.STATES[s] for s in SHARD_LISTING_STATES},\n            \u0027updating\u0027: {ShardRange.STATES[s] for s in SHARD_UPDATE_STATES}}","commit_id":"9956d6ff27dbb7d94d0680ccf74152f808f73396"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"88414c40f49aa21a7611cc99c2b924a0ef1b8a4e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"SHARD_STATS_STATES \u003d [ShardRange.ACTIVE, ShardRange.SHARDING,"},{"line_number":54,"context_line":"                      ShardRange.SHRINKING, ShardRange.EXPANDING]"},{"line_number":55,"context_line":"SHARD_LISTING_STATES \u003d SHARD_STATS_STATES + [ShardRange.CLEAVED]"},{"line_number":56,"context_line":"SHARD_UPDATE_STATES \u003d SHARD_LISTING_STATES + [ShardRange.CREATED]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def db_state_text(state):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_8fc8bb74","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":19},"in_reply_to":"bf659307_cdfd89b2","updated":"2018-04-06 17:10:57.000000000","message":"re SHRINKING - on my radar and trello - it\u0027s way more obvious once we get rid of expanding [1] because there should always be an overlapping active acceptor to redirect updates to.\n\n[1] https://review.openstack.org/558232\n\nre aliases - me too but there\u0027s stuff that can be cleaned up after merge to master, and then there\u0027s another long list ;)","commit_id":"9956d6ff27dbb7d94d0680ccf74152f808f73396"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"59ec7de2389cfd7d351a1e1a020b459288f78c60","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"    def get_shard_usage(self):"},{"line_number":1720,"context_line":"        states \u003d SHARD_STATS_STATES"},{"line_number":1721,"context_line":"        if not self.is_root_container():"},{"line_number":1722,"context_line":"            states \u003d states + [ShardRange.CLEAVED]"},{"line_number":1723,"context_line":"        shard_ranges \u003d self.get_shard_ranges(states\u003dstates)"},{"line_number":1724,"context_line":"        return {\u0027bytes_used\u0027: sum([sr.bytes_used for sr in shard_ranges]),"},{"line_number":1725,"context_line":"                \u0027object_count\u0027: sum([sr.object_count for sr in shard_ranges])}"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_ad6b7583","line":1722,"updated":"2018-04-04 20:20:06.000000000","message":"Remind me why we have this exception for shards -- does it still make sense following https://review.openstack.org/#/c/558155/? Did it *ever* make sense? I feel like any CLEAVED ranges will always overlap with the parent SHARDING range, and we\u0027re willing to accept the stats lag of always using the SHARDING container\u0027s stats...","commit_id":"9956d6ff27dbb7d94d0680ccf74152f808f73396"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"88414c40f49aa21a7611cc99c2b924a0ef1b8a4e","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"    def get_shard_usage(self):"},{"line_number":1720,"context_line":"        states \u003d SHARD_STATS_STATES"},{"line_number":1721,"context_line":"        if not self.is_root_container():"},{"line_number":1722,"context_line":"            states \u003d states + [ShardRange.CLEAVED]"},{"line_number":1723,"context_line":"        shard_ranges \u003d self.get_shard_ranges(states\u003dstates)"},{"line_number":1724,"context_line":"        return {\u0027bytes_used\u0027: sum([sr.bytes_used for sr in shard_ranges]),"},{"line_number":1725,"context_line":"                \u0027object_count\u0027: sum([sr.object_count for sr in shard_ranges])}"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_6fc207ec","line":1722,"in_reply_to":"bf659307_ad6b7583","updated":"2018-04-06 17:10:57.000000000","message":"it\u0027s not necessary, we don\u0027t even call this unless its a root container #willfix","commit_id":"9956d6ff27dbb7d94d0680ccf74152f808f73396"}]}