)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b02ad14bc97a0fd6c1dc523c1734cef83489f861","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to object requests."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also, return x-backend-record-type header with container GET"},{"line_number":14,"context_line":"responses, and check it in sharder _fetch_shard_ranges."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I6e01f110e8ff9900a8ed4ea39b7d643e1d5c99a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_bf943b8c","line":14,"updated":"2018-04-12 22:26:39.000000000","message":"We should also look for this in the proxy controller, I think.","commit_id":"750d3447f92f8617c2bf8f97bc70d6d4c9ed4413"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"69dab35268e770520c5c8e822a2a113dcba8e5d2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to object requests."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also, return x-backend-record-type header with container GET"},{"line_number":14,"context_line":"responses, and check it in sharder _fetch_shard_ranges."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I6e01f110e8ff9900a8ed4ea39b7d643e1d5c99a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_76855eac","line":14,"in_reply_to":"bf659307_bf943b8c","updated":"2018-04-13 13:15:38.000000000","message":"Had that on list for next patch but will add to next version of this patch","commit_id":"750d3447f92f8617c2bf8f97bc70d6d4c9ed4413"}],"swift/container/server.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b02ad14bc97a0fd6c1dc523c1734cef83489f861","unresolved":false,"context_lines":[{"line_number":518,"context_line":"            # Conversion has already happened (e.g. from a sharded node)"},{"line_number":519,"context_line":"            return record"},{"line_number":520,"context_line":"        if isinstance(record, ShardRange):"},{"line_number":521,"context_line":"            created \u003d record.timestamp"},{"line_number":522,"context_line":"            response \u003d dict(record)"},{"line_number":523,"context_line":"        else:"},{"line_number":524,"context_line":"            (name, created, size, content_type, etag) \u003d record[:5]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_5fb63f40","line":521,"updated":"2018-04-12 22:26:39.000000000","message":"With that indent, we don\u0027t need this any more. Are we sure we don\u0027t want to have a human-readable timestamp, though?","commit_id":"750d3447f92f8617c2bf8f97bc70d6d4c9ed4413"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"69dab35268e770520c5c8e822a2a113dcba8e5d2","unresolved":false,"context_lines":[{"line_number":518,"context_line":"            # Conversion has already happened (e.g. from a sharded node)"},{"line_number":519,"context_line":"            return record"},{"line_number":520,"context_line":"        if isinstance(record, ShardRange):"},{"line_number":521,"context_line":"            created \u003d record.timestamp"},{"line_number":522,"context_line":"            response \u003d dict(record)"},{"line_number":523,"context_line":"        else:"},{"line_number":524,"context_line":"            (name, created, size, content_type, etag) \u003d record[:5]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_7600fe34","line":521,"in_reply_to":"bf659307_5fb63f40","updated":"2018-04-13 13:15:38.000000000","message":"I\u0027ll roll that change back","commit_id":"750d3447f92f8617c2bf8f97bc70d6d4c9ed4413"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b02ad14bc97a0fd6c1dc523c1734cef83489f861","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        record_type \u003d req.headers.get(\u0027x-backend-record-type\u0027, \u0027\u0027).lower()"},{"line_number":570,"context_line":"        if record_type \u003d\u003d \u0027shard\u0027:"},{"line_number":571,"context_line":"            resp_headers \u003d gen_resp_headers(info)"},{"line_number":572,"context_line":"            resp_headers[\u0027X-Backend-Record-Type\u0027] \u003d \u0027shard\u0027"},{"line_number":573,"context_line":"            includes \u003d get_param(req, \u0027includes\u0027)"},{"line_number":574,"context_line":"            states \u003d get_param(req, \u0027state\u0027) or None"},{"line_number":575,"context_line":"            if states:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_df7b2f78","line":572,"updated":"2018-04-12 22:26:39.000000000","message":"+100","commit_id":"750d3447f92f8617c2bf8f97bc70d6d4c9ed4413"}],"swift/container/sharder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b02ad14bc97a0fd6c1dc523c1734cef83489f861","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        except (ValueError, TypeError):"},{"line_number":273,"context_line":"            err \u003d \u0027invalid data\u0027"},{"line_number":274,"context_line":"            self.logger.error(\"Failed to get shard ranges from %s: %s\","},{"line_number":275,"context_line":"                              broker.root_path, err)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def _put_container(self, node, part, account, container, headers, body):"},{"line_number":278,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_fff39307","line":275,"updated":"2018-04-12 22:26:39.000000000","message":"Might want an explicit\n\n return None\n\nhere.","commit_id":"750d3447f92f8617c2bf8f97bc70d6d4c9ed4413"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"69dab35268e770520c5c8e822a2a113dcba8e5d2","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        except (ValueError, TypeError):"},{"line_number":273,"context_line":"            err \u003d \u0027invalid data\u0027"},{"line_number":274,"context_line":"            self.logger.error(\"Failed to get shard ranges from %s: %s\","},{"line_number":275,"context_line":"                              broker.root_path, err)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def _put_container(self, node, part, account, container, headers, body):"},{"line_number":278,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_b6ea1671","line":275,"in_reply_to":"bf659307_fff39307","updated":"2018-04-13 13:15:38.000000000","message":"Done","commit_id":"750d3447f92f8617c2bf8f97bc70d6d4c9ed4413"}]}
