)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"0602b2b5e6035f889f1b6a915019164fb6344776","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve path handling in proxy_logging"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the access log, proxy_logging places the URL path,"},{"line_number":10,"context_line":"double-URL-encoded (e.g. \" \" -\u003e %20 -\u003e %2520)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In the WSGI environment, env[\u0027PATH_INFO\u0027] is the unquoted path sent by"},{"line_number":13,"context_line":"the client, e.g. \"/v1/a/c/o\" or \"/v1/a/c/obj with spaces\" or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_1563221c","line":10,"updated":"2018-05-23 23:22:39.000000000","message":"This sentence implies a desire to change the double-quoting, but the patch isn\u0027t doing it (I verified the code, and the changelog says \"same result as before but faster\"). Do you intend to get rid of double-quoting or not?","commit_id":"f8419bf68a02afca7802a30bc3844d651b9e3469"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"c7365c311db04442abee5ea4fda800ffbdedbcf4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve path handling in proxy_logging"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the access log, proxy_logging places the URL path,"},{"line_number":10,"context_line":"double-URL-encoded (e.g. \" \" -\u003e %20 -\u003e %2520)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In the WSGI environment, env[\u0027PATH_INFO\u0027] is the unquoted path sent by"},{"line_number":13,"context_line":"the client, e.g. \"/v1/a/c/o\" or \"/v1/a/c/obj with spaces\" or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_d8b71f86","line":10,"in_reply_to":"5f7c97a3_1563221c","updated":"2018-05-24 01:15:12.000000000","message":"No, I intend to leave the log format exactly the same. Otherwise, a URL path with a space in it could break log parsers.","commit_id":"f8419bf68a02afca7802a30bc3844d651b9e3469"}],"swift/common/middleware/proxy_logging.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d49c04210ac1104b1ce0135fe4ff5fc4320c85bd","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        resp_headers \u003d resp_headers or {}"},{"line_number":155,"context_line":"        the_request \u003d req.path"},{"line_number":156,"context_line":"        if req.query_string:"},{"line_number":157,"context_line":"            the_request \u003d the_request + \u0027?\u0027 + req.query_string"},{"line_number":158,"context_line":"        logged_headers \u003d None"},{"line_number":159,"context_line":"        if self.log_hdrs:"},{"line_number":160,"context_line":"            if self.log_hdrs_only:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_47a7a3a8","line":157,"updated":"2018-06-15 00:08:45.000000000","message":"nit:\n\n the_request \u003d req.path_qs\n\n...in fact, the_request is only used once anyway, so we could just get rid of the temporary variable entirely.","commit_id":"f8419bf68a02afca7802a30bc3844d651b9e3469"}]}