)]}'
{"swift/container/server.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"1b2dd383fe43bc4306ac3457b1ed59ce76ad28a7","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                                                              SHARDED):"},{"line_number":590,"context_line":"            record_type \u003d \u0027shard\u0027"},{"line_number":591,"context_line":"            # reset limit -- that was intended for objects"},{"line_number":592,"context_line":"            limit \u003d constraints.CONTAINER_LISTING_LIMIT"},{"line_number":593,"context_line":"        if record_type \u003d\u003d \u0027shard\u0027:"},{"line_number":594,"context_line":"            resp_headers \u003d gen_resp_headers(info)"},{"line_number":595,"context_line":"            override_deleted \u003d config_true_value("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_44343493","line":592,"range":{"start_line":592,"start_character":12,"end_line":592,"end_character":55},"updated":"2018-04-24 07:54:11.000000000","message":"Good spot. Any object limit is inappropriate here.\n\nI agree we need to override any limit set for objects, but not sure we can impose a cap because of the corner case when there are mosty empty shards - we don\u0027t know for sure that 10000 shards will get us at least 10000 objects. So if we do this we also need the proxy to be capable of returning for more to fulfil a listing.\n\nBut (for same reason) we should pop limit (i.e. be unlimited) when getting shard ranges, for now.","commit_id":"aec987b39e615d203e96f1d537aac2b860d3ed53"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"69b3f4df50287174d19a0004ca5be57cd1a0f31f","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                                                              SHARDED):"},{"line_number":590,"context_line":"            record_type \u003d \u0027shard\u0027"},{"line_number":591,"context_line":"            # reset limit -- that was intended for objects"},{"line_number":592,"context_line":"            limit \u003d constraints.CONTAINER_LISTING_LIMIT"},{"line_number":593,"context_line":"        if record_type \u003d\u003d \u0027shard\u0027:"},{"line_number":594,"context_line":"            resp_headers \u003d gen_resp_headers(info)"},{"line_number":595,"context_line":"            override_deleted \u003d config_true_value("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_c4ce0459","line":592,"range":{"start_line":592,"start_character":12,"end_line":592,"end_character":55},"in_reply_to":"9f6a8fd7_44343493","updated":"2018-04-24 08:02:48.000000000","message":"...except its not passed to get_shard_ranges so currently no need to pop.","commit_id":"aec987b39e615d203e96f1d537aac2b860d3ed53"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"14190c9735dd201b8f3c29489c1230aa697741bd","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                                                              SHARDED):"},{"line_number":590,"context_line":"            record_type \u003d \u0027shard\u0027"},{"line_number":591,"context_line":"            # reset limit -- that was intended for objects"},{"line_number":592,"context_line":"            limit \u003d constraints.CONTAINER_LISTING_LIMIT"},{"line_number":593,"context_line":"        if record_type \u003d\u003d \u0027shard\u0027:"},{"line_number":594,"context_line":"            resp_headers \u003d gen_resp_headers(info)"},{"line_number":595,"context_line":"            override_deleted \u003d config_true_value("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_ea298036","line":592,"range":{"start_line":592,"start_character":12,"end_line":592,"end_character":55},"in_reply_to":"9f6a8fd7_c4ce0459","updated":"2018-04-24 20:55:04.000000000","message":"\u003e the corner case when there are mosty empty shards - we don\u0027t know for sure that 10000 shards will get us at least 10000 objects\n\nThat isn\u0027t the only way to have 10k shards not be able to provide 10k objects :-(\n\nDelimiter queries still worry me. A lot.","commit_id":"aec987b39e615d203e96f1d537aac2b860d3ed53"}]}