)]}'
{"swift/container/sharder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"38526938afc8a7440315065725d15fcb2ec747c8","unresolved":false,"context_lines":[{"line_number":1427,"context_line":"                    \u0027Unhandled exception while processing %s: %s\u0027, path, error)"},{"line_number":1428,"context_line":"            try:"},{"line_number":1429,"context_line":"                self._record_sharding_progress(broker, node, error)"},{"line_number":1430,"context_line":"            except Exception as error:"},{"line_number":1431,"context_line":"                self.logger.exception("},{"line_number":1432,"context_line":"                    \u0027Unhandled exception while dumping progress for %s: %s\u0027,"},{"line_number":1433,"context_line":"                    path, error)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_7001e437","line":1430,"range":{"start_line":1430,"start_character":12,"end_line":1430,"end_character":38},"updated":"2018-04-24 17:53:05.000000000","message":"The only reason I can monitor *any* progress right now is that *one* of my nodes hits a LockTimeout that should have been caught here. It breaks out of the whole shard cycle *without* dumping the already-cleared stats to recon.","commit_id":"c36844b6b68b0f11208e4e86dd4f2d77ecb9b4cc"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"49931de14294d3e879baa390c38167a4539d7806","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        )"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        now \u003d time.time()"},{"line_number":331,"context_line":"        last_report \u003d time.ctime(self.reported)"},{"line_number":332,"context_line":"        elapsed \u003d now - self.stats[\u0027start\u0027]"},{"line_number":333,"context_line":"        sharding_stats \u003d self.stats[\u0027sharding\u0027]"},{"line_number":334,"context_line":"        for category, keys in category_keys:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_05c85a71","side":"PARENT","line":331,"range":{"start_line":331,"start_character":33,"end_line":331,"end_character":46},"updated":"2018-04-25 11:05:00.000000000","message":"if stats are not zero\u0027d each time they are reported then this should be the start time","commit_id":"2bc60b649bb2bc2883e6a361be1200094cae1678"}],"test/unit/container/test_sharder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"38526938afc8a7440315065725d15fcb2ec747c8","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"            def check_logs(cycle_time, expect_periodic_stats\u003dFalse):"},{"line_number":335,"context_line":"                self.assertIn(\u0027Container sharder cycle starting\u0027, lines.pop(0))"},{"line_number":336,"context_line":"                check_categories()"},{"line_number":337,"context_line":"                if expect_periodic_stats:"},{"line_number":338,"context_line":"                    check_categories()"},{"line_number":339,"context_line":"                self.assertIn(\u0027Container sharder cycle completed: %.02fs\u0027 %"},{"line_number":340,"context_line":"                              cycle_time, lines.pop(0))"},{"line_number":341,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_d065501f","line":338,"range":{"start_line":336,"start_character":16,"end_line":338,"end_character":38},"updated":"2018-04-24 17:53:05.000000000","message":"We use the same fake_stats for both of these? That seems... weird...","commit_id":"c36844b6b68b0f11208e4e86dd4f2d77ecb9b4cc"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"38526938afc8a7440315065725d15fcb2ec747c8","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                        sum(fake_periods[:3]), fake_stats)"},{"line_number":365,"context_line":"            # periodic stats report during second cycle"},{"line_number":366,"context_line":"            fake_stats.update({\u0027visited\u0027: {\u0027attempted\u0027: 2, \u0027skipped\u0027: 0,"},{"line_number":367,"context_line":"                                           \u0027success\u0027: 2, \u0027failure\u0027: 0,"},{"line_number":368,"context_line":"                                           \u0027completed\u0027: 0}})"},{"line_number":369,"context_line":"            check_recon(recon_data[1], fake_periods[3],"},{"line_number":370,"context_line":"                        sum(fake_periods[:4]), fake_stats)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_90b6f889","line":367,"updated":"2018-04-24 17:53:05.000000000","message":"I *guess* this is right? Honestly, I\u0027m not entirely sure yet -- but test seems to pass.","commit_id":"c36844b6b68b0f11208e4e86dd4f2d77ecb9b4cc"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"49931de14294d3e879baa390c38167a4539d7806","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            check_recon(recon_data[0], sum(fake_periods[1:3]),"},{"line_number":364,"context_line":"                        sum(fake_periods[:3]), fake_stats)"},{"line_number":365,"context_line":"            # periodic stats report during second cycle"},{"line_number":366,"context_line":"            fake_stats.update({\u0027visited\u0027: {\u0027attempted\u0027: 2, \u0027skipped\u0027: 0,"},{"line_number":367,"context_line":"                                           \u0027success\u0027: 2, \u0027failure\u0027: 0,"},{"line_number":368,"context_line":"                                           \u0027completed\u0027: 0}})"},{"line_number":369,"context_line":"            check_recon(recon_data[1], fake_periods[3],"},{"line_number":370,"context_line":"                        sum(fake_periods[:4]), fake_stats)"},{"line_number":371,"context_line":"            # stats report at end of second cycle"},{"line_number":372,"context_line":"            check_recon(recon_data[2], sum(fake_periods[3:5]),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_85a9ca90","line":369,"range":{"start_line":366,"start_character":0,"end_line":369,"end_character":1},"updated":"2018-04-25 11:05:00.000000000","message":"attempted and success should be 1 - turns out there is a bug in the test, the stashed stats are mutable so get updated before the assertions aer made :(","commit_id":"30996a1a31fbf6483319a9a2d4dea9a7e720a7d7"}]}
