)]}'
{"id":"openstack%2Fswift~565872","triplet_id":"openstack%2Fswift~master~I9716f6c4e45bcdf80543cf661f922da681d602aa","project":"openstack/swift","branch":"master","topic":"s3api/update","hashtags":[],"change_id":"I9716f6c4e45bcdf80543cf661f922da681d602aa","subject":"s3api: simplify BaseAclHandler.request_with","status":"MERGED","created":"2018-05-02 19:04:41.000000000","updated":"2018-05-22 16:28:42.000000000","submitted":"2018-05-22 16:28:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"565872-1527006522340-8a7f1701","meta_rev_id":"cba83798a56eaf20076715d77ac10527de44136c","_number":565872,"virtual_id_number":565872,"owner":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2018-05-22 16:28:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-05-02 20:23:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":2,"date":"2018-05-22 14:54:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":1,"date":"2018-05-22 14:54:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-05-02 20:23:12.000000000","updated_by":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"reviewer":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"state":"REVIEWER"},{"updated":"2018-05-22 14:54:49.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"},{"updated":"2018-05-22 16:28:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1fc22506406a8976bf811093cddf8e62d03f28e9","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2018-05-02 19:04:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"31f57c45d5400553c8d585d796197d362a1251fd","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2018-05-02 20:23:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ef3cbb3ba84211a40fa282267ae2e12db200fc62","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-02 22:49:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/72/565872/1/check/build-openstack-sphinx-docs/90a34a8/html/ : SUCCESS in 7m 00s\n- openstack-tox-pep8 http://logs.openstack.org/72/565872/1/check/openstack-tox-pep8/7e4ffc2/ : SUCCESS in 4m 48s\n- legacy-swift-dsvm-functional http://logs.openstack.org/72/565872/1/check/legacy-swift-dsvm-functional/509fe4d/ : SUCCESS in 27m 45s\n- legacy-swift-dsvm-functional-identity-v3-only http://logs.openstack.org/72/565872/1/check/legacy-swift-dsvm-functional-identity-v3-only/c83514c/ : SUCCESS in 27m 33s (non-voting)\n- legacy-tempest-dsvm-neutron-full http://logs.openstack.org/72/565872/1/check/legacy-tempest-dsvm-neutron-full/2394466/ : SUCCESS in 1h 25m 02s\n- neutron-grenade http://logs.openstack.org/72/565872/1/check/neutron-grenade/3c18555/ : SUCCESS in 50m 37s\n- swift-tox-py27 http://logs.openstack.org/72/565872/1/check/swift-tox-py27/68b57ab/ : SUCCESS in 8m 15s\n- swift-tox-py35 http://logs.openstack.org/72/565872/1/check/swift-tox-py35/eddef90/ : SUCCESS in 5m 03s\n- swift-tox-func http://logs.openstack.org/72/565872/1/check/swift-tox-func/708b0d2/ : SUCCESS in 8m 19s\n- swift-tox-func-encryption http://logs.openstack.org/72/565872/1/check/swift-tox-func-encryption/7499aee/ : SUCCESS in 7m 41s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/72/565872/1/check/swift-tox-func-domain-remap-staticweb/4526d5f/ : SUCCESS in 8m 44s\n- swift-tox-func-ec http://logs.openstack.org/72/565872/1/check/swift-tox-func-ec/71a987b/ : SUCCESS in 9m 16s\n- swift-tox-func-s3api http://logs.openstack.org/72/565872/1/check/swift-tox-func-s3api/d4898c6/ : SUCCESS in 8m 45s\n- swift-probetests-centos-7 http://logs.openstack.org/72/565872/1/check/swift-probetests-centos-7/93ad79b/ : SUCCESS in 17m 20s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2285ee89e2829bd268031f6540b184a24d5da47f","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2018-05-22 14:54:49.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nMakes sense. Current unnecessary context manager appears to be a hangover from commit 04ee763e897152d0d75ad33eca46899b51a974bc - previously the context manager did modify state during entry and exit.","accounts_in_message":[],"_revision_number":1},{"id":"b8a496a1be0d2bf622120475daa9e5ac116ea86d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-22 14:55:05.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"55ed186477778ff0e2828167eeb2951bb801d68c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-22 16:28:42.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/72/565872/1/gate/build-openstack-sphinx-docs/8a04154/html/ : SUCCESS in 4m 52s\n- openstack-tox-pep8 http://logs.openstack.org/72/565872/1/gate/openstack-tox-pep8/d833bee/ : SUCCESS in 4m 11s\n- legacy-swift-dsvm-functional http://logs.openstack.org/72/565872/1/gate/legacy-swift-dsvm-functional/14bb4ea/ : SUCCESS in 23m 16s\n- legacy-tempest-dsvm-neutron-full http://logs.openstack.org/72/565872/1/gate/legacy-tempest-dsvm-neutron-full/773c25e/ : SUCCESS in 1h 30m 50s\n- neutron-grenade http://logs.openstack.org/72/565872/1/gate/neutron-grenade/aed44f3/ : SUCCESS in 44m 57s\n- swift-tox-py27 http://logs.openstack.org/72/565872/1/gate/swift-tox-py27/f49c8d8/ : SUCCESS in 9m 37s\n- swift-tox-py35 http://logs.openstack.org/72/565872/1/gate/swift-tox-py35/b087445/ : SUCCESS in 3m 48s\n- swift-tox-func http://logs.openstack.org/72/565872/1/gate/swift-tox-func/263cdca/ : SUCCESS in 8m 11s\n- swift-tox-func-encryption http://logs.openstack.org/72/565872/1/gate/swift-tox-func-encryption/82334ac/ : SUCCESS in 8m 03s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/72/565872/1/gate/swift-tox-func-domain-remap-staticweb/d269014/ : SUCCESS in 7m 40s\n- swift-tox-func-ec http://logs.openstack.org/72/565872/1/gate/swift-tox-func-ec/5242b45/ : SUCCESS in 8m 28s\n- swift-tox-func-s3api http://logs.openstack.org/72/565872/1/gate/swift-tox-func-s3api/31f712c/ : SUCCESS in 9m 33s","accounts_in_message":[],"_revision_number":1},{"id":"e1755bd15c4da68a23e741e1f8cef3f05615d5e7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-22 16:28:42.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0d0c9b91ed278f964f686359f50748a4bee0fc25","revisions":{"0d0c9b91ed278f964f686359f50748a4bee0fc25":{"kind":"REWORK","_number":1,"created":"2018-05-02 19:04:41.000000000","uploader":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"ref":"refs/changes/72/565872/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/72/565872/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/72/565872/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/72/565872/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/72/565872/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/72/565872/1"}}},"commit":{"parents":[{"commit":"04ee763e897152d0d75ad33eca46899b51a974bc","subject":"Simplify the code in s3api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/04ee763e897152d0d75ad33eca46899b51a974bc"}]}],"author":{"name":"Samuel Merritt","email":"sam@swiftstack.com","date":"2018-05-02 18:58:30.000000000","tz":-420},"committer":{"name":"Samuel Merritt","email":"sam@swiftstack.com","date":"2018-05-02 18:58:30.000000000","tz":-420},"subject":"s3api: simplify BaseAclHandler.request_with","message":"s3api: simplify BaseAclHandler.request_with\n\nIt\u0027s just constructing a new object; there\u0027s no need for it to be a\ncontext manager.\n\nChange-Id: I9716f6c4e45bcdf80543cf661f922da681d602aa\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/0d0c9b91ed278f964f686359f50748a4bee0fc25"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/0d0c9b91ed278f964f686359f50748a4bee0fc25"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"04ee763e897152d0d75ad33eca46899b51a974bc","is_merged_in_target_branch":true,"change_id":"Id4bfbaf971e3a08fdf9d0ef8d7373bb36c298682","change_number":565383,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}