)]}'
{"swift/common/middleware/tempauth.py":[{"author":{"_account_id":26690,"name":"HCLTech-SSW","email":"hcl_ss_oss@hcl.com","username":"hcltech-ssw"},"change_message_id":"c03311335d4a17c6be3764588b4085102a03ace3","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        req.start_time \u003d time()"},{"line_number":679,"context_line":"        handler \u003d None"},{"line_number":680,"context_line":"        try:"},{"line_number":681,"context_line":"            version, account, user, _junk \u003d split_path(req.path_info,"},{"line_number":682,"context_line":"                                                       1, 4, True)"},{"line_number":683,"context_line":"        except ValueError:"},{"line_number":684,"context_line":"            self.logger.increment(\u0027errors\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a8ec438f","line":681,"range":{"start_line":681,"start_character":44,"end_line":681,"end_character":54},"updated":"2018-05-10 05:13:26.000000000","message":"As per our thought for handling the HTTP Request methods like as GET is already handled on line number 690, then other cases best to handle there only (rather than introducing new code block before the already implemented handling).","commit_id":"09492d9f556c20c5c19d89dcbc3634e920082b60"},{"author":{"_account_id":26690,"name":"HCLTech-SSW","email":"hcl_ss_oss@hcl.com","username":"hcltech-ssw"},"change_message_id":"c87d6a08ff0978f6ab556780743822d04e3e755b","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        req.start_time \u003d time()"},{"line_number":679,"context_line":"        handler \u003d None"},{"line_number":680,"context_line":"        try:"},{"line_number":681,"context_line":"            version, account, user, _junk \u003d split_path(req.path_info,"},{"line_number":682,"context_line":"                                                       1, 4, True)"},{"line_number":683,"context_line":"        except ValueError:"},{"line_number":684,"context_line":"            self.logger.increment(\u0027errors\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d6048b1a","line":681,"range":{"start_line":681,"start_character":44,"end_line":681,"end_character":54},"in_reply_to":"5f7c97a3_a8ec438f","updated":"2018-05-14 07:45:07.000000000","message":"Done","commit_id":"09492d9f556c20c5c19d89dcbc3634e920082b60"},{"author":{"_account_id":13331,"name":"Filippo Giunchedi","email":"fgiunchedi@wikimedia.org","username":"fgiunchedi"},"change_message_id":"85ebad9bc604dcfceb1f7be8fe88648b78470d11","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        req.start_time \u003d time()"},{"line_number":679,"context_line":"        handler \u003d None"},{"line_number":680,"context_line":"        try:"},{"line_number":681,"context_line":"            version, account, user, _junk \u003d split_path(req.path_info,"},{"line_number":682,"context_line":"                                                       1, 4, True)"},{"line_number":683,"context_line":"        except ValueError:"},{"line_number":684,"context_line":"            self.logger.increment(\u0027errors\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_75bd8d00","line":681,"range":{"start_line":681,"start_character":44,"end_line":681,"end_character":54},"in_reply_to":"5f7c97a3_a8ec438f","updated":"2018-05-11 07:56:03.000000000","message":"I\u0027m assuming this is a reply to my comment on line 686 (?). I personally like to fail early, in this case we know requests that aren\u0027t GET are not going to work, thus it makes sense to reject them ASAP, before any validation.","commit_id":"09492d9f556c20c5c19d89dcbc3634e920082b60"},{"author":{"_account_id":13331,"name":"Filippo Giunchedi","email":"fgiunchedi@wikimedia.org","username":"fgiunchedi"},"change_message_id":"4c7846595e3f938b0997e5ef97bae25955bcd59a","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        except ValueError:"},{"line_number":684,"context_line":"            self.logger.increment(\u0027errors\u0027)"},{"line_number":685,"context_line":"            return HTTPNotFound(request\u003dreq)"},{"line_number":686,"context_line":"        if req.method !\u003d \u0027GET\u0027:"},{"line_number":687,"context_line":"            req.response \u003d HTTPMethodNotAllowed(request\u003dreq)"},{"line_number":688,"context_line":"            return req.response"},{"line_number":689,"context_line":"        if version in (\u0027v1\u0027, \u0027v1.0\u0027, \u0027auth\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0d824050","line":686,"updated":"2018-05-09 10:21:14.000000000","message":"This guard can be effective even before the split_path and return HTTPMethodNotAllowed directly, without req.response assignment","commit_id":"09492d9f556c20c5c19d89dcbc3634e920082b60"},{"author":{"_account_id":13331,"name":"Filippo Giunchedi","email":"fgiunchedi@wikimedia.org","username":"fgiunchedi"},"change_message_id":"159c5945be27652ae135008fad4f83e2c973a751","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        req.start_time \u003d time()"},{"line_number":679,"context_line":"        handler \u003d None"},{"line_number":680,"context_line":"        try:"},{"line_number":681,"context_line":"            if req.method !\u003d \u0027GET\u0027:"},{"line_number":682,"context_line":"                req.response \u003d HTTPMethodNotAllowed(request\u003dreq)"},{"line_number":683,"context_line":"                return req.response"},{"line_number":684,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a51aefc8","line":681,"updated":"2018-05-14 11:15:06.000000000","message":"AFAICS this guard should live one line above, outside the try/catch, there\u0027s no ValueError to be thrown.","commit_id":"9f76b917877470bf3135c9c3cf2671a64d5482e0"},{"author":{"_account_id":26690,"name":"HCLTech-SSW","email":"hcl_ss_oss@hcl.com","username":"hcltech-ssw"},"change_message_id":"8e8fb45c85dd26eac5d896c0389cb2c9c847826d","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        req.start_time \u003d time()"},{"line_number":679,"context_line":"        handler \u003d None"},{"line_number":680,"context_line":"        try:"},{"line_number":681,"context_line":"            if req.method !\u003d \u0027GET\u0027:"},{"line_number":682,"context_line":"                req.response \u003d HTTPMethodNotAllowed(request\u003dreq)"},{"line_number":683,"context_line":"                return req.response"},{"line_number":684,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b5a68a0e","line":681,"in_reply_to":"5f7c97a3_a51aefc8","updated":"2018-05-15 06:33:31.000000000","message":"Done","commit_id":"9f76b917877470bf3135c9c3cf2671a64d5482e0"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"75d4f15c61c8d43ac345e569cbdfdc62eaab13e0","unresolved":false,"context_lines":[{"line_number":691,"context_line":"                handler \u003d self.handle_get_token"},{"line_number":692,"context_line":"        if not handler:"},{"line_number":693,"context_line":"            self.logger.increment(\u0027errors\u0027)"},{"line_number":694,"context_line":"            req.response \u003d HTTPBadRequest(request\u003dreq)"},{"line_number":695,"context_line":"        else:"},{"line_number":696,"context_line":"            req.response \u003d handler(req)"},{"line_number":697,"context_line":"        return req.response"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_26448046","line":694,"updated":"2018-05-15 17:55:17.000000000","message":"What was wrong with returning 400?","commit_id":"a563ba26fa3d9dfb23b368ed79940c19e3a9135c"},{"author":{"_account_id":26690,"name":"HCLTech-SSW","email":"hcl_ss_oss@hcl.com","username":"hcltech-ssw"},"change_message_id":"d9bf33b2a28eb482746f361eb2c8b8bfd0aa793b","unresolved":false,"context_lines":[{"line_number":691,"context_line":"                handler \u003d self.handle_get_token"},{"line_number":692,"context_line":"        if not handler:"},{"line_number":693,"context_line":"            self.logger.increment(\u0027errors\u0027)"},{"line_number":694,"context_line":"            req.response \u003d HTTPBadRequest(request\u003dreq)"},{"line_number":695,"context_line":"        else:"},{"line_number":696,"context_line":"            req.response \u003d handler(req)"},{"line_number":697,"context_line":"        return req.response"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ffd285ff","line":694,"in_reply_to":"5f7c97a3_26448046","updated":"2018-05-16 05:28:35.000000000","message":"The HTTP code 400 signifies HTTP BadRequest which signifies that the path which is going to be accessed is Malformed or Invalid Request.\n\nFor this case if we would try to execute the below command\n\ncurl -v -X PUT -H \u0027X-Storage-User: \u003cadmin:admin\u003e\u0027 -H \u0027X-Storage-Pass: \u003cadmin\u003e\u0027 http://\u003cip address\u003e:8080/auth/v1.0\n\ncurl -v -X HEAD -H \u0027X-Storage-User: \u003cadmin:admin\u003e\u0027 -H \u0027X-Storage-Pass: \u003cadmin\u003e\u0027 http://\u003cip address\u003e:8080/auth/v1.0\n\ncurl -v -X POST -H \u0027X-Storage-User: \u003cadmin:admin\u003e\u0027 -H \u0027X-Storage-Pass: \u003cadmin\u003e\u0027 http://\u003cip address\u003e:8080/auth/v1.0\n\ncurl -v -X DELETE -H \u0027X-Storage-User: \u003cadmin:admin\u003e\u0027 -H \u0027X-Storage-Pass: \u003cadmin\u003e\u0027 http://\u003cip address\u003e:8080/auth/v1.0\n\nThe system will throw HTTP 400 which is not meaningful and logically correct.\n\nThe HTTP Code 405 signifies HTTP MethodNotAllowed which signifies a request method is not supported for the requested resource.\n\nTo make HTTP operations consistent with the HTTP Standard codes we have handled 405 here for the above cases.","commit_id":"a563ba26fa3d9dfb23b368ed79940c19e3a9135c"}],"test/unit/common/middleware/test_tempauth.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"75d4f15c61c8d43ac345e569cbdfdc62eaab13e0","unresolved":false,"context_lines":[{"line_number":975,"context_line":"            headers\u003d{\u0027X-Auth-User\u0027: \u0027ac:user\u0027, \u0027X-Auth-Key\u0027: \u0027testing\u0027},"},{"line_number":976,"context_line":"            environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027DELETE\u0027})"},{"line_number":977,"context_line":"        resp \u003d req.get_response(test_auth)"},{"line_number":978,"context_line":"        self.assertEqual(resp.status_int, 405)"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"class TestAuthWithMultiplePrefixes(TestAuth):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_867c7472","line":978,"updated":"2018-05-15 17:55:17.000000000","message":"The test here looks good, to document existing behavior - less sure about the need/value of changning the current stable API version behavior without an API version revision?\n\n    diff --git a/test/unit/common/middleware/test_tempauth.py b/test/unit/common/middleware/test_tempauth.py\n    index 765e461..82df2c6 100644\n    --- a/test/unit/common/middleware/test_tempauth.py\n    +++ b/test/unit/common/middleware/test_tempauth.py\n    @@ -954,28 +954,28 @@ class TestAuth(unittest.TestCase):\n                 headers\u003d{\u0027X-Auth-User\u0027: \u0027ac:user\u0027, \u0027X-Auth-Key\u0027: \u0027testing\u0027},\n                 environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027PUT\u0027})\n             resp \u003d req.get_response(test_auth)\n    -        self.assertEqual(resp.status_int, 405)\n    +        self.assertEqual(resp.status_int, 400)\n     \n             req \u003d self._make_request(\n                 \u0027/auth/v1.0\u0027,\n                 headers\u003d{\u0027X-Auth-User\u0027: \u0027ac:user\u0027, \u0027X-Auth-Key\u0027: \u0027testing\u0027},\n                 environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027HEAD\u0027})\n             resp \u003d req.get_response(test_auth)\n    -        self.assertEqual(resp.status_int, 405)\n    +        self.assertEqual(resp.status_int, 400)\n     \n             req \u003d self._make_request(\n                 \u0027/auth/v1.0\u0027,\n                 headers\u003d{\u0027X-Auth-User\u0027: \u0027ac:user\u0027, \u0027X-Auth-Key\u0027: \u0027testing\u0027},\n                 environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027POST\u0027})\n             resp \u003d req.get_response(test_auth)\n    -        self.assertEqual(resp.status_int, 405)\n    +        self.assertEqual(resp.status_int, 400)\n     \n             req \u003d self._make_request(\n                 \u0027/auth/v1.0\u0027,\n                 headers\u003d{\u0027X-Auth-User\u0027: \u0027ac:user\u0027, \u0027X-Auth-Key\u0027: \u0027testing\u0027},\n                 environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027DELETE\u0027})\n             resp \u003d req.get_response(test_auth)\n    -        self.assertEqual(resp.status_int, 405)\n    +        self.assertEqual(resp.status_int, 400)\n     \n     \n     class TestAuthWithMultiplePrefixes(TestAuth):","commit_id":"a563ba26fa3d9dfb23b368ed79940c19e3a9135c"},{"author":{"_account_id":26690,"name":"HCLTech-SSW","email":"hcl_ss_oss@hcl.com","username":"hcltech-ssw"},"change_message_id":"d9bf33b2a28eb482746f361eb2c8b8bfd0aa793b","unresolved":false,"context_lines":[{"line_number":975,"context_line":"            headers\u003d{\u0027X-Auth-User\u0027: \u0027ac:user\u0027, \u0027X-Auth-Key\u0027: \u0027testing\u0027},"},{"line_number":976,"context_line":"            environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027DELETE\u0027})"},{"line_number":977,"context_line":"        resp \u003d req.get_response(test_auth)"},{"line_number":978,"context_line":"        self.assertEqual(resp.status_int, 405)"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"class TestAuthWithMultiplePrefixes(TestAuth):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_5f013969","line":978,"in_reply_to":"5f7c97a3_867c7472","updated":"2018-05-16 05:28:35.000000000","message":"This test case we have added to test the HTTP code 405 cases.","commit_id":"a563ba26fa3d9dfb23b368ed79940c19e3a9135c"}]}
