)]}'
{"swift/container/sharder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"fa1eed8499fd32dcfbb5098a370b0702ba9c4a31","unresolved":false,"context_lines":[{"line_number":341,"context_line":"            self.shard_replication_quorum \u003d replica_count"},{"line_number":342,"context_line":"        self.existing_shard_replication_quorum \u003d config_auto_int_value("},{"line_number":343,"context_line":"            conf.get(\u0027existing_shard_replication_quorum\u0027),"},{"line_number":344,"context_line":"            self.shard_replication_quorum)"},{"line_number":345,"context_line":"        if self.existing_shard_replication_quorum \u003e replica_count:"},{"line_number":346,"context_line":"            self.logger.warning("},{"line_number":347,"context_line":"                \u0027existing_shard_replication_quorum of %s exceeds replica count\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_be5c8b7e","line":344,"updated":"2018-05-09 20:17:51.000000000","message":"nice","commit_id":"92704625a3b42c64fd3dcfff71895a955b283431"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"fa1eed8499fd32dcfbb5098a370b0702ba9c4a31","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                \u0027existing_shard_replication_quorum of %s exceeds replica count\u0027"},{"line_number":348,"context_line":"                \u0027 %s, reducing to %s\u0027, self.existing_shard_replication_quorum,"},{"line_number":349,"context_line":"                replica_count, replica_count)"},{"line_number":350,"context_line":"            self.existing_shard_replication_quorum \u003d replica_count"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        # internal client"},{"line_number":353,"context_line":"        self.conn_timeout \u003d float(conf.get(\u0027conn_timeout\u0027, 5))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_7e56f35e","line":350,"updated":"2018-05-09 20:17:51.000000000","message":"I like the warnings!","commit_id":"92704625a3b42c64fd3dcfff71895a955b283431"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6912068d9b0464cb3be0a62b66ac189598ce4f6a","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"            shard_broker.merge_shard_ranges(shard_range)"},{"line_number":1172,"context_line":"            replication_quorum \u003d self.shard_replication_quorum"},{"line_number":1173,"context_line":"        else:"},{"line_number":1174,"context_line":"            replication_quorum \u003d self.existing_shard_replication_quorum"},{"line_number":1175,"context_line":""},{"line_number":1176,"context_line":"        self.logger.info("},{"line_number":1177,"context_line":"            \u0027Replicating new shard container %s for %s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_389f2e60","line":1174,"updated":"2018-05-09 20:19:34.000000000","message":"when you squash, maybe this?\n\n    diff --git a/swift/container/sharder.py b/swift/container/sharder.py\n    index 0bdb4fc..a3f11f4 100644\n    --- a/swift/container/sharder.py\n    +++ b/swift/container/sharder.py\n    @@ -1148,6 +1148,7 @@ class ContainerSharder(ContainerReplicator):\n     \n             own_shard_range \u003d broker.get_own_shard_range()\n     \n    +        replication_quorum \u003d self.existing_shard_replication_quorum\n             if shard_range.includes(own_shard_range):\n                 # When shrinking, include deleted own (donor) shard range in\n                 # the replicated db so that when acceptor next updates root it\n    @@ -1158,7 +1159,6 @@ class ContainerSharder(ContainerReplicator):\n                     own_shard_range.set_deleted()\n                     broker.merge_shard_ranges(own_shard_range)\n                 shard_broker.merge_shard_ranges(own_shard_range)\n    -            replication_quorum \u003d self.existing_shard_replication_quorum\n             elif shard_range.state \u003d\u003d ShardRange.CREATED:\n                 # The shard range object stats may have changed since the shard\n                 # range was found, so update with stats of objects actually\n    @@ -1170,8 +1170,6 @@ class ContainerSharder(ContainerReplicator):\n                 shard_range.update_state(ShardRange.CLEAVED)\n                 shard_broker.merge_shard_ranges(shard_range)\n                 replication_quorum \u003d self.shard_replication_quorum\n    -        else:\n    -            replication_quorum \u003d self.existing_shard_replication_quorum\n     \n             self.logger.info(\n                 \u0027Replicating new shard container %s for %s\u0027,","commit_id":"92704625a3b42c64fd3dcfff71895a955b283431"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"da4e6294664511eeff9b8e139e6a162fe97a0ea5","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"            shard_broker.merge_shard_ranges(shard_range)"},{"line_number":1172,"context_line":"            replication_quorum \u003d self.shard_replication_quorum"},{"line_number":1173,"context_line":"        else:"},{"line_number":1174,"context_line":"            replication_quorum \u003d self.existing_shard_replication_quorum"},{"line_number":1175,"context_line":""},{"line_number":1176,"context_line":"        self.logger.info("},{"line_number":1177,"context_line":"            \u0027Replicating new shard container %s for %s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_9bd67cc3","line":1174,"in_reply_to":"5f7c97a3_389f2e60","updated":"2018-05-09 21:30:12.000000000","message":"hehe, I wrote it that way first, but I\u0027m not sure if others are happy with the \u0027set default value then conditionally set if differently\u0027 pattern so backed off. #willfix","commit_id":"92704625a3b42c64fd3dcfff71895a955b283431"}]}
