)]}'
{"test/unit/common/test_utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"639e37262cf8953b4f07944ee9d10bf373112caf","unresolved":false,"context_lines":[{"line_number":3907,"context_line":"        # overlapping parent in the list of ranges"},{"line_number":3908,"context_line":"        ftoh \u003d utils.ShardRange(\u0027a/f-h\u0027, ts, \u0027f\u0027, \u0027h\u0027)"},{"line_number":3909,"context_line":"        htok \u003d utils.ShardRange(\u0027a/h-k\u0027, ts, \u0027h\u0027, \u0027k\u0027)"},{"line_number":3910,"context_line":"        ktol \u003d utils.ShardRange(\u0027a/k-l\u0027, ts, \u0027k\u0027, \u0027l\u0027)"},{"line_number":3911,"context_line":""},{"line_number":3912,"context_line":"        ranges \u003d ranges[:2] + [ftoh, htok, ktol] + ranges[2:]"},{"line_number":3913,"context_line":"        found \u003d utils.find_shard_range(\u0027g\u0027, ranges)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_46241c5e","line":3910,"updated":"2018-05-15 18:42:02.000000000","message":"Might be more interesting without this one, to see that \u0027l\u0027 still goes to ftol (where it\u0027ll be a misplaced object).","commit_id":"47d1666a012c00eeb5bc0dff66f9da728213c4cf"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"306222cd1740d168bc2fc5c3a94a60632e8acbda","unresolved":false,"context_lines":[{"line_number":3907,"context_line":"        # overlapping parent in the list of ranges"},{"line_number":3908,"context_line":"        ftoh \u003d utils.ShardRange(\u0027a/f-h\u0027, ts, \u0027f\u0027, \u0027h\u0027)"},{"line_number":3909,"context_line":"        htok \u003d utils.ShardRange(\u0027a/h-k\u0027, ts, \u0027h\u0027, \u0027k\u0027)"},{"line_number":3910,"context_line":"        ktol \u003d utils.ShardRange(\u0027a/k-l\u0027, ts, \u0027k\u0027, \u0027l\u0027)"},{"line_number":3911,"context_line":""},{"line_number":3912,"context_line":"        ranges \u003d ranges[:2] + [ftoh, htok, ktol] + ranges[2:]"},{"line_number":3913,"context_line":"        found \u003d utils.find_shard_range(\u0027g\u0027, ranges)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_6d81d04a","line":3910,"in_reply_to":"5f7c97a3_46241c5e","updated":"2018-05-17 09:06:56.000000000","message":"Done","commit_id":"47d1666a012c00eeb5bc0dff66f9da728213c4cf"}],"test/unit/container/test_backend.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"639e37262cf8953b4f07944ee9d10bf373112caf","unresolved":false,"context_lines":[{"line_number":3599,"context_line":"        ]"},{"line_number":3600,"context_line":"        broker.merge_shard_ranges("},{"line_number":3601,"context_line":"            random.sample(shard_ranges, len(shard_ranges)))"},{"line_number":3602,"context_line":"        actual \u003d broker.get_shard_ranges()"},{"line_number":3603,"context_line":"        self.assertEqual([dict(sr) for sr in shard_ranges],"},{"line_number":3604,"context_line":"                         [dict(sr) for sr in actual])"},{"line_number":3605,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c6302ca2","line":3602,"updated":"2018-05-15 18:42:02.000000000","message":"Should this have states\u003dSHARD_LISTING_STATES?","commit_id":"47d1666a012c00eeb5bc0dff66f9da728213c4cf"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"306222cd1740d168bc2fc5c3a94a60632e8acbda","unresolved":false,"context_lines":[{"line_number":3599,"context_line":"        ]"},{"line_number":3600,"context_line":"        broker.merge_shard_ranges("},{"line_number":3601,"context_line":"            random.sample(shard_ranges, len(shard_ranges)))"},{"line_number":3602,"context_line":"        actual \u003d broker.get_shard_ranges()"},{"line_number":3603,"context_line":"        self.assertEqual([dict(sr) for sr in shard_ranges],"},{"line_number":3604,"context_line":"                         [dict(sr) for sr in actual])"},{"line_number":3605,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2d519863","line":3602,"in_reply_to":"5f7c97a3_c6302ca2","updated":"2018-05-17 09:06:56.000000000","message":"I think I prefer this assertion without the states restriction since the goal is to assert the order","commit_id":"47d1666a012c00eeb5bc0dff66f9da728213c4cf"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"639e37262cf8953b4f07944ee9d10bf373112caf","unresolved":false,"context_lines":[{"line_number":3603,"context_line":"        self.assertEqual([dict(sr) for sr in shard_ranges],"},{"line_number":3604,"context_line":"                         [dict(sr) for sr in actual])"},{"line_number":3605,"context_line":""},{"line_number":3606,"context_line":"        actual \u003d broker.get_shard_ranges(states\u003dSHARD_UPDATE_STATES,"},{"line_number":3607,"context_line":"                                         includes\u003d\u0027l\u0027)"},{"line_number":3608,"context_line":"        self.assertEqual([shard_ranges[2]], actual)"},{"line_number":3609,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_46fbbcbf","line":3606,"range":{"start_line":3606,"start_character":41,"end_line":3606,"end_character":47},"updated":"2018-05-15 18:42:02.000000000","message":"Why pass states here but not in the new assertions in test_get_shard_ranges_with_sharding_overlaps?","commit_id":"47d1666a012c00eeb5bc0dff66f9da728213c4cf"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"306222cd1740d168bc2fc5c3a94a60632e8acbda","unresolved":false,"context_lines":[{"line_number":3603,"context_line":"        self.assertEqual([dict(sr) for sr in shard_ranges],"},{"line_number":3604,"context_line":"                         [dict(sr) for sr in actual])"},{"line_number":3605,"context_line":""},{"line_number":3606,"context_line":"        actual \u003d broker.get_shard_ranges(states\u003dSHARD_UPDATE_STATES,"},{"line_number":3607,"context_line":"                                         includes\u003d\u0027l\u0027)"},{"line_number":3608,"context_line":"        self.assertEqual([shard_ranges[2]], actual)"},{"line_number":3609,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_0d261c18","line":3606,"range":{"start_line":3606,"start_character":41,"end_line":3606,"end_character":47},"in_reply_to":"5f7c97a3_46fbbcbf","updated":"2018-05-17 09:06:56.000000000","message":"this was the only place that states was necessary to restrict the returned set. But I\u0027ll add it above so the test hints at realistic use of includes.","commit_id":"47d1666a012c00eeb5bc0dff66f9da728213c4cf"}]}
