)]}'
{"swift/container/replicator.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"91669479befab50710d628de0f41abea3dccf3dc","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                \u0027cleaving\u0027,"},{"line_number":113,"context_line":"                broker.db_file,"},{"line_number":114,"context_line":"                \u0027%(ip)s:%(port)s/%(device)s\u0027 % node,"},{"line_number":115,"context_line":"                len(shard_ranges))"},{"line_number":116,"context_line":"            self.stats[\u0027deferred\u0027] +\u003d 1"},{"line_number":117,"context_line":"            return shard_range_success"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e23401fe","side":"PARENT","line":115,"updated":"2018-05-17 18:59:40.000000000","message":"I kinda liked this when auto-sharding... you get an indication of how far along you are in identifying ranges, and how much work needs to be done before this message goes away.\n\n*shrug*","commit_id":"b7226b9d87ae86cf30c50e617d93a18bb9cfdb5d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"1e956620dad1f77e75caaa88d6e5ce939d6e3ab2","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def cleanup_post_replicate(self, broker, orig_info, responses):"},{"line_number":249,"context_line":"        debug_template \u003d \u0027Not deleting db %s (%%s)\u0027 % broker.db_file"},{"line_number":250,"context_line":"        if broker.sharding_required():"},{"line_number":251,"context_line":"            # despite being a handoff, since we\u0027re sharding we\u0027re not going to"},{"line_number":252,"context_line":"            # do any cleanup so we can continue cleaving - this is still"},{"line_number":253,"context_line":"            # considered \"success\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_826bcdef","line":250,"updated":"2018-05-17 18:55:24.000000000","message":"do we need to postpone cleanup when shrinking as well?","commit_id":"d380f4b27705e53064a27d3dc4e3fa12cc6729f2"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"91669479befab50710d628de0f41abea3dccf3dc","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def cleanup_post_replicate(self, broker, orig_info, responses):"},{"line_number":249,"context_line":"        debug_template \u003d \u0027Not deleting db %s (%%s)\u0027 % broker.db_file"},{"line_number":250,"context_line":"        if broker.sharding_required():"},{"line_number":251,"context_line":"            # despite being a handoff, since we\u0027re sharding we\u0027re not going to"},{"line_number":252,"context_line":"            # do any cleanup so we can continue cleaving - this is still"},{"line_number":253,"context_line":"            # considered \"success\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_650ebb33","line":250,"in_reply_to":"5f7c97a3_826bcdef","updated":"2018-05-17 18:59:40.000000000","message":"We were already doing that -- IIRC the sharder is now in charge of unlinking the DB?","commit_id":"d380f4b27705e53064a27d3dc4e3fa12cc6729f2"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"91669479befab50710d628de0f41abea3dccf3dc","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        # request then abort object replication now; instantiate a fresh broker"},{"line_number":361,"context_line":"        # each time this check if performed so to get latest state"},{"line_number":362,"context_line":"        broker \u003d ContainerBroker(db_file)"},{"line_number":363,"context_line":"        return broker.sharding_initiated()"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    def _post_rsync_then_merge_hook(self, existing_broker, new_broker):"},{"line_number":366,"context_line":"        # Note the following hook will need to change to using a pointer and"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6220f1b1","line":363,"updated":"2018-05-17 18:59:40.000000000","message":"So we no longer look at the db_state?","commit_id":"d380f4b27705e53064a27d3dc4e3fa12cc6729f2"}]}
