)]}'
{"test/unit/container/test_replicator.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b0cd0ed6cb88613e5260a8f3a7fbb5428a5bc27b","unresolved":false,"context_lines":[{"line_number":1383,"context_line":"        success \u003d daemon._repl_to_node(node, broker, part, info)"},{"line_number":1384,"context_line":"        self.assertFalse(success)"},{"line_number":1385,"context_line":"        self.assertEqual("},{"line_number":1386,"context_line":"            [\u0027sync\u0027, \u0027get_shard_ranges\u0027, \u0027merge_shard_ranges\u0027, \u0027merge_items\u0027,"},{"line_number":1387,"context_line":"             \u0027merge_syncs\u0027],"},{"line_number":1388,"context_line":"            [call[0][0] for call in replicate_hook.call_args_list])"},{"line_number":1389,"context_line":"        error_lines \u003d daemon.logger.get_lines_for_level(\u0027error\u0027)"},{"line_number":1390,"context_line":"        self.assertIn(\u0027Bad response 500\u0027, error_lines[0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_aa721748","line":1387,"range":{"start_line":1386,"start_character":63,"end_line":1387,"end_character":26},"updated":"2018-05-22 23:34:16.000000000","message":"So even after hitting a failure in merge_shard_ranges, we try to merge items and syncs? Seems kinda weird...\n\nOh, I guess because we *only* have own_shard_range?","commit_id":"a3d1a7e893c2651513e563d8d41a6e0d20cea362"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"bfcc6367bab14361a9b2bcb02a86f8f9d358b813","unresolved":false,"context_lines":[{"line_number":1383,"context_line":"        success \u003d daemon._repl_to_node(node, broker, part, info)"},{"line_number":1384,"context_line":"        self.assertFalse(success)"},{"line_number":1385,"context_line":"        self.assertEqual("},{"line_number":1386,"context_line":"            [\u0027sync\u0027, \u0027get_shard_ranges\u0027, \u0027merge_shard_ranges\u0027, \u0027merge_items\u0027,"},{"line_number":1387,"context_line":"             \u0027merge_syncs\u0027],"},{"line_number":1388,"context_line":"            [call[0][0] for call in replicate_hook.call_args_list])"},{"line_number":1389,"context_line":"        error_lines \u003d daemon.logger.get_lines_for_level(\u0027error\u0027)"},{"line_number":1390,"context_line":"        self.assertIn(\u0027Bad response 500\u0027, error_lines[0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_eadc8a47","line":1387,"range":{"start_line":1386,"start_character":63,"end_line":1387,"end_character":26},"in_reply_to":"5f7c97a3_aa721748","updated":"2018-05-23 08:57:53.000000000","message":"yes. If there were other shard ranges then the object would not be sent, but that\u0027s well covered in other tests.","commit_id":"a3d1a7e893c2651513e563d8d41a6e0d20cea362"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b0cd0ed6cb88613e5260a8f3a7fbb5428a5bc27b","unresolved":false,"context_lines":[{"line_number":1388,"context_line":"            [call[0][0] for call in replicate_hook.call_args_list])"},{"line_number":1389,"context_line":"        error_lines \u003d daemon.logger.get_lines_for_level(\u0027error\u0027)"},{"line_number":1390,"context_line":"        self.assertIn(\u0027Bad response 500\u0027, error_lines[0])"},{"line_number":1391,"context_line":"        self.assertFalse(error_lines[1:])"},{"line_number":1392,"context_line":""},{"line_number":1393,"context_line":"    def test_sync_shard_ranges_none_to_sync(self):"},{"line_number":1394,"context_line":"        # verify that merge_shard_ranges is not sent if there are no shard"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4ab823c7","line":1391,"updated":"2018-05-22 23:34:16.000000000","message":"Worth making assertions on the logger stats?","commit_id":"a3d1a7e893c2651513e563d8d41a6e0d20cea362"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"bfcc6367bab14361a9b2bcb02a86f8f9d358b813","unresolved":false,"context_lines":[{"line_number":1388,"context_line":"            [call[0][0] for call in replicate_hook.call_args_list])"},{"line_number":1389,"context_line":"        error_lines \u003d daemon.logger.get_lines_for_level(\u0027error\u0027)"},{"line_number":1390,"context_line":"        self.assertIn(\u0027Bad response 500\u0027, error_lines[0])"},{"line_number":1391,"context_line":"        self.assertFalse(error_lines[1:])"},{"line_number":1392,"context_line":""},{"line_number":1393,"context_line":"    def test_sync_shard_ranges_none_to_sync(self):"},{"line_number":1394,"context_line":"        # verify that merge_shard_ranges is not sent if there are no shard"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2ab842c6","line":1391,"in_reply_to":"5f7c97a3_4ab823c7","updated":"2018-05-23 08:57:53.000000000","message":"Done. They aren\u0027t very interesting because the failure stats are incremented in _replicate_object and here we call _repl_to_node","commit_id":"a3d1a7e893c2651513e563d8d41a6e0d20cea362"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b0cd0ed6cb88613e5260a8f3a7fbb5428a5bc27b","unresolved":false,"context_lines":[{"line_number":1392,"context_line":""},{"line_number":1393,"context_line":"    def test_sync_shard_ranges_none_to_sync(self):"},{"line_number":1394,"context_line":"        # verify that merge_shard_ranges is not sent if there are no shard"},{"line_number":1395,"context_line":"        # ranges to sync"},{"line_number":1396,"context_line":"        put_time \u003d Timestamp.now().internal"},{"line_number":1397,"context_line":"        broker \u003d self._get_broker(\u0027a\u0027, \u0027c\u0027, node_index\u003d0)"},{"line_number":1398,"context_line":"        broker.initialize(put_time, POLICIES.default.idx)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4a8fc322","line":1395,"updated":"2018-05-22 23:34:16.000000000","message":"+1","commit_id":"a3d1a7e893c2651513e563d8d41a6e0d20cea362"}]}
