)]}'
{"swift/common/db_replicator.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"40e6a28eb2bbd91f1f3add0879767826acd8b82e","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        :returns: boolean indicating completion and success"},{"line_number":348,"context_line":"        \"\"\""},{"line_number":349,"context_line":"        self.stats[\u0027diff\u0027] +\u003d 1"},{"line_number":350,"context_line":"        self.logger.increment(\u0027diffs\u0027)"},{"line_number":351,"context_line":"        self.logger.debug(\u0027%s usyncing chunks to %s, starting at row %s\u0027,"},{"line_number":352,"context_line":"                          broker.db_file,"},{"line_number":353,"context_line":"                          \u0027%(ip)s:%(port)s/%(device)s\u0027 % http.node,"},{"line_number":354,"context_line":"                          point)"},{"line_number":355,"context_line":"        start \u003d time.time()"},{"line_number":356,"context_line":"        sync_table \u003d broker.get_syncs()"},{"line_number":357,"context_line":"        objects \u003d broker.get_items_since(point, self.per_diff)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c0cbaf47","line":354,"range":{"start_line":349,"start_character":8,"end_line":354,"end_character":32},"updated":"2018-05-23 11:54:48.000000000","message":"these logs and stats increments will no longer happen when only syncing shard ranges...which is a good thing! before we ended up doing a no-op usync","commit_id":"0702d4de43858587236a38e633adf91dfc2a0153"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"40e6a28eb2bbd91f1f3add0879767826acd8b82e","unresolved":false,"context_lines":[{"line_number":480,"context_line":"    def _choose_replication_mode(self, node, rinfo, info, local_sync, broker,"},{"line_number":481,"context_line":"                                 http, different_region):"},{"line_number":482,"context_line":"        if self._in_sync(rinfo, info, broker, local_sync):"},{"line_number":483,"context_line":"            self.logger.debug(\u0027%s in sync with %s, nothing to do\u0027,"},{"line_number":484,"context_line":"                              broker.db_file,"},{"line_number":485,"context_line":"                              \u0027%(ip)s:%(port)s/%(device)s\u0027 % node)"},{"line_number":486,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c0c64f4a","line":483,"range":{"start_line":483,"start_character":31,"end_line":483,"end_character":64},"updated":"2018-05-23 11:54:48.000000000","message":"This will be logged now when it wasn\u0027t before, and strictly this refers only to the objects, but I think it\u0027s ok to leave as it is since it will only be logged *after* shard ranges have sync\u0027d","commit_id":"0702d4de43858587236a38e633adf91dfc2a0153"}],"swift/container/replicator.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"38acbcdf572f072d80863cf3d0675dd18893decc","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def _in_sync(self, rinfo, info, broker, local_sync):"},{"line_number":314,"context_line":"        # TODO: don\u0027t always sync shard ranges!"},{"line_number":315,"context_line":"        if broker.get_shard_ranges(include_own\u003dTrue, include_deleted\u003dTrue):"},{"line_number":316,"context_line":"            return False"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        return super(ContainerReplicator, self)._in_sync("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8792b6f5","side":"PARENT","line":315,"updated":"2018-05-22 22:12:31.000000000","message":"wait, so who looks at get_shard_ranges now?","commit_id":"765f6530e885e0828524b2f81fcf25c4221ec914"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"40e6a28eb2bbd91f1f3add0879767826acd8b82e","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def _in_sync(self, rinfo, info, broker, local_sync):"},{"line_number":314,"context_line":"        # TODO: don\u0027t always sync shard ranges!"},{"line_number":315,"context_line":"        if broker.get_shard_ranges(include_own\u003dTrue, include_deleted\u003dTrue):"},{"line_number":316,"context_line":"            return False"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        return super(ContainerReplicator, self)._in_sync("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_40bb1fc3","side":"PARENT","line":315,"in_reply_to":"5f7c97a3_27bba272","updated":"2018-05-23 11:54:48.000000000","message":"+1 before we were checking for shard ranges here simply to defer returning early. With this change we get to sync shard ranges before _in_sync is called so this becomes unnecessary.","commit_id":"765f6530e885e0828524b2f81fcf25c4221ec914"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"927790f482f744eb853924ef59361a99f7bdca3a","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def _in_sync(self, rinfo, info, broker, local_sync):"},{"line_number":314,"context_line":"        # TODO: don\u0027t always sync shard ranges!"},{"line_number":315,"context_line":"        if broker.get_shard_ranges(include_own\u003dTrue, include_deleted\u003dTrue):"},{"line_number":316,"context_line":"            return False"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        return super(ContainerReplicator, self)._in_sync("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_27bba272","side":"PARENT","line":315,"in_reply_to":"5f7c97a3_8792b6f5","updated":"2018-05-22 22:15:12.000000000","message":"_choose_replication_mode -- it\u0027ll sync shard ranges, then bail on calling the super\u0027s _choose_replication_mode","commit_id":"765f6530e885e0828524b2f81fcf25c4221ec914"}]}