)]}'
{"test/functional/__init__.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"5b4fcdfbe36b8c3d6d339e4c307c2b1d47746717","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        # by the various in-process swift servers"},{"line_number":573,"context_line":"        \u0027auth_host\u0027: \u0027127.0.0.1\u0027,"},{"line_number":574,"context_line":"        \u0027auth_port\u0027: str(prolis.getsockname()[1]),"},{"line_number":575,"context_line":"        \u0027storage_port\u0027: str(prolis.getsockname()[1]),"},{"line_number":576,"context_line":"        \u0027auth_ssl\u0027: \u0027no\u0027,"},{"line_number":577,"context_line":"        \u0027auth_prefix\u0027: \u0027/auth/\u0027,"},{"line_number":578,"context_line":"        # Primary functional test account (needs admin access to the"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_36229fba","line":575,"updated":"2018-05-30 07:41:03.000000000","message":"Probably we should define storage_host as well?\n\nThat is because the s3 auth model is different from swift itself (s3 doesn\u0027t get the token from the auth uri before the request) so the mixture of use of auth_host might be complex for the testers. And it might be nice to set prefix like \"s3_\" to be intuitive that would never overwrite any storage url for SWIFT func testing.","commit_id":"d099d634ebff19b4831bf8136ea45408417e7f79"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"6f7e299779934e401fc852ed24c757b3445ab68e","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        # by the various in-process swift servers"},{"line_number":573,"context_line":"        \u0027auth_host\u0027: \u0027127.0.0.1\u0027,"},{"line_number":574,"context_line":"        \u0027auth_port\u0027: str(prolis.getsockname()[1]),"},{"line_number":575,"context_line":"        \u0027storage_port\u0027: str(prolis.getsockname()[1]),"},{"line_number":576,"context_line":"        \u0027auth_ssl\u0027: \u0027no\u0027,"},{"line_number":577,"context_line":"        \u0027auth_prefix\u0027: \u0027/auth/\u0027,"},{"line_number":578,"context_line":"        # Primary functional test account (needs admin access to the"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_441c0f7a","line":575,"in_reply_to":"5f7c97a3_36229fba","updated":"2018-12-04 21:42:59.000000000","message":"...and storage_ssl...\n\nI might even prefer something like storage_url, which would let you do something like\n\n storage_url \u003d http://saio:8080\n\nor\n\n storage_url \u003d https://saio:4433","commit_id":"d099d634ebff19b4831bf8136ea45408417e7f79"}],"test/functional/s3api/s3_test_client.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"5b4fcdfbe36b8c3d6d339e4c307c2b1d47746717","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":"    Connection class used for S3 functional testing."},{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":"    def __init__(self, aws_access_key\u003d\u0027test:tester\u0027,"},{"line_number":37,"context_line":"                 aws_secret_key\u003d\u0027testing\u0027,"},{"line_number":38,"context_line":"                 user_id\u003d\u0027test:tester\u0027):"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"        Initialize method."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d6f9eb4d","line":38,"range":{"start_line":36,"start_character":23,"end_line":38,"end_character":40},"updated":"2018-05-30 07:41:03.000000000","message":"probably, we should remove the defaults to support configurable functional tests that might cause any similar problems in the future.\n\nIt requires also more changes because some acl tests set just invalid secret_key to expect to get errors from the S3 API, tho.\n\nOr setting sort of tf.configs[\u00273_access_key\u0027] by default might work as well, if we assume the Connection class w/o args should be the admin tester for s3api? So I like to consider carefully the responsibility who sets the configurable/default value of them.","commit_id":"d099d634ebff19b4831bf8136ea45408417e7f79"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"5b40e47a95a3fcd253b6812203bf0214d2b25912","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.host \u003d tf.config[\u0027auth_host\u0027]"},{"line_number":57,"context_line":"        self.port \u003d int(tf.config[\u0027storage_port\u0027])"},{"line_number":58,"context_line":"        self.conn \u003d \\"},{"line_number":59,"context_line":"            S3Connection(aws_access_key, aws_secret_key, is_secure\u003dFalse,"},{"line_number":60,"context_line":"                         host\u003dself.host, port\u003dself.port,"},{"line_number":61,"context_line":"                         calling_format\u003dOrdinaryCallingFormat())"},{"line_number":62,"context_line":"        self.conn.auth_region_name \u003d \u0027US\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1d4ea937","line":59,"range":{"start_line":59,"start_character":57,"end_line":59,"end_character":72},"updated":"2018-05-29 21:08:42.000000000","message":"Hmm...","commit_id":"d099d634ebff19b4831bf8136ea45408417e7f79"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"5b40e47a95a3fcd253b6812203bf0214d2b25912","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            S3Connection(aws_access_key, aws_secret_key, is_secure\u003dFalse,"},{"line_number":60,"context_line":"                         host\u003dself.host, port\u003dself.port,"},{"line_number":61,"context_line":"                         calling_format\u003dOrdinaryCallingFormat())"},{"line_number":62,"context_line":"        self.conn.auth_region_name \u003d \u0027US\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def reset(self):"},{"line_number":65,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3d4b652b","line":62,"range":{"start_line":62,"start_character":38,"end_line":62,"end_character":40},"updated":"2018-05-29 21:08:42.000000000","message":"Ugh, we should really get this from config, too...","commit_id":"d099d634ebff19b4831bf8136ea45408417e7f79"}],"test/sample.conf":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0ad639c3fa0202c7543d13b3abb55f93e11e2543","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#auth_uri \u003d http://localhost:5000/v3/"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Used by s3api functional tests, which don\u0027t contact auth directly"},{"line_number":28,"context_line":"#s3_storage_url \u003d http://127.0.0.1:8080/"},{"line_number":29,"context_line":"#s3_region \u003d us-east-1"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# Primary functional test account (needs admin access to the account)"}],"source_content_type":"text/plain","patch_set":2,"id":"ff570b3c_d8a19ffa","line":28,"range":{"start_line":28,"start_character":1,"end_line":28,"end_character":15},"updated":"2020-05-16 02:53:12.000000000","message":"Maybe this would be better as s3_endpoint to more-closely match [s3api_test]? *shrug*","commit_id":"261c4ec1b6e110eff6610ea82d69bae0af39592b"}]}