)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"36856a44660d2297a6ca6a5fff6a4ff8829a61a5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"container-updater: log LockTimeout exceptions at INFO, not ERROR"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Lock timeouts happen, especially on very busy containers. It\u0027s not"},{"line_number":10,"context_line":"worth a stack trace, and it\u0027s not an error. Now we still log the"},{"line_number":11,"context_line":"lock timeout, but at INFO level and without a stack trace."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia202c876fb726f9ae6040d875a83105dd975539b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_26afd2e3","line":10,"range":{"start_line":9,"start_character":58,"end_line":10,"end_character":19},"updated":"2018-05-30 00:15:14.000000000","message":"I\u0027m still not sure whether it\u0027s a good or bad thing, but with our LogAdapter, we wouldn\u0027t have gotten the stack trace anyway.","commit_id":"c13518bde1a571a39d1fbbf0648d6d9d0635cda1"}],"test/unit/container/test_updater.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"36856a44660d2297a6ca6a5fff6a4ff8829a61a5","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            cu.run_once()"},{"line_number":172,"context_line":"        log_lines \u003d self.logger.get_lines_for_level(\u0027info\u0027)"},{"line_number":173,"context_line":"        self.assertTrue(log_lines)"},{"line_number":174,"context_line":"        self.assertGreaterEqual(len(log_lines), 2)"},{"line_number":175,"context_line":"        self.assertIn(\u0027Failed to get container info \u0027, log_lines[1])"},{"line_number":176,"context_line":"        self.assertIn(\u0027devices/sda1/containers/subdir/hash.db\u0027, log_lines[1])"},{"line_number":177,"context_line":"        self.assertIn(\u0027Lock timeout\u0027, log_lines[1])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c6a05ef7","line":174,"updated":"2018-05-30 00:15:14.000000000","message":"The failures with this kind of assertion always kinda bug me... I wonder if something like http://paste.openstack.org/show/722316/ would\n\n- be easier to reason about,\n- give better messages when it fails, and\n- be more reflective of what happens in practice, with _db_timeout","commit_id":"c13518bde1a571a39d1fbbf0648d6d9d0635cda1"}]}