)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"f45807e0beaff3743db31b7a4196c20aa2c6bb0c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix quoting for large objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I46bdb6da8f778a6c86e0f8e883b52fc31e9fd44e"},{"line_number":10,"context_line":"Partial-Bug: 1774238"},{"line_number":11,"context_line":"Closes-Bug: 1678022"},{"line_number":12,"context_line":"Closes-Bug: 1598093"},{"line_number":13,"context_line":"Closes-Bug: 1762997"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_d828c69f","line":10,"updated":"2018-11-15 06:12:38.000000000","message":"Doesn\u0027t completely solve this. The account quotings are not matching on a bunch of tests, I\u0027ve started looking into why, but ran out of time today.","commit_id":"4001d9ca93494724cbd63ee408da3151eea49abf"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"04520a9ea7b19fe0448c375f15086a98110ae044","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix quoting for large objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I46bdb6da8f778a6c86e0f8e883b52fc31e9fd44e"},{"line_number":10,"context_line":"Partial-Bug: 1774238"},{"line_number":11,"context_line":"Closes-Bug: 1678022"},{"line_number":12,"context_line":"Closes-Bug: 1598093"},{"line_number":13,"context_line":"Closes-Bug: 1762997"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_a4f27c68","line":10,"in_reply_to":"3f79a3b5_d828c69f","updated":"2018-11-15 18:25:19.000000000","message":"Yeah, that\u0027s why it\u0027s just a Partial-Fix ;-)\n\nWe need the rest of the chain out to https://review.openstack.org/#/c/571908/1 (at least, once I fix all of that up)","commit_id":"4001d9ca93494724cbd63ee408da3151eea49abf"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"bd6165c377905f5a22383c770579e9613c5e83e0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I46bdb6da8f778a6c86e0f8e883b52fc31e9fd44e"},{"line_number":10,"context_line":"Partial-Bug: 1774238"},{"line_number":11,"context_line":"Closes-Bug: 1678022"},{"line_number":12,"context_line":"Closes-Bug: 1598093"},{"line_number":13,"context_line":"Closes-Bug: 1762997"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_4dc72c68","line":11,"updated":"2018-11-14 06:00:48.000000000","message":"This has fixed this.. at least with the limitted testing I did.","commit_id":"4001d9ca93494724cbd63ee408da3151eea49abf"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"bd6165c377905f5a22383c770579e9613c5e83e0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Change-Id: I46bdb6da8f778a6c86e0f8e883b52fc31e9fd44e"},{"line_number":10,"context_line":"Partial-Bug: 1774238"},{"line_number":11,"context_line":"Closes-Bug: 1678022"},{"line_number":12,"context_line":"Closes-Bug: 1598093"},{"line_number":13,"context_line":"Closes-Bug: 1762997"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_6dc46862","line":12,"updated":"2018-11-14 06:00:48.000000000","message":"And this. Tho, I seem to be having trouble looking at a DLO I created pre this patch.. but it might be user error, it\u0027s getting late and I might be confusing things.. will look again in the morning","commit_id":"4001d9ca93494724cbd63ee408da3151eea49abf"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"f45807e0beaff3743db31b7a4196c20aa2c6bb0c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Change-Id: I46bdb6da8f778a6c86e0f8e883b52fc31e9fd44e"},{"line_number":10,"context_line":"Partial-Bug: 1774238"},{"line_number":11,"context_line":"Closes-Bug: 1678022"},{"line_number":12,"context_line":"Closes-Bug: 1598093"},{"line_number":13,"context_line":"Closes-Bug: 1762997"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_f82d82ad","line":12,"updated":"2018-11-15 06:12:38.000000000","message":"OK,  it was a user error. this works, containers with a \u0027?\u0027 (or characters that need to be qouted).","commit_id":"4001d9ca93494724cbd63ee408da3151eea49abf"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"04520a9ea7b19fe0448c375f15086a98110ae044","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Change-Id: I46bdb6da8f778a6c86e0f8e883b52fc31e9fd44e"},{"line_number":10,"context_line":"Partial-Bug: 1774238"},{"line_number":11,"context_line":"Closes-Bug: 1678022"},{"line_number":12,"context_line":"Closes-Bug: 1598093"},{"line_number":13,"context_line":"Closes-Bug: 1762997"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_44712813","line":12,"in_reply_to":"3f79a3b5_f82d82ad","updated":"2018-11-15 18:25:19.000000000","message":"I do worry about the potential to break objects already written out on disk -- but I think the old behavior was broken enough that there wasn\u0027t really a way around it? I should maybe see what I can do with the old code and how it might break with the new some more...","commit_id":"4001d9ca93494724cbd63ee408da3151eea49abf"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"f45807e0beaff3743db31b7a4196c20aa2c6bb0c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Partial-Bug: 1774238"},{"line_number":11,"context_line":"Closes-Bug: 1678022"},{"line_number":12,"context_line":"Closes-Bug: 1598093"},{"line_number":13,"context_line":"Closes-Bug: 1762997"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_98324e0e","line":13,"updated":"2018-11-15 06:12:38.000000000","message":"This is the same as 1598093, ? in contiainer name works. Nice.","commit_id":"4001d9ca93494724cbd63ee408da3151eea49abf"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"bd6165c377905f5a22383c770579e9613c5e83e0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Partial-Bug: 1774238"},{"line_number":11,"context_line":"Closes-Bug: 1678022"},{"line_number":12,"context_line":"Closes-Bug: 1598093"},{"line_number":13,"context_line":"Closes-Bug: 1762997"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_0dc13450","line":13,"updated":"2018-11-14 06:00:48.000000000","message":"Wow, so many bugs","commit_id":"4001d9ca93494724cbd63ee408da3151eea49abf"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"04520a9ea7b19fe0448c375f15086a98110ae044","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Partial-Bug: 1774238"},{"line_number":11,"context_line":"Closes-Bug: 1678022"},{"line_number":12,"context_line":"Closes-Bug: 1598093"},{"line_number":13,"context_line":"Closes-Bug: 1762997"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_848ae0ba","line":13,"in_reply_to":"3f79a3b5_98324e0e","updated":"2018-11-15 18:25:19.000000000","message":"Yeah, I maybe should\u0027ve closed one as a duplicate of the other...","commit_id":"4001d9ca93494724cbd63ee408da3151eea49abf"}],"swift/common/middleware/dlo.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"04520a9ea7b19fe0448c375f15086a98110ae044","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                               prefix, marker\u003d\u0027\u0027):"},{"line_number":146,"context_line":"        con_req \u003d make_subrequest("},{"line_number":147,"context_line":"            req.environ,"},{"line_number":148,"context_line":"            path\u003dquote(\u0027/\u0027.join([\u0027\u0027, version, account, container])),"},{"line_number":149,"context_line":"            method\u003d\u0027GET\u0027,"},{"line_number":150,"context_line":"            headers\u003d{\u0027x-auth-token\u0027: req.headers.get(\u0027x-auth-token\u0027)},"},{"line_number":151,"context_line":"            agent\u003d(\u0027%(orig)s \u0027 + \u0027DLO MultipartGET\u0027), swift_source\u003d\u0027DLO\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_2480acbe","line":148,"range":{"start_line":148,"start_character":46,"end_line":148,"end_character":53},"updated":"2018-11-15 18:25:19.000000000","message":"Quoting the account here is part of why I count a partial-fix for #1774238","commit_id":"4001d9ca93494724cbd63ee408da3151eea49abf"}],"swift/common/middleware/slo.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"04520a9ea7b19fe0448c375f15086a98110ae044","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        Raise exception on failures."},{"line_number":527,"context_line":"        \"\"\""},{"line_number":528,"context_line":"        sub_req \u003d make_subrequest("},{"line_number":529,"context_line":"            req.environ, path\u003dquote(\u0027/\u0027.join([\u0027\u0027, version, acc, con, obj])),"},{"line_number":530,"context_line":"            method\u003d\u0027GET\u0027,"},{"line_number":531,"context_line":"            headers\u003d{\u0027x-auth-token\u0027: req.headers.get(\u0027x-auth-token\u0027)},"},{"line_number":532,"context_line":"            agent\u003d\u0027%(orig)s SLO MultipartGET\u0027, swift_source\u003d\u0027SLO\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_645f8474","line":529,"updated":"2018-11-15 18:25:19.000000000","message":"...and here...","commit_id":"4001d9ca93494724cbd63ee408da3151eea49abf"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"04520a9ea7b19fe0448c375f15086a98110ae044","unresolved":false,"context_lines":[{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"        def do_head(obj_name):"},{"line_number":1112,"context_line":"            obj_path \u003d quote(\u0027/\u0027.join(["},{"line_number":1113,"context_line":"                \u0027\u0027, vrs, account, get_valid_utf8_str(obj_name).lstrip(\u0027/\u0027)]))"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"            sub_req \u003d make_subrequest("},{"line_number":1116,"context_line":"                req.environ, path\u003dobj_path + \u0027?\u0027,  # kill the query string"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_e461543e","line":1113,"updated":"2018-11-15 18:25:19.000000000","message":"...and here...","commit_id":"4001d9ca93494724cbd63ee408da3151eea49abf"}],"test/functional/test_slo.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"34c79d80916cb428da022e834f69455e866dde3a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                        seg_info[\u0027seg_e\u0027]]),"},{"line_number":97,"context_line":"            parms\u003d{\u0027multipart-manifest\u0027: \u0027put\u0027})"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        cls.container.file(\u0027seg_with_%ff_funky_name\u0027).write(\u0027z\u0027 * 10)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Put the same manifest in the container2"},{"line_number":102,"context_line":"        file_item \u003d cls.container2.file(\"manifest-abcde\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_aac6179a","line":99,"range":{"start_line":99,"start_character":37,"end_line":99,"end_character":40},"updated":"2018-11-10 00:53:57.000000000","message":"Note that this is rather literal: swift_test_client takes care of quoting by default. See https://github.com/openstack/swift/blob/2.19.0/test/functional/swift_test_client.py#L243-L247","commit_id":"2210f059b2934427f3fdf7b8624880c856797ef5"}]}
