)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a2bf0844649ded66c69895e35b61104f72e8ddf5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use valid eventlet logger method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"eventlet\u003c\u003d0.17.4 LoggerFileWrapper does not have an error() method"},{"line_number":10,"context_line":"so don\u0027t try to call it. Instead, use info() which even in newer"},{"line_number":11,"context_line":"eventlet versions does exactly the same as error()."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_31d8a91c","line":9,"range":{"start_line":9,"start_character":9,"end_line":9,"end_character":10},"updated":"2018-06-20 17:18:48.000000000","message":"Gah! I\u0027m almost tempted to just bump up our minimum version of eventlet... The *very next version* after our current minimum is fine :-/","commit_id":"a1cb91993096971934755cae08aa8013c10fc8f9"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a2bf0844649ded66c69895e35b61104f72e8ddf5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"eventlet\u003c\u003d0.17.4 LoggerFileWrapper does not have an error() method"},{"line_number":10,"context_line":"so don\u0027t try to call it. Instead, use info() which even in newer"},{"line_number":11,"context_line":"eventlet versions does exactly the same as error()."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This bug only manifests in unit tests once the Related-Bug has been fixed"},{"line_number":14,"context_line":"(see Related-Change)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_91c41d43","line":11,"updated":"2018-06-20 17:18:48.000000000","message":"Huh. Sure enough: https://github.com/eventlet/eventlet/blob/v0.22.0/eventlet/wsgi.py#L282-L286","commit_id":"a1cb91993096971934755cae08aa8013c10fc8f9"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a2bf0844649ded66c69895e35b61104f72e8ddf5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This bug only manifests in unit tests once the Related-Bug has been fixed"},{"line_number":14,"context_line":"(see Related-Change)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1777836"},{"line_number":17,"context_line":"Related-Bug: #1777701"},{"line_number":18,"context_line":"Related-Change: I68fd9d0263a6720aaf0d90b8ea6da1158105ac01"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_314d09c4","line":16,"updated":"2018-06-20 17:18:48.000000000","message":"Wow! That was *not* an obvious failure mode. Makes me very glad they got rid of https://github.com/eventlet/eventlet/blob/v0.17.4/eventlet/wsgi.py#L829-L834 in later versions.\n\nAttributeErrors: one of those handful of places where it\u0027s *way better* to LBYL!","commit_id":"a1cb91993096971934755cae08aa8013c10fc8f9"}]}