)]}'
{"swift/common/middleware/s3api/acl_handlers.py":[{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"d1fc9f8e8d30a0d4a4f439dae023991200493784","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                                   Owner(self.user_id, self.user_id))"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        if not self.req.environ.get(\u0027swift_owner\u0027):"},{"line_number":213,"context_line":"            raise AccessDenied()"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        # To avoid overwriting the existing bucket\u0027s ACL, we send PUT"},{"line_number":216,"context_line":"        # request first before setting the ACL to make sure that the target"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8276bb3d","line":213,"updated":"2018-08-14 16:39:57.000000000","message":"this is not getting tested by the unit tests. I\u0027m going to try to come up with some tests for it.","commit_id":"5f1fb5a1c16bd5f1c4037b4b133a7889630b90c0"}],"test/unit/common/middleware/s3api/helpers.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"240d6a05d80dd69ad8ae429dc93f6deea7fcd855","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            def authorize_cb(req):"},{"line_number":58,"context_line":"                # Assume swift owner if not yet set"},{"line_number":59,"context_line":"                if req.environ.get(\u0027swift_owner\u0027) is None:"},{"line_number":60,"context_line":"                    req.environ[\u0027swift_owner\u0027] \u003d True"},{"line_number":61,"context_line":"                # But then default to blocking authz, to ensure we\u0027ve replaced"},{"line_number":62,"context_line":"                # the default auth system"},{"line_number":63,"context_line":"                return swob.HTTPForbidden(request\u003dreq)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a75ae27f","line":60,"updated":"2018-08-14 22:45:59.000000000","message":"nit:\n\n req.environ.setdefault(\u0027swift_owner\u0027, True)\n\nwould still be pretty explicit.\n\nI was also considering doing something like\n\n class FakeSwift(object):\n     assume_swift_owner \u003d True\n     ...\n             def authorize_cb(req):\n                 req.environ[\u0027swift_owner\u0027] \u003d self.assume_swift_owner\n\nand letting the one test that needs it set\n\n self.swift.assume_swift_owner \u003d False\n\n*shrug*","commit_id":"1d3c635552b5461766b88d3a5390833f8338e078"}]}