)]}'
{"doc/source/deployment_guide.rst":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"e2df307cb87a709fecd53310080350f0b1786103","unresolved":false,"context_lines":[{"line_number":709,"context_line":"                                                           replicator_handoff_only_workers."},{"line_number":710,"context_line":"replicator_primary_only_workers  0                         Number of worker processes to use"},{"line_number":711,"context_line":"                                                           for replicating primary partitions."},{"line_number":712,"context_line":"\t\t\t\t\t\t\t   Primary partitions are those which"},{"line_number":713,"context_line":"\t\t\t\t\t\t\t   are on a particular disk and also"},{"line_number":714,"context_line":"\t\t\t\t\t\t\t   belong on that particular disk."},{"line_number":715,"context_line":"replicator_handoff_only_workers  0                         Number of worker processes to use"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_e46fed5d","line":712,"updated":"2018-09-13 21:27:36.000000000","message":"mixing tabs and spaces\nAnd IMHO, the \"_only\" part is unnecessary.","commit_id":"f9599fd9996685b569412ba677178d2527b97981"}],"swift/obj/replicator.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"1a3305ff030f5b2c694d4d9cc5ea6d29265d0b90","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self.replicator_workers \u003d int(conf.get(\u0027replicator_workers\u0027, 0))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if \u0027replicator_handoff_workers\u0027 in conf:"},{"line_number":147,"context_line":"            rhw \u003d int(conf[\u0027replicator_handoff_workers\u0027])"},{"line_number":148,"context_line":"            if rhw \u003c 1:"},{"line_number":149,"context_line":"                raise ValueError("},{"line_number":150,"context_line":"                    \"replicator_handoff_workers must be at least 1 \""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_33d83650","line":147,"updated":"2018-06-27 05:28:57.000000000","message":"You should just use swift.utils.config_positive_int_value here, as it\u0027ll do all this for you.","commit_id":"5eec443b69a6ee0e36ab1fba7f74ba5a2829b07b"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9441050f1432de1adee780bbacee61dcdb5467b0","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            self.replicator_primary_only_workers \u003d config_positive_int_value("},{"line_number":201,"context_line":"                conf.get(\u0027replicator_primary_only_workers\u0027, 0))"},{"line_number":202,"context_line":"            self.replicator_handoff_only_workers \u003d config_positive_int_value("},{"line_number":203,"context_line":"                conf.get(\u0027replicator_handoff_only_workers\u0027, 0))"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            self.replicator_workers \u003d int(conf.get(\u0027replicator_workers\u0027, 0))"},{"line_number":206,"context_line":"            self.replicator_primary_only_workers \u003d 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_2c04cc17","line":203,"range":{"start_line":203,"start_character":60,"end_line":203,"end_character":61},"updated":"2018-07-03 17:51:35.000000000","message":"nit: I think a default of None would be more appropriate. The default of \u00270\u0027 is invalid so will be included in the ValueError message, which is confusing if the user did not set \u00270\u0027 in their config e.g.:\n\n  ValueError: Config option must be an positive int number, not \"0\".\n\nalso bit: It would also be nice to include the name of an invalid option when raising the ValueError.","commit_id":"f9599fd9996685b569412ba677178d2527b97981"}]}