)]}'
{"swift/common/constraints.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"58005123a54b06b4271bcc90627288a477baf26a","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    try:"},{"line_number":301,"context_line":"        return request.timestamp"},{"line_number":302,"context_line":"    except exceptions.InvalidTimestamp as e:"},{"line_number":303,"context_line":"        raise HTTPBadRequest(body\u003dstr(e).encode(\u0027utf8\u0027), request\u003drequest,"},{"line_number":304,"context_line":"                             content_type\u003d\u0027text/plain\u0027)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_53a372ff","line":303,"range":{"start_line":303,"start_character":41,"end_line":303,"end_character":55},"updated":"2018-06-27 05:06:47.000000000","message":"Why utf8 and not ascii like the others. I mean, are we expecting non ascii characters?","commit_id":"572b7fcd2c9ce78b7083854c5e4112165a3a8b6a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"257b72e7213b33b00bfd39bc8a74ce8a87567a3a","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    try:"},{"line_number":301,"context_line":"        return request.timestamp"},{"line_number":302,"context_line":"    except exceptions.InvalidTimestamp as e:"},{"line_number":303,"context_line":"        raise HTTPBadRequest(body\u003dstr(e).encode(\u0027utf8\u0027), request\u003drequest,"},{"line_number":304,"context_line":"                             content_type\u003d\u0027text/plain\u0027)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8d7f8c68","line":303,"range":{"start_line":303,"start_character":41,"end_line":303,"end_character":55},"in_reply_to":"5f7c97a3_53a372ff","updated":"2018-06-27 23:00:44.000000000","message":"Absent-mindedness? Yeah, InvalidTimestamp should always be something ASCII, I think.","commit_id":"572b7fcd2c9ce78b7083854c5e4112165a3a8b6a"}],"swift/common/middleware/tempauth.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"a23a17f72e1a1e88d19d2cadb408ec93103cbbf1","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            # While it is possible to construct auth systems that collaborate"},{"line_number":507,"context_line":"            # on ACLs, TempAuth is not such an auth system.  At this point,"},{"line_number":508,"context_line":"            # it thinks it is authoritative."},{"line_number":509,"context_line":"            if key not in tempauth_acl_keys:"},{"line_number":510,"context_line":"                return \"Key %s not recognized\" % json.dumps("},{"line_number":511,"context_line":"                    key).encode(\u0027ascii\u0027)"},{"line_number":512,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e38c1082","line":509,"updated":"2018-06-28 02:12:02.000000000","message":"I don\u0027t understand why a JSON syntax is needed in a message. If anything, you might want ``\u0027\u0027 or whatnot.","commit_id":"76525fc8dc033e95e6ce1ef7c2855bace1b4364b"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"53e7af0f0a876eab6ef8b37e15dcf7a38e202fed","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            # While it is possible to construct auth systems that collaborate"},{"line_number":507,"context_line":"            # on ACLs, TempAuth is not such an auth system.  At this point,"},{"line_number":508,"context_line":"            # it thinks it is authoritative."},{"line_number":509,"context_line":"            if key not in tempauth_acl_keys:"},{"line_number":510,"context_line":"                return \"Key %s not recognized\" % json.dumps("},{"line_number":511,"context_line":"                    key).encode(\u0027ascii\u0027)"},{"line_number":512,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_78d3b4d4","line":509,"in_reply_to":"5f7c97a3_82798431","updated":"2018-06-28 21:46:45.000000000","message":"Yeah, but you aren\u0027t preserving the original JSON for diagnostics there. Therefore, the most unbiased way to dump this is %r with (key,), IMHO.","commit_id":"76525fc8dc033e95e6ce1ef7c2855bace1b4364b"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"37af92f3703c941c3fa1aa3639545ea0907d5a5d","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            # While it is possible to construct auth systems that collaborate"},{"line_number":507,"context_line":"            # on ACLs, TempAuth is not such an auth system.  At this point,"},{"line_number":508,"context_line":"            # it thinks it is authoritative."},{"line_number":509,"context_line":"            if key not in tempauth_acl_keys:"},{"line_number":510,"context_line":"                return \"Key %s not recognized\" % json.dumps("},{"line_number":511,"context_line":"                    key).encode(\u0027ascii\u0027)"},{"line_number":512,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_82798431","line":509,"in_reply_to":"5f7c97a3_e38c1082","updated":"2018-06-28 17:09:37.000000000","message":"...because the data is coming out of json? Why *wouldn\u0027t* we want to reserialize in the same way?\n\nＨｅｌｌｏ is not the same as Hello or even H e l l o, but that\u0027s not nearly as obvious as \"\\uff28\\uff45\\uff4c\\uff4c\\uff4f\"","commit_id":"76525fc8dc033e95e6ce1ef7c2855bace1b4364b"}],"swift/common/swob.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"a23a17f72e1a1e88d19d2cadb408ec93103cbbf1","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"RESPONSE_REASONS \u003d {"},{"line_number":60,"context_line":"    100: (\u0027Continue\u0027, b\u0027\u0027),"},{"line_number":61,"context_line":"    200: (\u0027OK\u0027, b\u0027\u0027),"},{"line_number":62,"context_line":"    201: (\u0027Created\u0027, b\u0027\u0027),"},{"line_number":63,"context_line":"    202: (\u0027Accepted\u0027, b\u0027The request is accepted for processing.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e3bad009","line":60,"updated":"2018-06-28 02:12:02.000000000","message":"this is just out of control - these are only used in a well-defined place, so not necessary pre-encode","commit_id":"76525fc8dc033e95e6ce1ef7c2855bace1b4364b"}]}