)]}'
{"swift/proxy/controllers/obj.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"01a6ad06a914d66c5818c41c6757df33dd4a0f0b","unresolved":false,"context_lines":[{"line_number":1994,"context_line":""},{"line_number":1995,"context_line":"        put_resp \u003d self.await_response(self.node_timeout, False)"},{"line_number":1996,"context_line":"        if not is_success(put_resp.status):"},{"line_number":1997,"context_line":"            return"},{"line_number":1998,"context_line":""},{"line_number":1999,"context_line":"        headers \u003d HeaderKeyDict(put_resp.getheaders())"},{"line_number":2000,"context_line":"        temp_id \u003d headers.get(\u0027X-Backend-Temp-Id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0096b04a","line":1997,"updated":"2018-06-29 17:38:30.000000000","message":"I do not understand. I thought Proxy wanted to know if one of the nodes stops working.","commit_id":"51a95a36fc8ed8909dadd2d7db582e205da27b4d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"1d603ab9a5eb066c4becbdeb6d875cadea003794","unresolved":false,"context_lines":[{"line_number":1994,"context_line":""},{"line_number":1995,"context_line":"        put_resp \u003d self.await_response(self.node_timeout, False)"},{"line_number":1996,"context_line":"        if not is_success(put_resp.status):"},{"line_number":1997,"context_line":"            return"},{"line_number":1998,"context_line":""},{"line_number":1999,"context_line":"        headers \u003d HeaderKeyDict(put_resp.getheaders())"},{"line_number":2000,"context_line":"        temp_id \u003d headers.get(\u0027X-Backend-Temp-Id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ca94338f","line":1997,"in_reply_to":"5f7c97a3_0096b04a","updated":"2018-07-02 17:57:59.000000000","message":"sorry, that should not have skipped into this patch.\n\nHowever, I don\u0027t think raising ChunkWriteTimout is the correct strategy. Raising an exception here will cause the entire PUT to terminate early, whereas it is only this putter that has failed - a quorum may still succeed.\n\nI *think* the right thing may be to make the failed response be the putter\u0027s final response, and then return - no poont sending the POST requests.\n\nI\u0027ll try that in a later patch where the tests are also added for this path.","commit_id":"51a95a36fc8ed8909dadd2d7db582e205da27b4d"}]}