)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"783efa8bd7003ab2613e8f6a962bf73d3973af6d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"will take precedence."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"When looking for the active root secret, only the right-most keymaster"},{"line_number":16,"context_line":"is used."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6b5c812a54624f56c55164556385e3e475fb2470"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_e5a20ffb","line":16,"updated":"2018-10-03 06:35:36.000000000","message":"Could both these points be added to the documentation somewhere? Maybe overview_encryption or something?","commit_id":"2610a1cef97528ba4525e38e89e6a8d23b0aaa11"}],"swift/common/middleware/crypto/keymaster.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"783efa8bd7003ab2613e8f6a962bf73d3973af6d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        except UnknownSecretIdError:"},{"line_number":125,"context_line":"            if self.alternate_fetch_keys:"},{"line_number":126,"context_line":"                return self.alternate_fetch_keys(key_id, *args, **kwargs)"},{"line_number":127,"context_line":"            raise"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def handle_request(self, req, start_response):"},{"line_number":130,"context_line":"        self.alternate_fetch_keys \u003d req.environ.get(CRYPTO_KEY_CALLBACK)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_054ceb73","line":127,"updated":"2018-10-03 06:35:36.000000000","message":"I got an ugly stack trace when I forced this. 3 keymasters, PUT and object with each one. Then removed the first keymaster. http://paste.openstack.org/show/731331/\n\nWe should clean it up by giving it a better message. Ie catch it and give a cleaner message. Maybe back in the handle methods or whereever.","commit_id":"2610a1cef97528ba4525e38e89e6a8d23b0aaa11"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"6510813f09c09eee7d47c0327ac7ef3799b17c65","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        except UnknownSecretIdError:"},{"line_number":125,"context_line":"            if self.alternate_fetch_keys:"},{"line_number":126,"context_line":"                return self.alternate_fetch_keys(key_id, *args, **kwargs)"},{"line_number":127,"context_line":"            raise"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def handle_request(self, req, start_response):"},{"line_number":130,"context_line":"        self.alternate_fetch_keys \u003d req.environ.get(CRYPTO_KEY_CALLBACK)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_4c9bce14","line":127,"in_reply_to":"3f79a3b5_054ceb73","updated":"2018-10-16 21:27:39.000000000","message":"Fixed in decrypter.py","commit_id":"2610a1cef97528ba4525e38e89e6a8d23b0aaa11"}]}
