)]}'
{"swift/account/backend.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"44fcc2611d1066a33afb64358796ac1b8bd081b3","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def _commit_puts_load(self, item_list, entry):"},{"line_number":206,"context_line":"        \"\"\"See :func:`swift.common.db.DatabaseBroker._commit_puts_load`\"\"\""},{"line_number":207,"context_line":"        loaded \u003d pickle.loads(entry.decode(\u0027base64\u0027))"},{"line_number":208,"context_line":"        # check to see if the update includes policy_index or not"},{"line_number":209,"context_line":"        (name, put_timestamp, delete_timestamp, object_count, bytes_used,"},{"line_number":210,"context_line":"         deleted) \u003d loaded[:6]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_cd3803d6","side":"PARENT","line":207,"updated":"2018-09-12 05:17:35.000000000","message":"On py3,\n\n AttributeError: \u0027str\u0027 object has no attribute \u0027decode\u0027","commit_id":"582a1f2738ec78c64437df49ca64ec7bfc686548"}],"swift/common/db.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"44fcc2611d1066a33afb64358796ac1b8bd081b3","unresolved":false,"context_lines":[{"line_number":695,"context_line":"                    fp.write(\u0027:\u0027)"},{"line_number":696,"context_line":"                    fp.write(pickle.dumps("},{"line_number":697,"context_line":"                        self.make_tuple_for_pickle(record),"},{"line_number":698,"context_line":"                        protocol\u003dPICKLE_PROTOCOL).encode(\u0027base64\u0027))"},{"line_number":699,"context_line":"                    fp.flush()"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"    def _skip_commit_puts(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_8d320bf2","side":"PARENT","line":698,"updated":"2018-09-12 05:17:35.000000000","message":"On py3,\n\n AttributeError: \u0027bytes\u0027 object has no attribute \u0027encode\u0027","commit_id":"582a1f2738ec78c64437df49ca64ec7bfc686548"}],"swift/common/middleware/crypto/crypto_utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"44fcc2611d1066a33afb64358796ac1b8bd081b3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    cipher \u003d \u0027AES_CTR_256\u0027"},{"line_number":41,"context_line":"    # AES will accept several key sizes - we are using 256 bits i.e. 32 bytes"},{"line_number":42,"context_line":"    key_length \u003d 32"},{"line_number":43,"context_line":"    iv_length \u003d algorithms.AES.block_size / 8"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __init__(self, conf\u003dNone):"},{"line_number":46,"context_line":"        self.logger \u003d get_logger(conf, log_route\u003d\"crypto\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_4d4ab35b","side":"PARENT","line":43,"updated":"2018-09-12 05:17:35.000000000","message":"Need an int, float won\u0027t work.","commit_id":"582a1f2738ec78c64437df49ca64ec7bfc686548"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"44fcc2611d1066a33afb64358796ac1b8bd081b3","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    :return: a string of the form \u003cvalue\u003e; swift_meta\u003d\u003cserialized crypto meta\u003e"},{"line_number":276,"context_line":"    \"\"\""},{"line_number":277,"context_line":"    if not isinstance(value, str):"},{"line_number":278,"context_line":"        raise ValueError"},{"line_number":279,"context_line":"    return \u0027%s; swift_meta\u003d%s\u0027 % (value, dump_crypto_meta(crypto_meta))"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_0d54bbfd","line":278,"updated":"2018-09-12 05:17:35.000000000","message":"Just for our own sanity.","commit_id":"eeeefdec87e1fcc42e7a612bf3d621db149e4a55"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"a51068686f9eb7dbe1835aab101d801d1cf30dae","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        except KeyError:"},{"line_number":164,"context_line":"            self.logger.exception(_(\u0027ERROR get_keys() missing callback\u0027))"},{"line_number":165,"context_line":"            raise HTTPInternalServerError("},{"line_number":166,"context_line":"                b\"Unable to retrieve encryption keys.\")"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        err \u003d None"},{"line_number":169,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_50cd6690","line":166,"updated":"2018-10-19 21:16:42.000000000","message":"Is this b\u0027\u0027 still needed? We added the encoding in swob.py:Response.__init__() in I206a9611e7f348f49e5c2d0e677fed3b0739c167.","commit_id":"ddd8377e87e92a7330575ff64c15230a93677a7d"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"830f8e93be6a504576313560f4859287cd5d51b1","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        except KeyError:"},{"line_number":164,"context_line":"            self.logger.exception(_(\u0027ERROR get_keys() missing callback\u0027))"},{"line_number":165,"context_line":"            raise HTTPInternalServerError("},{"line_number":166,"context_line":"                b\"Unable to retrieve encryption keys.\")"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        err \u003d None"},{"line_number":169,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_fc8c76d9","line":166,"in_reply_to":"3f79a3b5_50cd6690","updated":"2018-10-19 23:28:51.000000000","message":"Nope; removed.","commit_id":"ddd8377e87e92a7330575ff64c15230a93677a7d"}],"swift/common/middleware/crypto/decrypter.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"44fcc2611d1066a33afb64358796ac1b8bd081b3","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            self.logger.error(_(\u0027Error decrypting %(resp_type)s: %(reason)s\u0027),"},{"line_number":82,"context_line":"                              {\u0027resp_type\u0027: self.server_type, \u0027reason\u0027: err})"},{"line_number":83,"context_line":"        raise HTTPInternalServerError("},{"line_number":84,"context_line":"            body\u003db\u0027Error decrypting %s\u0027 % self.server_type.encode(\u0027ascii\u0027),"},{"line_number":85,"context_line":"            content_type\u003d\u0027text/plain\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def decrypt_value_with_meta(self, value, key, required, encoder):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_ed3a9fc2","line":84,"updated":"2018-09-12 05:17:35.000000000","message":"I should maybe rebase and avoid this following https://review.openstack.org/#/c/601872/ ...","commit_id":"eeeefdec87e1fcc42e7a612bf3d621db149e4a55"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"44fcc2611d1066a33afb64358796ac1b8bd081b3","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        return value"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def decrypt_value(self, value, key, crypto_meta, encoder):"},{"line_number":121,"context_line":"        \"\"\""},{"line_number":122,"context_line":"        Base64-decode and decrypt a value using the crypto_meta provided."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_6d78cf8e","line":120,"range":{"start_line":120,"start_character":53,"end_line":120,"end_character":60},"updated":"2018-09-12 05:17:35.000000000","message":"Sometimes we want the result to be a wsgi string, sometimes a unicode string -- plumb this in to let callers decide.","commit_id":"eeeefdec87e1fcc42e7a612bf3d621db149e4a55"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"a51068686f9eb7dbe1835aab101d801d1cf30dae","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            self.logger.error(_(\u0027Error decrypting %(resp_type)s: %(reason)s\u0027),"},{"line_number":82,"context_line":"                              {\u0027resp_type\u0027: self.server_type, \u0027reason\u0027: err})"},{"line_number":83,"context_line":"        raise HTTPInternalServerError("},{"line_number":84,"context_line":"            body\u003db\u0027Error decrypting %s\u0027 % self.server_type.encode(\u0027ascii\u0027),"},{"line_number":85,"context_line":"            content_type\u003d\u0027text/plain\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def decrypt_value_with_meta(self, value, key, required, encoder):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_66621744","line":84,"updated":"2018-10-19 21:16:42.000000000","message":"see how much work we saved by making this unnecessary","commit_id":"ddd8377e87e92a7330575ff64c15230a93677a7d"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f72b3e469cabc7ec61cf87bdb79161c3fba1621b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        :param required: if True then the value is required to be decrypted"},{"line_number":101,"context_line":"                         and an EncryptionException will be raised if the"},{"line_number":102,"context_line":"                         header cannot be decrypted due to missing crypto meta."},{"line_number":103,"context_line":"        :returns: decrypted value if crypto meta is found, otherwise the"},{"line_number":104,"context_line":"                  unmodified value"},{"line_number":105,"context_line":"        :raises EncryptionException: if an error occurs while parsing crypto"},{"line_number":106,"context_line":"                                     meta or if the header value was required"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_86f148e2","line":103,"updated":"2018-11-20 20:48:36.000000000","message":"Needs\n\n :param encoder:","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"52d1fc748a3284620b89f06caebebe7d67ddd596","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        :param required: if True then the value is required to be decrypted"},{"line_number":101,"context_line":"                         and an EncryptionException will be raised if the"},{"line_number":102,"context_line":"                         header cannot be decrypted due to missing crypto meta."},{"line_number":103,"context_line":"        :returns: decrypted value if crypto meta is found, otherwise the"},{"line_number":104,"context_line":"                  unmodified value"},{"line_number":105,"context_line":"        :raises EncryptionException: if an error occurs while parsing crypto"},{"line_number":106,"context_line":"                                     meta or if the header value was required"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_9c5d1419","line":103,"in_reply_to":"3f79a3b5_86f148e2","updated":"2018-11-20 22:31:32.000000000","message":"Done in https://review.openstack.org/#/c/619109/ -- and renamed to decoder (since it\u0027s decoding)","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f72b3e469cabc7ec61cf87bdb79161c3fba1621b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        :param key: crypto key to use"},{"line_number":127,"context_line":"        :param crypto_meta: a crypto-meta dict of form returned by"},{"line_number":128,"context_line":"            :py:func:`~swift.common.middleware.crypto.Crypto.get_crypto_meta`"},{"line_number":129,"context_line":"        :returns: decrypted value"},{"line_number":130,"context_line":"        \"\"\""},{"line_number":131,"context_line":"        if not value:"},{"line_number":132,"context_line":"            return encoder(b\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_46fb30be","line":129,"updated":"2018-11-20 20:48:36.000000000","message":"Ditto","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"52d1fc748a3284620b89f06caebebe7d67ddd596","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        :param key: crypto key to use"},{"line_number":127,"context_line":"        :param crypto_meta: a crypto-meta dict of form returned by"},{"line_number":128,"context_line":"            :py:func:`~swift.common.middleware.crypto.Crypto.get_crypto_meta`"},{"line_number":129,"context_line":"        :returns: decrypted value"},{"line_number":130,"context_line":"        \"\"\""},{"line_number":131,"context_line":"        if not value:"},{"line_number":132,"context_line":"            return encoder(b\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_fc93e8ae","line":129,"in_reply_to":"3f79a3b5_46fb30be","updated":"2018-11-20 22:31:32.000000000","message":"Done in https://review.openstack.org/#/c/619109/","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"}],"swift/common/middleware/crypto/encrypter.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"44fcc2611d1066a33afb64358796ac1b8bd081b3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    :returns: a Base64-encoded representation of the HMAC"},{"line_number":61,"context_line":"    \"\"\""},{"line_number":62,"context_line":"    if not isinstance(etag, bytes):"},{"line_number":63,"context_line":"        etag \u003d etag.encode(\u0027ascii\u0027)"},{"line_number":64,"context_line":"    result \u003d hmac.new(key, etag, digestmod\u003dhashlib.sha256).digest()"},{"line_number":65,"context_line":"    return base64.b64encode(result).decode()"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_0da27bfd","line":63,"updated":"2018-09-12 05:17:35.000000000","message":"Should probbaly use wsgi_to_bytes instead, since this takes client header values.","commit_id":"eeeefdec87e1fcc42e7a612bf3d621db149e4a55"}],"swift/common/middleware/crypto/keymaster.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"44fcc2611d1066a33afb64358796ac1b8bd081b3","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            raise UnknownSecretIdError(secret_id)"},{"line_number":246,"context_line":"        else:"},{"line_number":247,"context_line":"            if not isinstance(path, bytes):"},{"line_number":248,"context_line":"                path \u003d path.encode(\u0027utf8\u0027)"},{"line_number":249,"context_line":"            return hmac.new(key, path, digestmod\u003dhashlib.sha256).digest()"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_cd94838f","line":248,"updated":"2018-09-12 05:17:35.000000000","message":"... or wsgi_to_bytes? :-/\n\nGotta get some upgrade tests with encryption going...","commit_id":"eeeefdec87e1fcc42e7a612bf3d621db149e4a55"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"830f8e93be6a504576313560f4859287cd5d51b1","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            raise UnknownSecretIdError(secret_id)"},{"line_number":246,"context_line":"        else:"},{"line_number":247,"context_line":"            if not isinstance(path, bytes):"},{"line_number":248,"context_line":"                path \u003d path.encode(\u0027utf8\u0027)"},{"line_number":249,"context_line":"            return hmac.new(key, path, digestmod\u003dhashlib.sha256).digest()"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_1db242e6","line":248,"in_reply_to":"3f79a3b5_cd94838f","updated":"2018-10-19 23:28:51.000000000","message":"Functionally tested; gotta do the wsgi dance.","commit_id":"eeeefdec87e1fcc42e7a612bf3d621db149e4a55"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f72b3e469cabc7ec61cf87bdb79161c3fba1621b","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        \"\"\""},{"line_number":246,"context_line":"        Creates an encryption key that is unique for the given path."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        :param path: the path of the resource being encrypted."},{"line_number":249,"context_line":"        :param secret_id: the id of the root secret from which the key should"},{"line_number":250,"context_line":"            be derived."},{"line_number":251,"context_line":"        :return: an encryption key."}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_a1da2e45","line":248,"updated":"2018-11-20 20:48:36.000000000","message":"Should maybe call out that this should be a WSGI string.","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"52d1fc748a3284620b89f06caebebe7d67ddd596","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        \"\"\""},{"line_number":246,"context_line":"        Creates an encryption key that is unique for the given path."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        :param path: the path of the resource being encrypted."},{"line_number":249,"context_line":"        :param secret_id: the id of the root secret from which the key should"},{"line_number":250,"context_line":"            be derived."},{"line_number":251,"context_line":"        :return: an encryption key."}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_1c97c49d","line":248,"in_reply_to":"3f79a3b5_a1da2e45","updated":"2018-11-20 22:31:32.000000000","message":"Done in https://review.openstack.org/#/c/619109/","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"}],"swift/common/swob.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f72b3e469cabc7ec61cf87bdb79161c3fba1621b","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"        Provides the account/container/object path, sans API version."},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        This can be useful when constructing a path to send to a backend"},{"line_number":1004,"context_line":"        server, as that path will need everything after the \"/v1\"."},{"line_number":1005,"context_line":"        \"\"\""},{"line_number":1006,"context_line":"        _ver, entity_path \u003d self.split_path(1, 2, rest_with_last\u003dTrue)"},{"line_number":1007,"context_line":"        if entity_path is not None:"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_41c23a56","line":1004,"updated":"2018-11-20 20:48:36.000000000","message":"Should call out that the result is a native string, not WSGI string (as you\u0027d find in PATH_INFO, say).","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"52d1fc748a3284620b89f06caebebe7d67ddd596","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"        Provides the account/container/object path, sans API version."},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        This can be useful when constructing a path to send to a backend"},{"line_number":1004,"context_line":"        server, as that path will need everything after the \"/v1\"."},{"line_number":1005,"context_line":"        \"\"\""},{"line_number":1006,"context_line":"        _ver, entity_path \u003d self.split_path(1, 2, rest_with_last\u003dTrue)"},{"line_number":1007,"context_line":"        if entity_path is not None:"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_bc9d70bb","line":1004,"in_reply_to":"3f79a3b5_41c23a56","updated":"2018-11-20 22:31:32.000000000","message":"Done in https://review.openstack.org/#/c/619109/","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"}],"swift/container/backend.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"44fcc2611d1066a33afb64358796ac1b8bd081b3","unresolved":false,"context_lines":[{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    def _commit_puts_load(self, item_list, entry):"},{"line_number":646,"context_line":"        \"\"\"See :func:`swift.common.db.DatabaseBroker._commit_puts_load`\"\"\""},{"line_number":647,"context_line":"        data \u003d pickle.loads(base64.b64decode(entry))"},{"line_number":648,"context_line":"        (name, timestamp, size, content_type, etag, deleted) \u003d data[:6]"},{"line_number":649,"context_line":"        if len(data) \u003e 6:"},{"line_number":650,"context_line":"            storage_policy_index \u003d data[6]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_ed913f9c","line":647,"updated":"2018-09-12 05:17:35.000000000","message":"As in account/backend","commit_id":"eeeefdec87e1fcc42e7a612bf3d621db149e4a55"}],"swift/container/server.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f72b3e469cabc7ec61cf87bdb79161c3fba1621b","unresolved":false,"context_lines":[{"line_number":555,"context_line":"            response \u003d dict(record)"},{"line_number":556,"context_line":"        else:"},{"line_number":557,"context_line":"            (name, created, size, content_type, etag) \u003d record[:5]"},{"line_number":558,"context_line":"            name_ \u003d name.decode(\u0027utf8\u0027) if six.PY2 else name"},{"line_number":559,"context_line":"            if content_type is None:"},{"line_number":560,"context_line":"                return {\u0027subdir\u0027: name_}"},{"line_number":561,"context_line":"            response \u003d {"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_6192d657","line":558,"updated":"2018-11-20 20:48:36.000000000","message":"Huh. So when we upgrade a container server from py2 to py3, the UTF-8 info we wrote down as bytes under py2 will automatically get decoded for us? How does it know the encoding??\n\n*shrug* probably just a \"reasonable\" default...","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"492fb589c11c44ead71a10adacef96144e25d943","unresolved":false,"context_lines":[{"line_number":555,"context_line":"            response \u003d dict(record)"},{"line_number":556,"context_line":"        else:"},{"line_number":557,"context_line":"            (name, created, size, content_type, etag) \u003d record[:5]"},{"line_number":558,"context_line":"            name_ \u003d name.decode(\u0027utf8\u0027) if six.PY2 else name"},{"line_number":559,"context_line":"            if content_type is None:"},{"line_number":560,"context_line":"                return {\u0027subdir\u0027: name_}"},{"line_number":561,"context_line":"            response \u003d {"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_674d0692","line":558,"in_reply_to":"3f79a3b5_6192d657","updated":"2018-11-20 21:03:49.000000000","message":"The question just how sqlite knows the encoding bothered me too. I can see how it knows what\u0027s decodable and what\u0027s not, the columns have types in the table. But the encoding?","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"}],"swift/obj/server.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f72b3e469cabc7ec61cf87bdb79161c3fba1621b","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        \"\"\""},{"line_number":538,"context_line":"        timeout_reader \u003d self._make_timeout_reader(footer_iter)"},{"line_number":539,"context_line":"        try:"},{"line_number":540,"context_line":"            footer_body \u003d b\u0027\u0027.join(iter(timeout_reader, b\u0027\u0027))"},{"line_number":541,"context_line":"        except ChunkReadError:"},{"line_number":542,"context_line":"            raise HTTPClientDisconnect()"},{"line_number":543,"context_line":"        except ChunkReadTimeout:"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_21b4ded2","line":540,"range":{"start_line":540,"start_character":35,"end_line":540,"end_character":60},"updated":"2018-11-20 20:48:36.000000000","message":"Side note: this pattern it *so annoying* when porting :-(\n\nIt makes tests just *hang* while we spin in an infinite loop because b\u0027\u0027 !\u003d \u0027\u0027","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"52d1fc748a3284620b89f06caebebe7d67ddd596","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        \"\"\""},{"line_number":538,"context_line":"        timeout_reader \u003d self._make_timeout_reader(footer_iter)"},{"line_number":539,"context_line":"        try:"},{"line_number":540,"context_line":"            footer_body \u003d b\u0027\u0027.join(iter(timeout_reader, b\u0027\u0027))"},{"line_number":541,"context_line":"        except ChunkReadError:"},{"line_number":542,"context_line":"            raise HTTPClientDisconnect()"},{"line_number":543,"context_line":"        except ChunkReadTimeout:"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_5cac5cea","line":540,"range":{"start_line":540,"start_character":35,"end_line":540,"end_character":60},"in_reply_to":"3f79a3b5_21b4ded2","updated":"2018-11-20 22:31:32.000000000","message":"Cleaned up another couple instances in https://review.openstack.org/#/c/619109/ -- and discovered that test_utils.py wasn\u0027t quite testing what it should\u0027ve been testing for the multipart mime doc generation and parsing...","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"}],"test/unit/__init__.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f72b3e469cabc7ec61cf87bdb79161c3fba1621b","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        c \u003d fd.read(1)"},{"line_number":410,"context_line":"        if not c:"},{"line_number":411,"context_line":"            raise ValueError(\"didn\u0027t get two CRLFs; just got %r\" % rv)"},{"line_number":412,"context_line":"        rv \u003d rv + c"},{"line_number":413,"context_line":"        if c \u003d\u003d b\u0027\\r\u0027 and lc !\u003d b\u0027\\n\u0027:"},{"line_number":414,"context_line":"            crlfs \u003d 0"},{"line_number":415,"context_line":"        if lc \u003d\u003d b\u0027\\r\u0027 and c \u003d\u003d b\u0027\\n\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_4141daa6","line":412,"updated":"2018-11-20 20:48:36.000000000","message":"Offtopic: I don\u0027t much like this -- maybe we could replace with something involving bytearray.extend?","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"52d1fc748a3284620b89f06caebebe7d67ddd596","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        c \u003d fd.read(1)"},{"line_number":410,"context_line":"        if not c:"},{"line_number":411,"context_line":"            raise ValueError(\"didn\u0027t get two CRLFs; just got %r\" % rv)"},{"line_number":412,"context_line":"        rv \u003d rv + c"},{"line_number":413,"context_line":"        if c \u003d\u003d b\u0027\\r\u0027 and lc !\u003d b\u0027\\n\u0027:"},{"line_number":414,"context_line":"            crlfs \u003d 0"},{"line_number":415,"context_line":"        if lc \u003d\u003d b\u0027\\r\u0027 and c \u003d\u003d b\u0027\\n\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_59d8eeeb","line":412,"in_reply_to":"3f79a3b5_4141daa6","updated":"2018-11-20 22:31:32.000000000","message":"I take it back, using a bytearray is apparently ~50% worse:\n\n $ python -m timeit -s \u0027x \u003d \"\"\u0027 \u0027for _ in range(1000): x +\u003d \"x\"\u0027\n 10000 loops, best of 3: 44.5 usec per loop\n $ python -m timeit -s \u0027x \u003d \"\"\u0027 \u0027for _ in range(10000): x +\u003d \"x\"\u0027\n 1000 loops, best of 3: 460 usec per loop\n $ python -m timeit -s \u0027x \u003d \"\"\u0027 \u0027for _ in range(100000): x +\u003d \"x\"\u0027\n 100 loops, best of 3: 5.01 msec per loop\n\n $ python -m timeit -s \u0027x \u003d bytearray()\u0027 \u0027for _ in range(1000): x.extend(\"x\")\u0027\n 10000 loops, best of 3: 69.9 usec per loop\n $ python -m timeit -s \u0027x \u003d bytearray()\u0027 \u0027for _ in range(10000): x.extend(\"x\")\u0027\n 1000 loops, best of 3: 705 usec per loop\n $ python -m timeit -s \u0027x \u003d bytearray()\u0027 \u0027for _ in range(100000): x.extend(\"x\")\u0027\n 100 loops, best of 3: 7.88 msec per loop","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"}],"test/unit/common/middleware/crypto/test_decrypter.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"44fcc2611d1066a33afb64358796ac1b8bd081b3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \u0027x-object-transient-sysmeta-crypto-meta-test\u0027:"},{"line_number":83,"context_line":"                bytes_to_wsgi(base64.b64encode(encrypt("},{"line_number":84,"context_line":"                    b\u0027encrypt me\u0027, object_key, FAKE_IV))) +"},{"line_number":85,"context_line":"                \u0027;swift_meta\u003d\u0027 + get_crypto_meta_header(other_crypto_meta),"},{"line_number":86,"context_line":"            \u0027x-object-sysmeta-container-update-override-etag\u0027:"},{"line_number":87,"context_line":"                encrypt_and_append_meta(\u0027encrypt me, too\u0027, cont_key),"},{"line_number":88,"context_line":"            \u0027x-object-sysmeta-test\u0027: \u0027do not encrypt me\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_2dce57b4","line":85,"updated":"2018-09-12 05:17:35.000000000","message":"It seems weird that these two don\u0027t use encrypt_and_append_meta ...","commit_id":"eeeefdec87e1fcc42e7a612bf3d621db149e4a55"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"44fcc2611d1066a33afb64358796ac1b8bd081b3","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            len(enc_body), plaintext_etag, data_key, body_key)"},{"line_number":250,"context_line":"        to_remove \u003d [k for k in hdrs if is_object_transient_sysmeta(k)]"},{"line_number":251,"context_line":"        for k in to_remove:"},{"line_number":252,"context_line":"            hdrs.pop(k)"},{"line_number":253,"context_line":"        hdrs[\u0027x-object-meta-test\u0027] \u003d \u0027unencrypted\u0027"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        self.app.register("}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_edbffff9","line":252,"updated":"2018-09-12 05:17:35.000000000","message":"Avoid mutating the dict as we\u0027re iterating through it.","commit_id":"eeeefdec87e1fcc42e7a612bf3d621db149e4a55"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f72b3e469cabc7ec61cf87bdb79161c3fba1621b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    if not isinstance(value, bytes):"},{"line_number":45,"context_line":"        value \u003d value.encode(\u0027ascii\u0027)"},{"line_number":46,"context_line":"    return \u0027%s; swift_meta\u003d%s\u0027 % ("},{"line_number":47,"context_line":"        base64.b64encode(encrypt(value, key, FAKE_IV)).decode(\u0027ascii\u0027),"},{"line_number":48,"context_line":"        get_crypto_meta_header(crypto_meta))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_4cdd91dc","line":47,"updated":"2018-11-20 20:48:36.000000000","message":"I wonder if we should only be doing this encoding/decoding on py3... are we getting too far from the real?","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"}],"test/unit/common/middleware/crypto/test_encryption.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f72b3e469cabc7ec61cf87bdb79161c3fba1621b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        if not isinstance(container_path, bytes):"},{"line_number":86,"context_line":"            container_path \u003d container_path.encode(\u0027utf8\u0027)"},{"line_number":87,"context_line":"        req \u003d Request.blank("},{"line_number":88,"context_line":"            container_path, method\u003d\u0027PUT\u0027,"},{"line_number":89,"context_line":"            headers\u003d{\u0027X-Storage-Policy\u0027: policy_name})"},{"line_number":90,"context_line":"        resp \u003d req.get_response(app)"},{"line_number":91,"context_line":"        self.assertEqual(\u0027201 Created\u0027, resp.status)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_4c27d1c9","line":88,"updated":"2018-11-20 20:48:36.000000000","message":"I wonder if I coulda just used str_to_wsgi or something...","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"52d1fc748a3284620b89f06caebebe7d67ddd596","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        if not isinstance(container_path, bytes):"},{"line_number":86,"context_line":"            container_path \u003d container_path.encode(\u0027utf8\u0027)"},{"line_number":87,"context_line":"        req \u003d Request.blank("},{"line_number":88,"context_line":"            container_path, method\u003d\u0027PUT\u0027,"},{"line_number":89,"context_line":"            headers\u003d{\u0027X-Storage-Policy\u0027: policy_name})"},{"line_number":90,"context_line":"        resp \u003d req.get_response(app)"},{"line_number":91,"context_line":"        self.assertEqual(\u0027201 Created\u0027, resp.status)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_fc7c4875","line":88,"in_reply_to":"3f79a3b5_4c27d1c9","updated":"2018-11-20 22:31:32.000000000","message":"Done in https://review.openstack.org/#/c/619109/","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"}],"test/unit/common/middleware/crypto/test_keymaster.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f72b3e469cabc7ec61cf87bdb79161c3fba1621b","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                for conf_val in ("},{"line_number":147,"context_line":"                        encoded_secret,"},{"line_number":148,"context_line":"                        encoded_secret.decode(\u0027ascii\u0027),"},{"line_number":149,"context_line":"                        encoded_secret[:30] + b\u0027\\n\u0027 + encoded_secret[30:]):"},{"line_number":150,"context_line":"                    try:"},{"line_number":151,"context_line":"                        app \u003d keymaster.KeyMaster("},{"line_number":152,"context_line":"                            self.swift, {\u0027encryption_root_secret\u0027: conf_val,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_475c8a19","line":149,"range":{"start_line":149,"start_character":24,"end_line":149,"end_character":73},"updated":"2018-11-20 20:48:36.000000000","message":"Might should have this case as unicode, too.","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"52d1fc748a3284620b89f06caebebe7d67ddd596","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                for conf_val in ("},{"line_number":147,"context_line":"                        encoded_secret,"},{"line_number":148,"context_line":"                        encoded_secret.decode(\u0027ascii\u0027),"},{"line_number":149,"context_line":"                        encoded_secret[:30] + b\u0027\\n\u0027 + encoded_secret[30:]):"},{"line_number":150,"context_line":"                    try:"},{"line_number":151,"context_line":"                        app \u003d keymaster.KeyMaster("},{"line_number":152,"context_line":"                            self.swift, {\u0027encryption_root_secret\u0027: conf_val,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_bc76d091","line":149,"range":{"start_line":149,"start_character":24,"end_line":149,"end_character":73},"in_reply_to":"3f79a3b5_475c8a19","updated":"2018-11-20 22:31:32.000000000","message":"Done in https://review.openstack.org/#/c/619109/","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f72b3e469cabc7ec61cf87bdb79161c3fba1621b","unresolved":false,"context_lines":[{"line_number":415,"context_line":"            self.assertIsInstance(enc_secret, bytes)"},{"line_number":416,"context_line":"            for conf_val in (enc_secret, enc_secret.decode(\u0027ascii\u0027),"},{"line_number":417,"context_line":"                             enc_secret[:30] + b\u0027\\n\u0027 + enc_secret[30:],"},{"line_number":418,"context_line":"                             enc_secret[:30] + b\u0027\\r\\n\u0027 + enc_secret[30:]):"},{"line_number":419,"context_line":"                mock_readconf.reset_mock()"},{"line_number":420,"context_line":"                mock_readconf.return_value \u003d {"},{"line_number":421,"context_line":"                    \u0027encryption_root_secret\u0027: conf_val}"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_077d326f","line":418,"updated":"2018-11-20 20:48:36.000000000","message":"Again, might want to check unicode-with-linebreaks","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"52d1fc748a3284620b89f06caebebe7d67ddd596","unresolved":false,"context_lines":[{"line_number":415,"context_line":"            self.assertIsInstance(enc_secret, bytes)"},{"line_number":416,"context_line":"            for conf_val in (enc_secret, enc_secret.decode(\u0027ascii\u0027),"},{"line_number":417,"context_line":"                             enc_secret[:30] + b\u0027\\n\u0027 + enc_secret[30:],"},{"line_number":418,"context_line":"                             enc_secret[:30] + b\u0027\\r\\n\u0027 + enc_secret[30:]):"},{"line_number":419,"context_line":"                mock_readconf.reset_mock()"},{"line_number":420,"context_line":"                mock_readconf.return_value \u003d {"},{"line_number":421,"context_line":"                    \u0027encryption_root_secret\u0027: conf_val}"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_dc794c81","line":418,"in_reply_to":"3f79a3b5_077d326f","updated":"2018-11-20 22:31:32.000000000","message":"Done in https://review.openstack.org/#/c/619109/","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f72b3e469cabc7ec61cf87bdb79161c3fba1621b","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    @mock.patch(\u0027swift.common.middleware.crypto.keymaster.readconf\u0027)"},{"line_number":450,"context_line":"    def test_root_secret_path_invalid_secret(self, mock_readconf):"},{"line_number":451,"context_line":"        for secret in (bytes(base64.b64encode(os.urandom(31))),  # too short"},{"line_number":452,"context_line":"                       base64.b64encode(os.urandom(31)).decode(\u0027ascii\u0027),"},{"line_number":453,"context_line":"                       u\u0027a\u0027 * 44 + u\u0027????\u0027, b\u0027a\u0027 * 44 + b\u0027????\u0027,  # not base64"},{"line_number":454,"context_line":"                       u\u0027a\u0027 * 45, b\u0027a\u0027 * 45,  # bad padding"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_e7791681","line":451,"range":{"start_line":451,"start_character":23,"end_line":451,"end_character":28},"updated":"2018-11-20 20:48:36.000000000","message":"nit: Don\u0027t strictly need the bytes","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"52d1fc748a3284620b89f06caebebe7d67ddd596","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    @mock.patch(\u0027swift.common.middleware.crypto.keymaster.readconf\u0027)"},{"line_number":450,"context_line":"    def test_root_secret_path_invalid_secret(self, mock_readconf):"},{"line_number":451,"context_line":"        for secret in (bytes(base64.b64encode(os.urandom(31))),  # too short"},{"line_number":452,"context_line":"                       base64.b64encode(os.urandom(31)).decode(\u0027ascii\u0027),"},{"line_number":453,"context_line":"                       u\u0027a\u0027 * 44 + u\u0027????\u0027, b\u0027a\u0027 * 44 + b\u0027????\u0027,  # not base64"},{"line_number":454,"context_line":"                       u\u0027a\u0027 * 45, b\u0027a\u0027 * 45,  # bad padding"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_7c903898","line":451,"range":{"start_line":451,"start_character":23,"end_line":451,"end_character":28},"in_reply_to":"3f79a3b5_e7791681","updated":"2018-11-20 22:31:32.000000000","message":"Done in https://review.openstack.org/#/c/619109/","commit_id":"37b814657eaa779f984852f2fc048751b9a73230"}]}
