)]}'
{".zuul.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"a2ce9e232a063efaf8e90061759de0fcd5b244e6","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    vars:"},{"line_number":268,"context_line":"      previous_swift_version: origin/stable/queens"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"- project:"},{"line_number":271,"context_line":"    templates:"},{"line_number":272,"context_line":"      - publish-openstack-docs-pti"},{"line_number":273,"context_line":"      - periodic-stable-jobs"},{"line_number":274,"context_line":"      - check-requirements"},{"line_number":275,"context_line":"      - release-notes-jobs-python3"},{"line_number":276,"context_line":"    check:"},{"line_number":277,"context_line":"      jobs:"},{"line_number":278,"context_line":"        - swift-tox-py27:"},{"line_number":279,"context_line":"            irrelevant-files:"},{"line_number":280,"context_line":"              - ^(api-ref|doc|releasenotes)/.*$"},{"line_number":281,"context_line":"              - ^test/(functional|probe)/.*$"},{"line_number":282,"context_line":"        - swift-tox-py35:"},{"line_number":283,"context_line":"            irrelevant-files:"},{"line_number":284,"context_line":"              - ^(api-ref|doc|releasenotes)/.*$"},{"line_number":285,"context_line":"              - ^test/(functional|probe)/.*$"},{"line_number":286,"context_line":"        - swift-tox-py36:"},{"line_number":287,"context_line":"            irrelevant-files:"},{"line_number":288,"context_line":"              - ^(api-ref|doc|releasenotes)/.*$"},{"line_number":289,"context_line":"              - ^test/(functional|probe)/.*$"},{"line_number":290,"context_line":"            voting: false"},{"line_number":291,"context_line":"        - swift-tox-func:"},{"line_number":292,"context_line":"            irrelevant-files:"},{"line_number":293,"context_line":"              - ^(api-ref|doc|releasenotes)/.*$"},{"line_number":294,"context_line":"              - ^test/probe/.*$"},{"line_number":295,"context_line":"              - ^(.gitreview|.mailmap|AUTHORS|CHANGELOG)$"},{"line_number":296,"context_line":"        - swift-tox-func-encryption:"},{"line_number":297,"context_line":"            irrelevant-files:"},{"line_number":298,"context_line":"              - ^(api-ref|doc|releasenotes)/.*$"},{"line_number":299,"context_line":"              - ^test/probe/.*$"},{"line_number":300,"context_line":"              - ^(.gitreview|.mailmap|AUTHORS|CHANGELOG)$"},{"line_number":301,"context_line":"        - swift-tox-func-domain-remap-staticweb:"},{"line_number":302,"context_line":"            irrelevant-files:"},{"line_number":303,"context_line":"              - ^(api-ref|doc|releasenotes)/.*$"},{"line_number":304,"context_line":"              - ^test/probe/.*$"},{"line_number":305,"context_line":"              - ^(.gitreview|.mailmap|AUTHORS|CHANGELOG)$"},{"line_number":306,"context_line":"        - swift-tox-func-ec:"},{"line_number":307,"context_line":"            irrelevant-files:"},{"line_number":308,"context_line":"              - ^(api-ref|doc|releasenotes)/.*$"},{"line_number":309,"context_line":"              - ^test/probe/.*$"},{"line_number":310,"context_line":"              - ^(.gitreview|.mailmap|AUTHORS|CHANGELOG)$"},{"line_number":311,"context_line":"        - swift-tox-func-s3api:"},{"line_number":312,"context_line":"            irrelevant-files:"},{"line_number":313,"context_line":"              - ^(api-ref|doc|releasenotes)/.*$"},{"line_number":314,"context_line":"              - ^test/probe/.*$"},{"line_number":315,"context_line":"              - ^(.gitreview|.mailmap|AUTHORS|CHANGELOG)$"},{"line_number":316,"context_line":"        - swift-tox-func-s3api-ceph-s3tests-tempauth:"},{"line_number":317,"context_line":"            irrelevant-files:"},{"line_number":318,"context_line":"              - ^(api-ref|releasenotes)/.*$"},{"line_number":319,"context_line":"              - ^test/probe/.*$"},{"line_number":320,"context_line":"              - ^(.gitreview|.mailmap|AUTHORS|CHANGELOG)$"},{"line_number":321,"context_line":"        - swift-probetests-centos-7:"},{"line_number":322,"context_line":"            irrelevant-files:"},{"line_number":323,"context_line":"              - ^(api-ref|releasenotes)/.*$"},{"line_number":324,"context_line":"              # Keep doc/saio -- we use those sample configs in the saio playbooks"},{"line_number":325,"context_line":"              - ^doc/(requirements.txt|(manpages|s3api|source)/.*)$"},{"line_number":326,"context_line":"              - ^test/(unit|functional)/.*$"},{"line_number":327,"context_line":"              - ^(.gitreview|.mailmap|AUTHORS|CHANGELOG)$"},{"line_number":328,"context_line":"        - swift-dsvm-functional:"},{"line_number":329,"context_line":"            irrelevant-files:"},{"line_number":330,"context_line":"              - ^(api-ref|doc|releasenotes)/.*$"},{"line_number":331,"context_line":"              - ^test/probe/.*$"},{"line_number":332,"context_line":"              - ^(.gitreview|.mailmap|AUTHORS|CHANGELOG)$"},{"line_number":333,"context_line":"        - swift-dsvm-functional-ipv6:"},{"line_number":334,"context_line":"            irrelevant-files:"},{"line_number":335,"context_line":"              - ^(api-ref|doc|releasenotes)/.*$"},{"line_number":336,"context_line":"              - ^test/probe/.*$"},{"line_number":337,"context_line":"              - ^(.gitreview|.mailmap|AUTHORS|CHANGELOG)$"},{"line_number":338,"context_line":"        - openstack-tox-lower-constraints:"},{"line_number":339,"context_line":"            irrelevant-files:"},{"line_number":340,"context_line":"              - ^(api-ref|doc|releasenotes)/.*$"},{"line_number":341,"context_line":"              - ^test/(functional|probe)/.*$"},{"line_number":342,"context_line":"        - openstack-tox-pep8:"},{"line_number":343,"context_line":"            irrelevant-files:"},{"line_number":344,"context_line":"              - ^(api-ref|doc|etc|examples|releasenotes)/.*$"},{"line_number":345,"context_line":"        - swift-multinode-functional:"},{"line_number":346,"context_line":"            irrelevant-files:"},{"line_number":347,"context_line":"              - ^(api-ref|doc|releasenotes)/.*$"},{"line_number":348,"context_line":"              - ^test/probe/.*$"},{"line_number":349,"context_line":"              - ^(.gitreview|.mailmap|AUTHORS|CHANGELOG)$"},{"line_number":350,"context_line":"    gate:"},{"line_number":351,"context_line":"      jobs:"},{"line_number":352,"context_line":"        # For gate jobs, err towards running more jobs (so, generally avoid"},{"line_number":353,"context_line":"        # using irrelevant-files). Exceptions should mainly be made for"},{"line_number":354,"context_line":"        # long-running jobs, like probetests or (once they move to"},{"line_number":355,"context_line":"        # in-tree definitions) dsvm jobs."},{"line_number":356,"context_line":"        - swift-tox-py27"},{"line_number":357,"context_line":"        - swift-tox-py35"},{"line_number":358,"context_line":"        - swift-tox-func"},{"line_number":359,"context_line":"        - swift-tox-func-encryption"},{"line_number":360,"context_line":"        - swift-tox-func-domain-remap-staticweb"},{"line_number":361,"context_line":"        - swift-tox-func-ec"},{"line_number":362,"context_line":"        - swift-tox-func-s3api"},{"line_number":363,"context_line":"        - swift-probetests-centos-7:"},{"line_number":364,"context_line":"            irrelevant-files:"},{"line_number":365,"context_line":"              - ^(api-ref|releasenotes)/.*$"},{"line_number":366,"context_line":"              # Keep doc/saio -- we use those sample configs in the saio playbooks"},{"line_number":367,"context_line":"              - ^doc/(requirements.txt|(manpages|s3api|source)/.*)$"},{"line_number":368,"context_line":"              - ^test/(unit|functional)/.*$"},{"line_number":369,"context_line":"              - ^(.gitreview|.mailmap|AUTHORS|CHANGELOG)$"},{"line_number":370,"context_line":"        - swift-dsvm-functional:"},{"line_number":371,"context_line":"            irrelevant-files:"},{"line_number":372,"context_line":"              - ^(api-ref|doc|releasenotes)/.*$"},{"line_number":373,"context_line":"              - ^test/probe/.*$"},{"line_number":374,"context_line":"              - ^(.gitreview|.mailmap|AUTHORS|CHANGELOG)$"},{"line_number":375,"context_line":"        - swift-dsvm-functional-ipv6:"},{"line_number":376,"context_line":"            irrelevant-files:"},{"line_number":377,"context_line":"              - ^(api-ref|doc|releasenotes)/.*$"},{"line_number":378,"context_line":"              - ^test/probe/.*$"},{"line_number":379,"context_line":"              - ^(.gitreview|.mailmap|AUTHORS|CHANGELOG)$"},{"line_number":380,"context_line":"        - openstack-tox-lower-constraints"},{"line_number":381,"context_line":"        - openstack-tox-pep8:"},{"line_number":382,"context_line":"            irrelevant-files:"},{"line_number":383,"context_line":"              - ^(api-ref|doc|etc|examples|releasenotes)/.*$"},{"line_number":384,"context_line":"    experimental:"},{"line_number":385,"context_line":"      jobs:"},{"line_number":386,"context_line":"        - swift-tox-py27-centos-7"},{"line_number":387,"context_line":"        - swift-tox-func-centos-7"},{"line_number":388,"context_line":"        - swift-tox-func-encryption-centos-7"},{"line_number":389,"context_line":"        - swift-tox-func-ec-centos-7"},{"line_number":390,"context_line":"        - swift-multinode-rolling-upgrade-stable-1"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    post:"},{"line_number":393,"context_line":"      jobs:"},{"line_number":394,"context_line":"        - openstack-tox-cover"},{"line_number":395,"context_line":"        - publish-openstack-python-branch-tarball"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"3f79a3b5_e0b58b7f","line":395,"range":{"start_line":270,"start_character":2,"end_line":395,"end_character":0},"updated":"2018-09-14 16:24:53.000000000","message":"Job swift-multinode-functional not defined","commit_id":"3f077b300bdd2a1b49797507e9bbef0ee24f2357"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"7604b5874246be8ad17bd4ed7066b5307d7606b8","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    description: |"},{"line_number":183,"context_line":"      Setup a SAIO dev environment and run ceph-s3tests"},{"line_number":184,"context_line":"    pre-run:"},{"line_number":185,"context_line":"      - tools/playbooks/saio_single_node_setup/install_dependencies.yaml"},{"line_number":186,"context_line":"      - tools/playbooks/saio_single_node_setup/setup_saio.yaml"},{"line_number":187,"context_line":"      - tools/playbooks/saio_single_node_setup/make_rings.yaml"},{"line_number":188,"context_line":"    run: tools/playbooks/ceph-s3tests/run.yaml"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"3f79a3b5_6600ac03","line":185,"range":{"start_line":185,"start_character":24,"end_line":185,"end_character":46},"updated":"2018-09-15 05:27:16.000000000","message":"This should be \u0027common\u0027 now, no?","commit_id":"fe85628f8679a4eb0af51e56df846c06491e4bcf"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"31e35a070556e36db2cfe968c6977ca824847b27","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    description: |"},{"line_number":183,"context_line":"      Setup a SAIO dev environment and run ceph-s3tests"},{"line_number":184,"context_line":"    pre-run:"},{"line_number":185,"context_line":"      - tools/playbooks/saio_single_node_setup/install_dependencies.yaml"},{"line_number":186,"context_line":"      - tools/playbooks/saio_single_node_setup/setup_saio.yaml"},{"line_number":187,"context_line":"      - tools/playbooks/saio_single_node_setup/make_rings.yaml"},{"line_number":188,"context_line":"    run: tools/playbooks/ceph-s3tests/run.yaml"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"3f79a3b5_392c12ab","line":185,"range":{"start_line":185,"start_character":24,"end_line":185,"end_character":46},"in_reply_to":"3f79a3b5_6600ac03","updated":"2018-09-15 13:15:38.000000000","message":"yep! changing now","commit_id":"fe85628f8679a4eb0af51e56df846c06491e4bcf"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"7604b5874246be8ad17bd4ed7066b5307d7606b8","unresolved":false,"context_lines":[{"line_number":253,"context_line":"      Build a 4 node swift cluster and run functional tests"},{"line_number":254,"context_line":"    timeout: 3600"},{"line_number":255,"context_line":"    pre-run:"},{"line_number":256,"context_line":"      - tools/playbooks/common/pre.yaml"},{"line_number":257,"context_line":"      - tools/playbooks/common/install_dependencies.yaml"},{"line_number":258,"context_line":"      - tools/playbooks/multinode_setup/configure_loopback.yaml"},{"line_number":259,"context_line":"      - tools/playbooks/multinode_setup/common_config.yaml"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"3f79a3b5_476b2a84","line":256,"updated":"2018-09-15 05:27:16.000000000","message":"Very strange... it\u0027s like it knows it\u0027s something that *should* be run, but then it doesn\u0027t actually do anything: http://logs.openstack.org/86/601686/34/check/swift-multinode-rolling-upgrade/1711f70/job-output.txt.gz#_2018-09-14_23_18_54_187909","commit_id":"fe85628f8679a4eb0af51e56df846c06491e4bcf"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"31e35a070556e36db2cfe968c6977ca824847b27","unresolved":false,"context_lines":[{"line_number":253,"context_line":"      Build a 4 node swift cluster and run functional tests"},{"line_number":254,"context_line":"    timeout: 3600"},{"line_number":255,"context_line":"    pre-run:"},{"line_number":256,"context_line":"      - tools/playbooks/common/pre.yaml"},{"line_number":257,"context_line":"      - tools/playbooks/common/install_dependencies.yaml"},{"line_number":258,"context_line":"      - tools/playbooks/multinode_setup/configure_loopback.yaml"},{"line_number":259,"context_line":"      - tools/playbooks/multinode_setup/common_config.yaml"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"3f79a3b5_991d2679","line":256,"in_reply_to":"3f79a3b5_476b2a84","updated":"2018-09-15 13:15:38.000000000","message":"mm...i\u0027m assuming it has to do with the \u0027when\u0027 in the file","commit_id":"fe85628f8679a4eb0af51e56df846c06491e4bcf"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"020c062e993f8b2356557c52f156c9edc0cdd7d2","unresolved":false,"context_lines":[{"line_number":258,"context_line":"      - tools/playbooks/multinode_setup/common_config.yaml"},{"line_number":259,"context_line":"      - tools/playbooks/multinode_setup/make_rings.yaml"},{"line_number":260,"context_line":"    run: tools/playbooks/multinode_setup/run.yaml"},{"line_number":261,"context_line":"    post-run: tools/playbooks/dsvm/post.yaml"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"- job:"},{"line_number":264,"context_line":"    name: swift-multinode-rolling-upgrade-stable-1"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_8fdf1837","line":261,"range":{"start_line":261,"start_character":14,"end_line":261,"end_character":44},"updated":"2018-09-15 17:12:23.000000000","message":"This doesn\u0027t seem to capture the logs we actually care about...","commit_id":"e07155b0ff9d086dc9e49e3512b2808a0ad36ba3"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"fc9aa86c29732d3ed3f7012675edbe8f9d86fbd0","unresolved":false,"context_lines":[{"line_number":258,"context_line":"      - tools/playbooks/multinode_setup/common_config.yaml"},{"line_number":259,"context_line":"      - tools/playbooks/multinode_setup/make_rings.yaml"},{"line_number":260,"context_line":"    run: tools/playbooks/multinode_setup/run.yaml"},{"line_number":261,"context_line":"    post-run: tools/playbooks/dsvm/post.yaml"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"- job:"},{"line_number":264,"context_line":"    name: swift-multinode-rolling-upgrade-stable-1"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3f79a3b5_d28373ca","line":261,"range":{"start_line":261,"start_character":14,"end_line":261,"end_character":44},"in_reply_to":"3f79a3b5_8fdf1837","updated":"2018-09-15 21:15:14.000000000","message":"agree, just wanted to experiment with dsvm/post but it gets us no logs. using probetests/post is only slightly better, I will still need to fix fetching the storage nodes logs as they are currently overwriting each other, but i\u0027m leaning leaving that for a follow-on patch","commit_id":"e07155b0ff9d086dc9e49e3512b2808a0ad36ba3"},{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"3e7068baf58fdc7642979e46ff57a13058b21d13","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    post-run: tools/playbooks/probetests/post.yaml"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"- job:"},{"line_number":264,"context_line":"    name: swift-multinode-rolling-upgrade-stable-1"},{"line_number":265,"context_line":"    parent: swift-multinode-rolling-upgrade"},{"line_number":266,"context_line":"    vars:"},{"line_number":267,"context_line":"      previous_swift_version: origin/stable/queens"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"3f79a3b5_6d1f2409","line":264,"updated":"2018-09-15 23:19:44.000000000","message":"I\u0027d like this to be \"swift-multinode-rolling-upgrade-queens\".\n\nIf we have to have the version in the job definition, then let\u0027s name the job according to the version defined","commit_id":"1ea2399f7c217112bb8aee418c0399fe80d45181"},{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"eb773c5f20f15c3d9d11b47a183a33fa28d3c825","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    parent: multinode"},{"line_number":250,"context_line":"    nodeset: swift-five-nodes"},{"line_number":251,"context_line":"    description: |"},{"line_number":252,"context_line":"      Build a 4 node swift cluster and run functional tests"},{"line_number":253,"context_line":"    timeout: 3600"},{"line_number":254,"context_line":"    pre-run:"},{"line_number":255,"context_line":"      - tools/playbooks/multinode_setup/pre.yaml"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3f79a3b5_d3ffd931","line":252,"updated":"2018-09-17 23:34:32.000000000","message":"nit: add \"on a fifth node\"","commit_id":"5d70396247a81cbaf6aaf114a5b4dcfb7ace7eb9"}],"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"020c062e993f8b2356557c52f156c9edc0cdd7d2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"add objects to the cluster prior to upgrading and then try"},{"line_number":19,"context_line":"to read those objects after the upgrade. It should also be"},{"line_number":20,"context_line":"noted that the \u0027upgrade\u0027 currently only means a new"},{"line_number":21,"context_line":"\u0027git checkout\u0027 the configuration files are not being updated."},{"line_number":22,"context_line":"A future patch should fix that too."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: If8e09a082fc024257a98cf332de9a36a18d2adc5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":39,"id":"3f79a3b5_efb9eceb","line":21,"range":{"start_line":21,"start_character":15,"end_line":21,"end_character":60},"updated":"2018-09-15 17:12:23.000000000","message":"So the configs are coming from... previous release? Or master?","commit_id":"e07155b0ff9d086dc9e49e3512b2808a0ad36ba3"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"fc9aa86c29732d3ed3f7012675edbe8f9d86fbd0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"add objects to the cluster prior to upgrading and then try"},{"line_number":19,"context_line":"to read those objects after the upgrade. It should also be"},{"line_number":20,"context_line":"noted that the \u0027upgrade\u0027 currently only means a new"},{"line_number":21,"context_line":"\u0027git checkout\u0027 the configuration files are not being updated."},{"line_number":22,"context_line":"A future patch should fix that too."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: If8e09a082fc024257a98cf332de9a36a18d2adc5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":39,"id":"3f79a3b5_12632b43","line":21,"range":{"start_line":21,"start_character":15,"end_line":21,"end_character":60},"in_reply_to":"3f79a3b5_efb9eceb","updated":"2018-09-15 21:15:14.000000000","message":"it was coming from master which made no sense, I changed it so that it comes from the previous release. This way we are testing an upgrade but without a config change. In the future I\u0027d like to add a variable that would allow us to test with or without the config update depending (could be a experimental job).","commit_id":"e07155b0ff9d086dc9e49e3512b2808a0ad36ba3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"e1b9bcdbc7e7ac0b081d81a35bbd4b9aa101e16c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"It currently configures 5 nodes: test-runner, proxy,"},{"line_number":11,"context_line":"account, container and object. It starts by checkout out"},{"line_number":12,"context_line":"the latest release and then \u0027upgrades\u0027 the storage nodes"},{"line_number":13,"context_line":"to the current patch under test. That means that it will"},{"line_number":14,"context_line":"the test-runner and the proxy are still running the latest"},{"line_number":15,"context_line":"release."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Future work would include a new set of tests where it will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":41,"id":"3f79a3b5_3c937550","line":14,"range":{"start_line":13,"start_character":52,"end_line":14,"end_character":15},"updated":"2018-09-18 11:13:38.000000000","message":"will leave the test-runner","commit_id":"5d70396247a81cbaf6aaf114a5b4dcfb7ace7eb9"}],"tools/playbooks/common/install_dependencies.yaml":[{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"eb773c5f20f15c3d9d11b47a183a33fa28d3c825","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    - name: install python modules with pip"},{"line_number":27,"context_line":"      pip: name\u003d{{ item }} state\u003dpresent extra_args\u003d\u0027--upgrade\u0027"},{"line_number":28,"context_line":"      with_items:"},{"line_number":29,"context_line":"        - crudini"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3f79a3b5_13ea3173","line":29,"updated":"2018-09-17 23:34:32.000000000","message":"TIL: crudini\n\nthat looks *really* useful","commit_id":"5d70396247a81cbaf6aaf114a5b4dcfb7ace7eb9"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"9215a418d19f153bcce9a534fa1317e1b39b4488","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    - name: install python modules with pip"},{"line_number":27,"context_line":"      pip: name\u003d{{ item }} state\u003dpresent extra_args\u003d\u0027--upgrade\u0027"},{"line_number":28,"context_line":"      with_items:"},{"line_number":29,"context_line":"        - crudini"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3f79a3b5_d66587e2","line":29,"in_reply_to":"3f79a3b5_13ea3173","updated":"2018-09-17 23:54:34.000000000","message":"FWIW, I think we could also do something like\n\n- ini_file:\n    path: /etc/swift/proxy-server.conf\n    section: DEFAULT\n    option: bind_ip\n    value: {{ hostvars[\u0027proxy1\u0027].nodepool.public_ipv4 }}\n- ini_file:\n    path: /etc/swift/proxy-server.conf\n    section: DEFAULT\n    option: user\n    value: {{ ansible_user_id }}\n\nif we want.","commit_id":"5d70396247a81cbaf6aaf114a5b4dcfb7ace7eb9"}],"tools/playbooks/multinode_setup/common_config.yaml":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"9c5fc7c020af7c4403136820738f29cecdd8b568","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - name: create /var/run/swift"},{"line_number":18,"context_line":"      file: \u003e"},{"line_number":19,"context_line":"        path\u003d/var/run/swift"},{"line_number":20,"context_line":"        owner\u003d{{ ansible_user_id }}"},{"line_number":21,"context_line":"        group\u003d{{ ansible_user_gid }}"},{"line_number":22,"context_line":"        state\u003ddirectory"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: create /var/cache/swift"},{"line_number":25,"context_line":"      file: \u003e"},{"line_number":26,"context_line":"        path\u003d/var/cache/swift"},{"line_number":27,"context_line":"        owner\u003d{{ ansible_user_id }}"},{"line_number":28,"context_line":"        group\u003d{{ ansible_user_gid }}"},{"line_number":29,"context_line":"        state\u003ddirectory"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    - name: create rc.local from template"},{"line_number":32,"context_line":"      template: src\u003drc.local.j2 dest\u003d/etc/rc.d/rc.local owner\u003droot group\u003droot mode\u003d0755"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_43601436","line":29,"range":{"start_line":19,"start_character":8,"end_line":29,"end_character":23},"updated":"2018-09-14 03:44:07.000000000","message":"A second variation of writing file options, we should have 1 to make standised.","commit_id":"f4b9d22c24e17ab1749f86ccbd35a00139446742"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"07e501a5a2e7f0f3ce698ff4def7f945039f7f25","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - name: create /var/run/swift"},{"line_number":18,"context_line":"      file: \u003e"},{"line_number":19,"context_line":"        path\u003d/var/run/swift"},{"line_number":20,"context_line":"        owner\u003d{{ ansible_user_id }}"},{"line_number":21,"context_line":"        group\u003d{{ ansible_user_gid }}"},{"line_number":22,"context_line":"        state\u003ddirectory"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: create /var/cache/swift"},{"line_number":25,"context_line":"      file: \u003e"},{"line_number":26,"context_line":"        path\u003d/var/cache/swift"},{"line_number":27,"context_line":"        owner\u003d{{ ansible_user_id }}"},{"line_number":28,"context_line":"        group\u003d{{ ansible_user_gid }}"},{"line_number":29,"context_line":"        state\u003ddirectory"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    - name: create rc.local from template"},{"line_number":32,"context_line":"      template: src\u003drc.local.j2 dest\u003d/etc/rc.d/rc.local owner\u003droot group\u003droot mode\u003d0755"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_1fdc7d16","line":29,"range":{"start_line":19,"start_character":8,"end_line":29,"end_character":23},"in_reply_to":"3f79a3b5_43601436","updated":"2018-09-17 16:58:01.000000000","message":"Done","commit_id":"f4b9d22c24e17ab1749f86ccbd35a00139446742"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"9c5fc7c020af7c4403136820738f29cecdd8b568","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            mode\u003d\"g+w\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    - name: restart rsyslog"},{"line_number":54,"context_line":"      service: name\u003drsyslog state\u003drestarted enabled\u003dyes"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    - name: clean up /etc/swift directory"},{"line_number":57,"context_line":"      file: path\u003d/etc/swift state\u003dabsent"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_035a1c82","line":54,"updated":"2018-09-14 03:44:07.000000000","message":"I\u0027d usually use a handler to trigger a restart. But seeing as I\u0027m not 100% sure of how zuul uses anible there may be a chance that any handlers wont run before we need them, so this is fine.","commit_id":"f4b9d22c24e17ab1749f86ccbd35a00139446742"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"07e501a5a2e7f0f3ce698ff4def7f945039f7f25","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            mode\u003d\"g+w\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    - name: restart rsyslog"},{"line_number":54,"context_line":"      service: name\u003drsyslog state\u003drestarted enabled\u003dyes"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    - name: clean up /etc/swift directory"},{"line_number":57,"context_line":"      file: path\u003d/etc/swift state\u003dabsent"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_1f055d7a","line":54,"in_reply_to":"3f79a3b5_035a1c82","updated":"2018-09-17 16:58:01.000000000","message":"@Matt, there\u0027s in fact a much larger re-write that I\u0027ve been told we should make in terms of using roles appropriately. So given the time I think it is something we should revisit in the future. It should allow us to reuse code more instead of having to copy and paste tasks all over the place.","commit_id":"f4b9d22c24e17ab1749f86ccbd35a00139446742"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"9c5fc7c020af7c4403136820738f29cecdd8b568","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      file: path\u003d/etc/swift state\u003dabsent"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    - name: create /etc/swift directory"},{"line_number":60,"context_line":"      file: path\u003d/etc/swift state\u003ddirectory owner\u003d{{ ansible_user_id }} group\u003d{{ ansible_user_gid }}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"- hosts: proxy"},{"line_number":63,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_8374ecff","line":60,"range":{"start_line":60,"start_character":12,"end_line":60,"end_character":100},"updated":"2018-09-14 03:44:07.000000000","message":"This is the third variation of writing the file options. We should standise on 1:\n\n  - name: create /etc/swift directory\n    file: path\u003d/etc/swift\n          state: directory\n          owner\u003d{{ ansible_user_id }}\n          group\u003d{{ ansible_group_id }}\n\nPersonally I feel the simple `file: \u003copts on each line\u003e` looks better then adding a \u0027\u003e\u0027 or \u0027|\u0027 (damn yaml).","commit_id":"f4b9d22c24e17ab1749f86ccbd35a00139446742"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"07e501a5a2e7f0f3ce698ff4def7f945039f7f25","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      file: path\u003d/etc/swift state\u003dabsent"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    - name: create /etc/swift directory"},{"line_number":60,"context_line":"      file: path\u003d/etc/swift state\u003ddirectory owner\u003d{{ ansible_user_id }} group\u003d{{ ansible_user_gid }}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"- hosts: proxy"},{"line_number":63,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_3f0a9989","line":60,"range":{"start_line":60,"start_character":12,"end_line":60,"end_character":100},"in_reply_to":"3f79a3b5_8374ecff","updated":"2018-09-17 16:58:01.000000000","message":"Done","commit_id":"f4b9d22c24e17ab1749f86ccbd35a00139446742"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"9c5fc7c020af7c4403136820738f29cecdd8b568","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        cmd: |"},{"line_number":74,"context_line":"          crudini --set /etc/swift/proxy-server.conf DEFAULT bind_ip {{ hostvars[\u0027proxy1\u0027].nodepool.public_ipv4 }}"},{"line_number":75,"context_line":"          crudini --set /etc/swift/proxy-server.conf DEFAULT user {{ ansible_user_id }}"},{"line_number":76,"context_line":"        executable: /bin/bash"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- hosts: account"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_e3aa8018","line":76,"updated":"2018-09-14 03:44:07.000000000","message":"Is this really common config?\n\nAlso, because we are setting up seperate nodes for a swift cluster, should we be using a /etc/swift/memcache.conf so internal_clients on non-proxy nodes now where the memcache ring is?\n\nedit: so on further reading we\u0027re only running swift-init main so there shouldn\u0027t be anything else that uses internal-clients. But something to think about if/when we expand testing to be more complicated. Ie. with rolling upgrade testing etc.","commit_id":"f4b9d22c24e17ab1749f86ccbd35a00139446742"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"07e501a5a2e7f0f3ce698ff4def7f945039f7f25","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        cmd: |"},{"line_number":74,"context_line":"          crudini --set /etc/swift/proxy-server.conf DEFAULT bind_ip {{ hostvars[\u0027proxy1\u0027].nodepool.public_ipv4 }}"},{"line_number":75,"context_line":"          crudini --set /etc/swift/proxy-server.conf DEFAULT user {{ ansible_user_id }}"},{"line_number":76,"context_line":"        executable: /bin/bash"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- hosts: account"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_7feb31a3","line":76,"in_reply_to":"3f79a3b5_e3aa8018","updated":"2018-09-17 16:58:01.000000000","message":"agree. I thought since for now as we are only starting \u0027main\u0027 services we did not have to provide config for memcache, but we can do that later.","commit_id":"f4b9d22c24e17ab1749f86ccbd35a00139446742"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"9c5fc7c020af7c4403136820738f29cecdd8b568","unresolved":false,"context_lines":[{"line_number":122,"context_line":"      command: cp -r {{ zuul.project.src_dir }}/doc/saio/swift/swift.conf /etc/swift"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    - name: set correct ownership of /etc/swift"},{"line_number":125,"context_line":"      file: path\u003d/etc/swift owner\u003d{{ ansible_user_id }} group\u003d{{ ansible_user_gid }} recurse\u003dyes"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"- hosts: test-runner"},{"line_number":128,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_236e3800","line":125,"updated":"2018-09-14 03:44:07.000000000","message":"Maybe template and place a memcache.conf?","commit_id":"f4b9d22c24e17ab1749f86ccbd35a00139446742"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"07e501a5a2e7f0f3ce698ff4def7f945039f7f25","unresolved":false,"context_lines":[{"line_number":122,"context_line":"      command: cp -r {{ zuul.project.src_dir }}/doc/saio/swift/swift.conf /etc/swift"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    - name: set correct ownership of /etc/swift"},{"line_number":125,"context_line":"      file: path\u003d/etc/swift owner\u003d{{ ansible_user_id }} group\u003d{{ ansible_user_gid }} recurse\u003dyes"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"- hosts: test-runner"},{"line_number":128,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_9f3ded2d","line":125,"in_reply_to":"3f79a3b5_236e3800","updated":"2018-09-17 16:58:01.000000000","message":"i\u0027d like to leave this as a TODO for future changes as it becomes needed","commit_id":"f4b9d22c24e17ab1749f86ccbd35a00139446742"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"9c5fc7c020af7c4403136820738f29cecdd8b568","unresolved":false,"context_lines":[{"line_number":127,"context_line":"- hosts: test-runner"},{"line_number":128,"context_line":"  tasks:"},{"line_number":129,"context_line":"    - name: copy the SAIO scripts for resetting the environment"},{"line_number":130,"context_line":"      command: cp -r {{ zuul.project.src_dir }}/doc/saio/bin /home/{{ ansible_ssh_user }}/bin creates\u003d/home/{{ ansible_ssh_user }}/bin"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    - name: set the correct file mode for swift scripts"},{"line_number":133,"context_line":"      file: dest\u003d/home/{{ ansible_ssh_user }}/bin mode\u003d0777 recurse\u003dyes"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_0339bcf0","line":130,"updated":"2018-09-14 03:44:07.000000000","message":"I haven\u0027t looked further into the ansible yet. but wont running the resetswift kinda fail because it\u0027ll only reformat the xfs loopback on the local machine, not on all the nodes?\n\nOr do we need to turn resetswift into an ansible playbook or something?","commit_id":"f4b9d22c24e17ab1749f86ccbd35a00139446742"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"07e501a5a2e7f0f3ce698ff4def7f945039f7f25","unresolved":false,"context_lines":[{"line_number":127,"context_line":"- hosts: test-runner"},{"line_number":128,"context_line":"  tasks:"},{"line_number":129,"context_line":"    - name: copy the SAIO scripts for resetting the environment"},{"line_number":130,"context_line":"      command: cp -r {{ zuul.project.src_dir }}/doc/saio/bin /home/{{ ansible_ssh_user }}/bin creates\u003d/home/{{ ansible_ssh_user }}/bin"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    - name: set the correct file mode for swift scripts"},{"line_number":133,"context_line":"      file: dest\u003d/home/{{ ansible_ssh_user }}/bin mode\u003d0777 recurse\u003dyes"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_1f131dba","line":130,"in_reply_to":"3f79a3b5_0339bcf0","updated":"2018-09-17 16:58:01.000000000","message":"yep, these scripts were not needed at all. I\u0027ve remove them in latest patchset.","commit_id":"f4b9d22c24e17ab1749f86ccbd35a00139446742"},{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"eb773c5f20f15c3d9d11b47a183a33fa28d3c825","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - name: create /var/run/swift"},{"line_number":18,"context_line":"      file:"},{"line_number":19,"context_line":"        path: \u0027/var/run/swift\u0027 "},{"line_number":20,"context_line":"        owner: \u0027{{ ansible_user_id }}\u0027"},{"line_number":21,"context_line":"        group: \u0027{{ ansible_user_gid }}\u0027"},{"line_number":22,"context_line":"        state: directory"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3f79a3b5_f3e455aa","line":19,"updated":"2018-09-17 23:34:32.000000000","message":"nit: space at end of line","commit_id":"5d70396247a81cbaf6aaf114a5b4dcfb7ace7eb9"}],"tools/playbooks/multinode_setup/make_rings.yaml":[{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"eb773c5f20f15c3d9d11b47a183a33fa28d3c825","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      shell:"},{"line_number":31,"context_line":"        cmd: python setup.py develop"},{"line_number":32,"context_line":"        executable: /bin/bash"},{"line_number":33,"context_line":"        chdir: \u0027{{ zuul.project.src_dir }}\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- hosts: proxy"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3f79a3b5_33ef2d88","line":33,"updated":"2018-09-17 23:34:32.000000000","message":"I don\u0027t love how this is in make_rings, but it\u0027s certainly an issue that can be resolved later.","commit_id":"5d70396247a81cbaf6aaf114a5b4dcfb7ace7eb9"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"9215a418d19f153bcce9a534fa1317e1b39b4488","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      shell:"},{"line_number":31,"context_line":"        cmd: python setup.py develop"},{"line_number":32,"context_line":"        executable: /bin/bash"},{"line_number":33,"context_line":"        chdir: \u0027{{ zuul.project.src_dir }}\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- hosts: proxy"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3f79a3b5_f33535f7","line":33,"in_reply_to":"3f79a3b5_33ef2d88","updated":"2018-09-17 23:54:34.000000000","message":"I think the reason to have it here is probably that you\u0027ll need swift installed to get swift-ring-builder.\n\nSince the test-runner is in charge of making/distributing rings maybe we could just install there, and wait to install swift on the other nodes until later? IDK\n\nIt\u0027s kinda curious that we install master swift to make rings then need to down-rev to our test target to run tests... I wouldn\u0027t be opposed to just cloning/checking out/installing once on any given node.","commit_id":"5d70396247a81cbaf6aaf114a5b4dcfb7ace7eb9"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"68ff2fb8c1795925e4f2c524cacff8979d8aa3b7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      shell:"},{"line_number":31,"context_line":"        cmd: python setup.py develop"},{"line_number":32,"context_line":"        executable: /bin/bash"},{"line_number":33,"context_line":"        chdir: \u0027{{ zuul.project.src_dir }}\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- hosts: proxy"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3f79a3b5_dd127bfd","line":33,"in_reply_to":"3f79a3b5_37d70e25","updated":"2018-09-18 12:45:34.000000000","message":"FWIW, I don\u0027t like this either, but as I got to the these later patchsets I was just moving tasks around to make sure it works correctly. I think overall the \"main idea\" should remain the same, but just with better code organization.\n\nWe could continue working on this patch to get this right or just make enhancements in new patches. We also need to discuss using roles correctly, which will create yet a new directory under source root dir, but it is the new \"ansible way\" of laying out code and allows for better code re-use (e.g., have a role to checkout/install swift and pass in the correct parameters of what version to install)","commit_id":"5d70396247a81cbaf6aaf114a5b4dcfb7ace7eb9"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"e1b9bcdbc7e7ac0b081d81a35bbd4b9aa101e16c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      shell:"},{"line_number":31,"context_line":"        cmd: python setup.py develop"},{"line_number":32,"context_line":"        executable: /bin/bash"},{"line_number":33,"context_line":"        chdir: \u0027{{ zuul.project.src_dir }}\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- hosts: proxy"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3f79a3b5_37d70e25","line":33,"in_reply_to":"3f79a3b5_f33535f7","updated":"2018-09-18 11:13:38.000000000","message":"I agree with John, the playbooks name is make_rings. yet it installs swift, sets it up, starts memcache. So does much more then it shold.\n\nSo doesn\u0027t make sense. However I\u0027m not going to go re-organise in this late into a change, especially for a test env. Thiago said a rework would be in the works in the future, so happy to do some clean ups/reworks as a follow up or wait until then.","commit_id":"5d70396247a81cbaf6aaf114a5b4dcfb7ace7eb9"}],"tools/playbooks/multinode_setup/run.yaml":[{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"eb773c5f20f15c3d9d11b47a183a33fa28d3c825","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      shell:"},{"line_number":25,"context_line":"        cmd: python setup.py develop"},{"line_number":26,"context_line":"        executable: /bin/bash"},{"line_number":27,"context_line":"        chdir: \u0027{{ zuul.project.src_dir }}\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- hosts: swift-cluster"},{"line_number":30,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3f79a3b5_f3b21596","line":27,"updated":"2018-09-17 23:34:32.000000000","message":"wasn\u0027t this done in make_rings?\n\nI\u0027d suggest pulling the install out into it\u0027s own file, then that could be the only difference in a few different test definitions.","commit_id":"5d70396247a81cbaf6aaf114a5b4dcfb7ace7eb9"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"9215a418d19f153bcce9a534fa1317e1b39b4488","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      shell:"},{"line_number":25,"context_line":"        cmd: python setup.py develop"},{"line_number":26,"context_line":"        executable: /bin/bash"},{"line_number":27,"context_line":"        chdir: \u0027{{ zuul.project.src_dir }}\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- hosts: swift-cluster"},{"line_number":30,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3f79a3b5_b35edd42","line":27,"in_reply_to":"3f79a3b5_f3b21596","updated":"2018-09-17 23:54:34.000000000","message":"Different version, gotta reinstall. Egg entrypoints etc. may have changed.","commit_id":"5d70396247a81cbaf6aaf114a5b4dcfb7ace7eb9"}],"tools/playbooks/multinode_setup/templates/make_multinode_rings.j2":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"9215a418d19f153bcce9a534fa1317e1b39b4488","unresolved":false,"context_lines":[{"line_number":24,"context_line":"swift-ring-builder object-2.builder add r1z1-{{ hostvars[\u0027object1\u0027].nodepool.public_ipv4 }}:6010/sdb5 1"},{"line_number":25,"context_line":"swift-ring-builder object-2.builder add r1z1-{{ hostvars[\u0027object1\u0027].nodepool.public_ipv4 }}:6010/sdb6 1"},{"line_number":26,"context_line":"swift-ring-builder object-2.builder add r1z1-{{ hostvars[\u0027object1\u0027].nodepool.public_ipv4 }}:6010/sdb7 1"},{"line_number":27,"context_line":"swift-ring-builder object-2.builder add r1z1-{{ hostvars[\u0027object1\u0027].nodepool.public_ipv4 }}:6010/sdb8 1"},{"line_number":28,"context_line":"swift-ring-builder object-2.builder rebalance"},{"line_number":29,"context_line":"swift-ring-builder container.builder create 10 3 1"},{"line_number":30,"context_line":"swift-ring-builder container.builder add r1z1-{{ hostvars[\u0027container1\u0027].nodepool.public_ipv4 }}:6011/sdb1 1"}],"source_content_type":"text/x-jinja2","patch_set":41,"id":"3f79a3b5_7617d347","line":27,"updated":"2018-09-17 23:54:34.000000000","message":"FWIW, I\u0027d be totally fine with explicit loops to highlight what\u0027s actually changing. Something like\n\n for dev in sdb1 sdb2 sdb3 sdb4 sdb5 sdb6 sdb7 sdb8; do\n     swift-ring-builder object-2.builder add r1z1-{{ hostvars[\u0027object1\u0027].nodepool.public_ipv4 }}:6010/$dev 1\n done\n\nor even\n\n for n in {1..8}; do\n     swift-ring-builder object-2.builder add r1z1-{{ hostvars[\u0027object1\u0027].nodepool.public_ipv4 }}:6010/sdb$n 1\n done\n\nMaybe that last one would get complicated because of the templating, though?","commit_id":"5d70396247a81cbaf6aaf114a5b4dcfb7ace7eb9"}]}
