)]}'
{"swift/obj/diskfile.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1aea8ae4ab3250ccdc7010336c1326b1b03a57ce","unresolved":false,"context_lines":[{"line_number":1647,"context_line":"            return self._logger"},{"line_number":1648,"context_line":"        except AttributeError:"},{"line_number":1649,"context_line":"            self._logger \u003d self.manager.logger"},{"line_number":1650,"context_line":"        return self._logger"},{"line_number":1651,"context_line":""},{"line_number":1652,"context_line":"    def _get_tempfile(self):"},{"line_number":1653,"context_line":"        fallback_to_mkstemp \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_40f26d71","line":1650,"updated":"2018-09-12 16:56:00.000000000","message":"Why can\u0027t we just always return self.manager.logger?","commit_id":"33c76507531073e431148a4f65da0a40e5ba88eb"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1aea8ae4ab3250ccdc7010336c1326b1b03a57ce","unresolved":false,"context_lines":[{"line_number":1666,"context_line":"                else:"},{"line_number":1667,"context_line":"                    raise"},{"line_number":1668,"context_line":"        if not self.manager.use_linkat or fallback_to_mkstemp:"},{"line_number":1669,"context_line":"            tmpdir \u003d join(self._diskfile._device_path,"},{"line_number":1670,"context_line":"                          get_tmp_dir(self._diskfile.policy))"},{"line_number":1671,"context_line":"            if not exists(tmpdir):"},{"line_number":1672,"context_line":"                mkdirs(tmpdir)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7b44fa47","line":1669,"range":{"start_line":1669,"start_character":41,"end_line":1669,"end_character":53},"updated":"2018-09-12 16:56:00.000000000","message":"Smells a little weird, should diskfile grow a get_tmp_dir() method, maybe? w/e","commit_id":"33c76507531073e431148a4f65da0a40e5ba88eb"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1aea8ae4ab3250ccdc7010336c1326b1b03a57ce","unresolved":false,"context_lines":[{"line_number":1721,"context_line":"        \"\"\""},{"line_number":1722,"context_line":""},{"line_number":1723,"context_line":"        while chunk:"},{"line_number":1724,"context_line":"            written \u003d os.write(self._fd, chunk)"},{"line_number":1725,"context_line":"            self._upload_size +\u003d written"},{"line_number":1726,"context_line":"            chunk \u003d chunk[written:]"},{"line_number":1727,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_20c4110e","line":1724,"range":{"start_line":1724,"start_character":36,"end_line":1724,"end_character":39},"updated":"2018-09-12 16:56:00.000000000","message":"We oughta make sure we\u0027re opened.","commit_id":"33c76507531073e431148a4f65da0a40e5ba88eb"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"3bb3d3b0db5cd04636619d1e5a78f9c200a646d1","unresolved":false,"context_lines":[{"line_number":1721,"context_line":"        \"\"\""},{"line_number":1722,"context_line":""},{"line_number":1723,"context_line":"        while chunk:"},{"line_number":1724,"context_line":"            written \u003d os.write(self._fd, chunk)"},{"line_number":1725,"context_line":"            self._upload_size +\u003d written"},{"line_number":1726,"context_line":"            chunk \u003d chunk[written:]"},{"line_number":1727,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_76eacfd8","line":1724,"range":{"start_line":1724,"start_character":36,"end_line":1724,"end_character":39},"in_reply_to":"3f79a3b5_20c4110e","updated":"2018-09-12 17:25:59.000000000","message":"Naah, the window is literally 1 line in writer.create(). What could go wrong?","commit_id":"33c76507531073e431148a4f65da0a40e5ba88eb"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1aea8ae4ab3250ccdc7010336c1326b1b03a57ce","unresolved":false,"context_lines":[{"line_number":2775,"context_line":"        try:"},{"line_number":2776,"context_line":"            yield dfw.open()"},{"line_number":2777,"context_line":"        finally:"},{"line_number":2778,"context_line":"            dfw.close()"},{"line_number":2779,"context_line":""},{"line_number":2780,"context_line":"    def write_metadata(self, metadata):"},{"line_number":2781,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c0075d1d","line":2778,"updated":"2018-09-12 16:56:00.000000000","message":"OMG yes.","commit_id":"33c76507531073e431148a4f65da0a40e5ba88eb"}],"swift/obj/mem_diskfile.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1aea8ae4ab3250ccdc7010336c1326b1b03a57ce","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        return self"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def close(self):"},{"line_number":113,"context_line":"        self._fp \u003d None"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def write(self, chunk):"},{"line_number":116,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7b715a44","line":113,"updated":"2018-09-12 16:56:00.000000000","message":"Could use docstrings","commit_id":"33c76507531073e431148a4f65da0a40e5ba88eb"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1aea8ae4ab3250ccdc7010336c1326b1b03a57ce","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        return dr"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def writer(self, size\u003dNone):"},{"line_number":424,"context_line":"        return DiskFileWriter(self._filesystem, self._name)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    @contextmanager"},{"line_number":427,"context_line":"    def create(self, size\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3b91a247","line":424,"updated":"2018-09-12 16:56:00.000000000","message":"ditto","commit_id":"33c76507531073e431148a4f65da0a40e5ba88eb"}]}