)]}'
{"swift/obj/diskfile.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a3e81091911cc1484dabe0f3214e2647366cece6","unresolved":false,"context_lines":[{"line_number":1471,"context_line":"        \"\"\""},{"line_number":1472,"context_line":"        return mkdirs(path)"},{"line_number":1473,"context_line":""},{"line_number":1474,"context_line":"    def listdir(self, path):"},{"line_number":1475,"context_line":"        \"\"\""},{"line_number":1476,"context_line":"        :param path: full path to directory"},{"line_number":1477,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_06078a1a","line":1474,"range":{"start_line":1474,"start_character":8,"end_line":1474,"end_character":27},"updated":"2018-09-14 03:48:42.000000000","message":"It\u0027s a little weird that we\u0027ve got both listdir(self, path) and _listdir(self, path)...","commit_id":"d4f3b345cfe95eae02d331e37438066701b5c44d"}],"swift/obj/reconstructor.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a3e81091911cc1484dabe0f3214e2647366cece6","unresolved":false,"context_lines":[{"line_number":1064,"context_line":"                unlink_older_than(tmp_path, time.time() -"},{"line_number":1065,"context_line":"                                  df_mgr.reclaim_age)"},{"line_number":1066,"context_line":""},{"line_number":1067,"context_line":"                if not df_mgr.exists(obj_path):"},{"line_number":1068,"context_line":"                    try:"},{"line_number":1069,"context_line":"                        df_mgr.mkdirs(obj_path)"},{"line_number":1070,"context_line":"                    except Exception:"},{"line_number":1071,"context_line":"                        self.logger.exception("},{"line_number":1072,"context_line":"                            \u0027Unable to create %s\u0027 % obj_path)"},{"line_number":1073,"context_line":"                    continue"},{"line_number":1074,"context_line":"                try:"},{"line_number":1075,"context_line":"                    partitions \u003d df_mgr.listdir(obj_path)"},{"line_number":1076,"context_line":"                except OSError:"},{"line_number":1077,"context_line":"                    self.logger.exception("},{"line_number":1078,"context_line":"                        \u0027Unable to list partitions in %r\u0027 % obj_path)"},{"line_number":1079,"context_line":"                    continue"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"                self.part_count +\u003d len(partitions)"},{"line_number":1082,"context_line":"                for partition in partitions:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c30bc428","line":1079,"range":{"start_line":1067,"start_character":0,"end_line":1079,"end_character":28},"updated":"2018-09-14 03:48:42.000000000","message":"I wonder if all of this would be better in the manager, and we\u0027d have something like\n\n partitions \u003d df_mgr.get_partitions(obj_path)\n if partitions is None:\n     continue\n\nWe could even have the df_mgr be responsible for filtering out auditor_status_*.json files before returning... maybe even cleaning up non-digit entries and just return a list of ints?\n\nIDK, it seems like we oughta move as much of the knowledge of how data is laid out on disk into the diskfile or its manager as we can. I mean, with LOSF you\u0027re not really listing directories, right? You\u0027re listing keys or prefixes of keys in some k-v store. Let\u0027s find an abstraction that makes sense for both of these, and get the implementation details out of the replicator/reconstructor.\n\nOTOH, maybe this is an actual, actionable path forward, and *later* we can get around to refactoring and making sure we get the *right* abstractions. *shrug*","commit_id":"d4f3b345cfe95eae02d331e37438066701b5c44d"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a3e81091911cc1484dabe0f3214e2647366cece6","unresolved":false,"context_lines":[{"line_number":1151,"context_line":"            df_mgr.remove_file(path)"},{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"        self.logger.info(_(\"Removing partition: %s\"), path)"},{"line_number":1154,"context_line":"        tpool.execute(kill_it, df_mgr, path)"},{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"    def reconstruct(self, **kwargs):"},{"line_number":1157,"context_line":"        \"\"\"Run a reconstruction pass\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e3060022","line":1154,"updated":"2018-09-14 03:48:42.000000000","message":"Yeah, and like this whole function feels like it ought to be on the manager...","commit_id":"d4f3b345cfe95eae02d331e37438066701b5c44d"}]}
