)]}'
{"swift/common/wsgi.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ed86a3fc2190ea8f0c3493db81200c2f6c90591d","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    try:"},{"line_number":198,"context_line":"        keepidle \u003d int(conf.get(\u0027keep_idle\u0027, 600))"},{"line_number":199,"context_line":"        if keepidle \u003c\u003d 0:"},{"line_number":200,"context_line":"            raise ValueError()"},{"line_number":201,"context_line":"    except (ValueError, KeyError, TypeError):"},{"line_number":202,"context_line":"        raise ConfigFileError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fb0f75dd","line":199,"range":{"start_line":199,"start_character":11,"end_line":199,"end_character":24},"updated":"2018-09-14 21:47:35.000000000","message":"Should we also have upper bounds checking? I see things like\n\n\u003e\u003e\u003e sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_KEEPIDLE, 60000)\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"/usr/lib/python2.7/socket.py\", line 228, in meth\n    return getattr(self._sock,name)(*args)\nsocket.error: [Errno 22] Invalid argument\n\u003e\u003e\u003e sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_KEEPIDLE, 600000000000000000)\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"/usr/lib/python2.7/socket.py\", line 228, in meth\n    return getattr(self._sock,name)(*args)\nTypeError: setsockopt() argument 3 must be string or read-only buffer, not int\n\nplaying around in a REPL... Looks like max acceptable value is 2**15 - 1?","commit_id":"53733799ebe54ea9cdaec4aca472a98d23406762"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ed86a3fc2190ea8f0c3493db81200c2f6c90591d","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        if keepidle \u003c\u003d 0:"},{"line_number":200,"context_line":"            raise ValueError()"},{"line_number":201,"context_line":"    except (ValueError, KeyError, TypeError):"},{"line_number":202,"context_line":"        raise ConfigFileError()"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    while not sock and time.time() \u003c retry_until:"},{"line_number":205,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1b3591a8","line":202,"range":{"start_line":202,"start_character":14,"end_line":202,"end_character":31},"updated":"2018-09-14 21:47:35.000000000","message":"It\u0027d be nice to add a description of what went wrong here.","commit_id":"53733799ebe54ea9cdaec4aca472a98d23406762"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bb5eea1abc77ec2e29052782f487fd86a5686d70","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    try:"},{"line_number":198,"context_line":"        keepidle \u003d int(conf.get(\u0027keep_idle\u0027, 600))"},{"line_number":199,"context_line":"        if keepidle \u003c\u003d 0 or keepidle \u003e\u003d 2 ** 15 - 1:"},{"line_number":200,"context_line":"            raise ValueError()"},{"line_number":201,"context_line":"    except (ValueError, KeyError, TypeError):"},{"line_number":202,"context_line":"        raise ConfigFileError()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_a1430e11","line":199,"range":{"start_line":199,"start_character":37,"end_line":199,"end_character":51},"updated":"2018-09-14 23:55:30.000000000","message":"Technically, it can equal 2 ** 15 - 1, so it might be better to say\n\n keepidle \u003e 2 ** 15 - 1\n\nor\n\n keepidle \u003e\u003d 2 ** 15\n\nBut I don\u0027t think anyone would really want that in practice.","commit_id":"cfeb32c66baced374a50d2dd2dd5b13b7d15888c"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bb5eea1abc77ec2e29052782f487fd86a5686d70","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        if keepidle \u003c\u003d 0 or keepidle \u003e\u003d 2 ** 15 - 1:"},{"line_number":200,"context_line":"            raise ValueError()"},{"line_number":201,"context_line":"    except (ValueError, KeyError, TypeError):"},{"line_number":202,"context_line":"        raise ConfigFileError()"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    while not sock and time.time() \u003c retry_until:"},{"line_number":205,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_c1572aca","line":202,"range":{"start_line":202,"start_character":14,"end_line":202,"end_character":31},"updated":"2018-09-14 23:55:30.000000000","message":"Still would be nice to say something like\n\n\u003e keep_idle must be in the range [1, 2 ** 15 - 1]\n\nor something. Meh.","commit_id":"cfeb32c66baced374a50d2dd2dd5b13b7d15888c"}],"test/unit/common/test_wsgi.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ed86a3fc2190ea8f0c3493db81200c2f6c90591d","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            self.assertEqual(wsgi.ssl.wrap_socket_called, [expected_kwargs])"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"            # test keep_idle value"},{"line_number":409,"context_line":"            keepIdle_value \u003d 700"},{"line_number":410,"context_line":"            conf[\u0027keep_idle\u0027] \u003d keepIdle_value"},{"line_number":411,"context_line":"            sock \u003d wsgi.get_socket(conf)"},{"line_number":412,"context_line":"            # assert"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_bb1a5d15","line":409,"range":{"start_line":409,"start_character":29,"end_line":409,"end_character":32},"updated":"2018-09-14 21:47:35.000000000","message":"Should we also test with something like \u0027700\u0027 to make sure str -\u003e int conversion happens as expected?","commit_id":"0dc5b76708e115ba8bc1ea7d20d042a29c7577b1"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ed86a3fc2190ea8f0c3493db81200c2f6c90591d","unresolved":false,"context_lines":[{"line_number":417,"context_line":""},{"line_number":418,"context_line":"            # test keep_idle for negative value"},{"line_number":419,"context_line":"            keepIdle_value \u003d -600"},{"line_number":420,"context_line":"            conf[\u0027keep_idle\u0027] \u003d keepIdle_value"},{"line_number":421,"context_line":"            self.assertRaises(wsgi.ConfigFileError, wsgi.get_socket, conf)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"            # test keep_idle for Type mismatch"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9b1f6108","line":420,"updated":"2018-09-14 21:47:35.000000000","message":"Since we\u0027re only using this value once, I might\u0027ve gone with\n\n conf[\u0027keep_idle\u0027] \u003d -600\n\nbut w/e.","commit_id":"0dc5b76708e115ba8bc1ea7d20d042a29c7577b1"},{"author":{"_account_id":28028,"name":"Fatema Khalid Sherif","email":"fatemakhalid96@gmail.com","username":"FatemaKhalid"},"change_message_id":"df7d9ccba3bbff5d9bf65d0d1eed3aba2c3d0dd7","unresolved":false,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"            # test keep_idle for Type mismatch"},{"line_number":424,"context_line":"            keepIdle_value \u003d \u0027foobar\u0027"},{"line_number":425,"context_line":"            conf[\u0027keep_idle\u0027] \u003d keepIdle_value"},{"line_number":426,"context_line":"            self.assertRaises(wsgi.ConfigFileError, wsgi.get_socket, conf)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c6e740ac","line":425,"updated":"2018-09-14 23:16:00.000000000","message":"Does the previous comment mean that I should conf[\u0027keep_idle\u0027] \u003d \u0027foobar\u0027?","commit_id":"0dc5b76708e115ba8bc1ea7d20d042a29c7577b1"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bb5eea1abc77ec2e29052782f487fd86a5686d70","unresolved":false,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"            # test keep_idle for Type mismatch"},{"line_number":424,"context_line":"            keepIdle_value \u003d \u0027foobar\u0027"},{"line_number":425,"context_line":"            conf[\u0027keep_idle\u0027] \u003d keepIdle_value"},{"line_number":426,"context_line":"            self.assertRaises(wsgi.ConfigFileError, wsgi.get_socket, conf)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0103e2bf","line":425,"in_reply_to":"3f79a3b5_c6e740ac","updated":"2018-09-14 23:55:30.000000000","message":"+1","commit_id":"0dc5b76708e115ba8bc1ea7d20d042a29c7577b1"}]}
