)]}'
{"swift/common/middleware/crypto/kmip_keymaster.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"2fa6ac1ca45911fffecfd195610130a15e220ba9","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                # provided, which doesn\u0027t seem great either."},{"line_number":134,"context_line":"                \u0027kmip.core.config_helper\u0027,"},{"line_number":135,"context_line":"        ):"},{"line_number":136,"context_line":"            logging.getLogger(name).addFilter(debug_filter)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        multikey_opts \u003d self._load_multikey_opts(conf, \u0027key_id\u0027)"},{"line_number":139,"context_line":"        if not multikey_opts:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_daab051d","line":136,"updated":"2018-10-04 16:42:47.000000000","message":"It occurs to me that none of this is specific to this instance of the middleware -- maybe it\u0027d be better at the module level, shortly after\n\n from kmip.pie.client import ProxyKmipClient\n\n?","commit_id":"12b6d460f7c0b08eee330403fd7329fb4ad4e3cb"}],"swift/common/utils.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"89ae738cc912a076b8a893cbaef052577e86e4f1","unresolved":false,"context_lines":[{"line_number":2095,"context_line":"    This is useful when dependencies log too much information."},{"line_number":2096,"context_line":""},{"line_number":2097,"context_line":"    :param level: All messages at or below this level are dropped"},{"line_number":2098,"context_line":"                  Default: DEBUG"},{"line_number":2099,"context_line":"    \"\"\""},{"line_number":2100,"context_line":"    def __init__(self, level\u003dlogging.DEBUG):"},{"line_number":2101,"context_line":"        self.level \u003d level"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3c3a4ac3","line":2098,"updated":"2018-10-04 00:17:00.000000000","message":"Huh, my mental model is all wrong. In my mind when you go say from WARN to DEBUG, I think I\u0027m turning up debugging. But based on the logging.\u003clevel\u003e constants, the values are the opposite (which makes what you say here correct, but seemed wrong when I first read it).\n\n  In [2]: logging.DEBUG\n  Out[2]: 10\n\n  In [3]: logging.INFO\n  Out[3]: 20\n\n  In [4]: logging.WARN\n  Out[4]: 30\n\n  In [5]: logging.ERROR\n  Out[5]: 40\n\n  In [6]: logging.CRITICAL\n  Out[6]: 50\n\n  In [7]: logging.FATAL\n  Out[7]: 50\n\nSo:\n\n  In [8]: logging.DEBUG \u003c logging.INFO \u003c logging.WARN \u003c logging.ERROR \u003c logging.CRITICAL\n  Out[8]: True\n\nNot sure if it\u0027s just me, I wonder if adding a note to the doc string might be a good idea. Like adding a line:\n\n  DEBUG \u003c INFO \u003c WARN \u003c ERROR \u003c CRITICAL|FATAL","commit_id":"8265f8f8eacf649499cb6e5f16238c2c277fc887"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"2fa6ac1ca45911fffecfd195610130a15e220ba9","unresolved":false,"context_lines":[{"line_number":2095,"context_line":"    This is useful when dependencies log too much information."},{"line_number":2096,"context_line":""},{"line_number":2097,"context_line":"    :param level: All messages at or below this level are dropped"},{"line_number":2098,"context_line":"                  Default: DEBUG"},{"line_number":2099,"context_line":"    \"\"\""},{"line_number":2100,"context_line":"    def __init__(self, level\u003dlogging.DEBUG):"},{"line_number":2101,"context_line":"        self.level \u003d level"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5aea9577","line":2098,"in_reply_to":"3f79a3b5_3c3a4ac3","updated":"2018-10-04 16:42:47.000000000","message":"Thanks for that! I suppose https://docs.python.org/3/library/logging.html#logging.Logger.setLevel (for example) mainly talks about *severity* level -- maybe that would make it more obvious that e.g. INFO is below WARNING...\n\nEither way, couldn\u0027t hurt to call it out like this.","commit_id":"8265f8f8eacf649499cb6e5f16238c2c277fc887"}]}