)]}'
{"swift/account/backend.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"9567fc16727e8ad9c71625f3651d68eca5e52e7f","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                                name[:end],"},{"line_number":464,"context_line":"                                delimiter[:-1],"},{"line_number":465,"context_line":"                                chr(ord(delimiter[-1:]) + 1),"},{"line_number":466,"context_line":"                            ])"},{"line_number":467,"context_line":"                            # we want result to be inclusive of delim+1"},{"line_number":468,"context_line":"                            delim_force_gte \u003d True"},{"line_number":469,"context_line":"                        dir_name \u003d name[:end + len(delimiter)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_b346624f","line":466,"updated":"2019-09-16 18:08:15.000000000","message":"be nice if this was dry\u0027d out with the container backend","commit_id":"1ded0d6c8793ca3eca573c098cef78b5ae41f080"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1c90dd87a0b30ad6e9a626e6f4fdb948e5f18368","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                                name[:end],"},{"line_number":464,"context_line":"                                delimiter[:-1],"},{"line_number":465,"context_line":"                                chr(ord(delimiter[-1:]) + 1),"},{"line_number":466,"context_line":"                            ])"},{"line_number":467,"context_line":"                            # we want result to be inclusive of delim+1"},{"line_number":468,"context_line":"                            delim_force_gte \u003d True"},{"line_number":469,"context_line":"                        dir_name \u003d name[:end + len(delimiter)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_095cbb23","line":466,"in_reply_to":"3fa7e38b_b346624f","updated":"2019-09-18 22:46:31.000000000","message":"Yeah -- that\u0027s true of a lot of the query-building, I feel like... OTOH, I keep going back and forth on how much I like common/db.py, particularly post-sharding ...","commit_id":"1ded0d6c8793ca3eca573c098cef78b5ae41f080"}],"swift/container/backend.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"9567fc16727e8ad9c71625f3651d68eca5e52e7f","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"                            marker \u003d \u0027\u0027.join(["},{"line_number":1203,"context_line":"                                name[:end],"},{"line_number":1204,"context_line":"                                delimiter[:-1],"},{"line_number":1205,"context_line":"                                chr(ord(delimiter[-1:]) + 1),"},{"line_number":1206,"context_line":"                            ])"},{"line_number":1207,"context_line":"                            # we want result to be inclusive of delim+1"},{"line_number":1208,"context_line":"                            delim_force_gte \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_f3685a22","line":1205,"updated":"2019-09-16 18:08:15.000000000","message":"I think I\u0027d find it slightly more readable as:\n\n    chr(ord(delimiter[-1]) + 1)\n\n^ I think that\u0027s always the same as delimiter[-1:] isn\u0027t it?\n\nHonestly I was confused about the indexing, something like:\n\n    delimiter_head, delimiter_tail \u003d delimiter[:-1], delimiter[-1]\n\nmay have helped, but since we have to write it three places it seems a bit verbose","commit_id":"1ded0d6c8793ca3eca573c098cef78b5ae41f080"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1c90dd87a0b30ad6e9a626e6f4fdb948e5f18368","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"                            marker \u003d \u0027\u0027.join(["},{"line_number":1203,"context_line":"                                name[:end],"},{"line_number":1204,"context_line":"                                delimiter[:-1],"},{"line_number":1205,"context_line":"                                chr(ord(delimiter[-1:]) + 1),"},{"line_number":1206,"context_line":"                            ])"},{"line_number":1207,"context_line":"                            # we want result to be inclusive of delim+1"},{"line_number":1208,"context_line":"                            delim_force_gte \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_29289784","line":1205,"in_reply_to":"3fa7e38b_f3685a22","updated":"2019-09-18 22:46:31.000000000","message":"I\u0027ve been bitten too many times by\n\n b\u0027asdf\u0027[-1]\n\nbeing b\u0027f\u0027 on py2 but 102 on py3... I\u0027m *pretty sure* this is a native string, but still... I\u0027ve just gotten in the habit of doing slices.\n\nPlus, I\u0027m not sure we had settled on what the py3 API *should be* when I originally wrote this.","commit_id":"1ded0d6c8793ca3eca573c098cef78b5ae41f080"}],"test/unit/container/test_server.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"9567fc16727e8ad9c71625f3651d68eca5e52e7f","unresolved":false,"context_lines":[{"line_number":4020,"context_line":"            resp \u003d req.get_response(self.controller)"},{"line_number":4021,"context_line":"            self.assertEqual(resp.status_int, 201)"},{"line_number":4022,"context_line":"        req \u003d Request.blank("},{"line_number":4023,"context_line":"            \u0027/sda1/p/a/c?prefix\u003dUS~~\u0026delimiter\u003d~~\u0026format\u003djson\u0027,"},{"line_number":4024,"context_line":"            environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027GET\u0027})"},{"line_number":4025,"context_line":"        resp \u003d req.get_response(self.controller)"},{"line_number":4026,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_137df66d","line":4023,"updated":"2019-09-16 18:08:15.000000000","message":"I think these tests would be a lot stronger if the two delimiter chars were *different* characters\n\nas it is, it\u0027s really easy to get the index\u0027s wrong in the code and still pass tests on accident - which is bad because I\u0027d like to try and refactor the code under test a little bit\n\nBut all of my attempts with s/~~/~X/g ended up breaking for some reason or another...","commit_id":"1ded0d6c8793ca3eca573c098cef78b5ae41f080"}]}