)]}'
{"swift/obj/ssync_sender.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"6e734d6af1f7b72660e72167b2d82c71283433f3","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        msg \u003d [\u0027PUT \u0027 + url_path, \u0027Content-Length: \u0027 + str(df.content_length)]"},{"line_number":410,"context_line":"        # Sorted to make it easier to test."},{"line_number":411,"context_line":"        for key, value in sorted(df.get_datafile_metadata().items()):"},{"line_number":412,"context_line":"            if key not in (\u0027name\u0027, \u0027Content-Length\u0027):"},{"line_number":413,"context_line":"                msg.append(\u0027%s: %s\u0027 % (key, value))"},{"line_number":414,"context_line":"        msg \u003d \u0027\\r\\n\u0027.join(msg) + \u0027\\r\\n\\r\\n\u0027"},{"line_number":415,"context_line":"        with exceptions.MessageTimeout(self.daemon.node_timeout, \u0027send_put\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_fda3ad42","side":"PARENT","line":412,"range":{"start_line":412,"start_character":35,"end_line":412,"end_character":51},"updated":"2018-10-12 17:14:53.000000000","message":"Off-topic: Huh. I wonder why we can\u0027t trust the metadata content-length...\n\nI get that we\u0027re already sending df.content_length... but those should be the same, right?","commit_id":"ec94d6b757cb22cff7bc0ec11e68d63078a08c83"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"eeeff99ec4e98587e9c6d38d5117dcdd5c714093","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        msg \u003d [\u0027PUT \u0027 + url_path, \u0027Content-Length: \u0027 + str(df.content_length)]"},{"line_number":410,"context_line":"        # Sorted to make it easier to test."},{"line_number":411,"context_line":"        for key, value in sorted(df.get_datafile_metadata().items()):"},{"line_number":412,"context_line":"            if key not in (\u0027name\u0027, \u0027Content-Length\u0027):"},{"line_number":413,"context_line":"                msg.append(\u0027%s: %s\u0027 % (key, value))"},{"line_number":414,"context_line":"        msg \u003d \u0027\\r\\n\u0027.join(msg) + \u0027\\r\\n\\r\\n\u0027"},{"line_number":415,"context_line":"        with exceptions.MessageTimeout(self.daemon.node_timeout, \u0027send_put\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_fbe80a7c","side":"PARENT","line":412,"range":{"start_line":412,"start_character":35,"end_line":412,"end_character":51},"in_reply_to":"3f79a3b5_fda3ad42","updated":"2018-10-19 12:49:35.000000000","message":"I can\u0027t tell. I had the same question. It goes back to the initial commit of SSYNC.","commit_id":"ec94d6b757cb22cff7bc0ec11e68d63078a08c83"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"6e734d6af1f7b72660e72167b2d82c71283433f3","unresolved":false,"context_lines":[{"line_number":433,"context_line":"    def send_post(self, url_path, df):"},{"line_number":434,"context_line":"        metadata \u003d df.get_metafile_metadata()"},{"line_number":435,"context_line":"        if metadata is None:"},{"line_number":436,"context_line":"            return"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        msg \u003d [\u0027POST \u0027 + url_path]"},{"line_number":439,"context_line":"        # Sorted to make it easier to test."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a0066c1a","side":"PARENT","line":436,"updated":"2018-10-12 17:14:53.000000000","message":"Off-topic: Does this ever get tripped? How would that happen?","commit_id":"ec94d6b757cb22cff7bc0ec11e68d63078a08c83"}]}