)]}'
{"swift/common/middleware/s3api/controllers/multi_upload.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"c6afcdba4b4ff8ef8eb05eeee57da7a555540596","unresolved":false,"context_lines":[{"line_number":578,"context_line":"                if len(etag) \u003e\u003d 2 and etag[0] \u003d\u003d \u0027\"\u0027 and etag[-1] \u003d\u003d \u0027\"\u0027:"},{"line_number":579,"context_line":"                    # strip double quotes"},{"line_number":580,"context_line":"                    etag \u003d etag[1:-1]"},{"line_number":581,"context_line":"                if len(etag) !\u003d 32 or any(c not in \u00270123456789abcdef\u0027"},{"line_number":582,"context_line":"                                          for c in etag):"},{"line_number":583,"context_line":"                    raise InvalidPart(upload_id\u003dupload_id,"},{"line_number":584,"context_line":"                                      part_number\u003dpart_number)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_663fb0df","line":581,"updated":"2018-10-17 17:04:56.000000000","message":"Wait, what?! Why the special case of \u00270123456789abcdef\u0027?","commit_id":"1fa0863cb5168395662e01180edc57d6c6f8b6f4"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"44f3d726386d675517b0ac46bd469e6c6746a74f","unresolved":false,"context_lines":[{"line_number":578,"context_line":"                if len(etag) \u003e\u003d 2 and etag[0] \u003d\u003d \u0027\"\u0027 and etag[-1] \u003d\u003d \u0027\"\u0027:"},{"line_number":579,"context_line":"                    # strip double quotes"},{"line_number":580,"context_line":"                    etag \u003d etag[1:-1]"},{"line_number":581,"context_line":"                if len(etag) !\u003d 32 or any(c not in \u00270123456789abcdef\u0027"},{"line_number":582,"context_line":"                                          for c in etag):"},{"line_number":583,"context_line":"                    raise InvalidPart(upload_id\u003dupload_id,"},{"line_number":584,"context_line":"                                      part_number\u003dpart_number)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6d1ea8bd","line":581,"in_reply_to":"3f79a3b5_0dedb4b7","updated":"2018-10-17 23:51:19.000000000","message":"Correct on both accounts: I recently added dashes to the *large object*\u0027s ETag, and these (part, segment, what-cha-call-it) ETags should not have dashes.\n\nThese should all be normal objects, where the ETag is the MD5 of the data. In AWS, non-multipart uploads and individual MU parts *also* use MD5-of-data as their ETag. Once the MU is completed, though, there isn\u0027t a way (AFAIK) to get or use the ETag of individual parts again.\n\n(Well, you could use something like https://bugs.launchpad.net/swift3/+bug/1735284 to download one part and MD5 the result... but the ETag you\u0027d get for the download would be the complete MU\u0027s ETag.)","commit_id":"1fa0863cb5168395662e01180edc57d6c6f8b6f4"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"8c200cf9857176986fc4a2a304d7b466a82e84ec","unresolved":false,"context_lines":[{"line_number":578,"context_line":"                if len(etag) \u003e\u003d 2 and etag[0] \u003d\u003d \u0027\"\u0027 and etag[-1] \u003d\u003d \u0027\"\u0027:"},{"line_number":579,"context_line":"                    # strip double quotes"},{"line_number":580,"context_line":"                    etag \u003d etag[1:-1]"},{"line_number":581,"context_line":"                if len(etag) !\u003d 32 or any(c not in \u00270123456789abcdef\u0027"},{"line_number":582,"context_line":"                                          for c in etag):"},{"line_number":583,"context_line":"                    raise InvalidPart(upload_id\u003dupload_id,"},{"line_number":584,"context_line":"                                      part_number\u003dpart_number)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0dedb4b7","line":581,"in_reply_to":"3f79a3b5_29c50b3f","updated":"2018-10-17 23:40:48.000000000","message":"Thanks for the explanation. Am I not remembering correctly that you added dashes to Etag just recently? Are these _our_ etags, not Amazon etags (with dashes)?","commit_id":"1fa0863cb5168395662e01180edc57d6c6f8b6f4"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b08ff06795fb491e782cfaec2609d301ff3a4771","unresolved":false,"context_lines":[{"line_number":578,"context_line":"                if len(etag) \u003e\u003d 2 and etag[0] \u003d\u003d \u0027\"\u0027 and etag[-1] \u003d\u003d \u0027\"\u0027:"},{"line_number":579,"context_line":"                    # strip double quotes"},{"line_number":580,"context_line":"                    etag \u003d etag[1:-1]"},{"line_number":581,"context_line":"                if len(etag) !\u003d 32 or any(c not in \u00270123456789abcdef\u0027"},{"line_number":582,"context_line":"                                          for c in etag):"},{"line_number":583,"context_line":"                    raise InvalidPart(upload_id\u003dupload_id,"},{"line_number":584,"context_line":"                                      part_number\u003dpart_number)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_29c50b3f","line":581,"in_reply_to":"3f79a3b5_663fb0df","updated":"2018-10-17 17:26:58.000000000","message":"We\u0027re just spot checking that it looks like an MD5 here. Since s3api was responsible for uploading segments, it knows they should all be normal objects whose ETags look like MD5s -- in fact, we *rely* on it on line 590 when we update the S3-style etag-hasher.","commit_id":"1fa0863cb5168395662e01180edc57d6c6f8b6f4"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"2c9cb9813d966c08841d4a2ec40b2e66fe928391","unresolved":false,"context_lines":[{"line_number":586,"context_line":"                manifest.append({"},{"line_number":587,"context_line":"                    \u0027path\u0027: \u0027/%s/%s/%s/%d\u0027 % ("},{"line_number":588,"context_line":"                        container, req.object_name, upload_id, part_number),"},{"line_number":589,"context_line":"                    \u0027etag\u0027: etag})"},{"line_number":590,"context_line":"                s3_etag_hasher.update(etag.decode(\u0027hex\u0027))"},{"line_number":591,"context_line":"        except (XMLSyntaxError, DocumentInvalid):"},{"line_number":592,"context_line":"            raise MalformedXML()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c3124056","line":589,"updated":"2018-10-17 09:14:37.000000000","message":"It sounds like we expect SLO has the responsibility to check the etag when it\u0027s defined so just pass user given etag in the complete job xml into the slo manifest. it seems to be straight forward to me.","commit_id":"1fa0863cb5168395662e01180edc57d6c6f8b6f4"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"c6afcdba4b4ff8ef8eb05eeee57da7a555540596","unresolved":false,"context_lines":[{"line_number":586,"context_line":"                manifest.append({"},{"line_number":587,"context_line":"                    \u0027path\u0027: \u0027/%s/%s/%s/%d\u0027 % ("},{"line_number":588,"context_line":"                        container, req.object_name, upload_id, part_number),"},{"line_number":589,"context_line":"                    \u0027etag\u0027: etag})"},{"line_number":590,"context_line":"                s3_etag_hasher.update(etag.decode(\u0027hex\u0027))"},{"line_number":591,"context_line":"        except (XMLSyntaxError, DocumentInvalid):"},{"line_number":592,"context_line":"            raise MalformedXML()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_e652e036","line":589,"in_reply_to":"3f79a3b5_c3124056","updated":"2018-10-17 17:04:56.000000000","message":"But this is not enough to put -1 on the patch for you, right?","commit_id":"1fa0863cb5168395662e01180edc57d6c6f8b6f4"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b08ff06795fb491e782cfaec2609d301ff3a4771","unresolved":false,"context_lines":[{"line_number":586,"context_line":"                manifest.append({"},{"line_number":587,"context_line":"                    \u0027path\u0027: \u0027/%s/%s/%s/%d\u0027 % ("},{"line_number":588,"context_line":"                        container, req.object_name, upload_id, part_number),"},{"line_number":589,"context_line":"                    \u0027etag\u0027: etag})"},{"line_number":590,"context_line":"                s3_etag_hasher.update(etag.decode(\u0027hex\u0027))"},{"line_number":591,"context_line":"        except (XMLSyntaxError, DocumentInvalid):"},{"line_number":592,"context_line":"            raise MalformedXML()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_09ea8f9f","line":589,"in_reply_to":"3f79a3b5_e652e036","updated":"2018-10-17 17:26:58.000000000","message":"Yes, SLO is now solely responsible for ETag verification. Previously, both s3api *and* SLO would verify ETags (since we still included ETags in the manifest), but s3api was doing it in such a way that we needed up-to-date container listings.","commit_id":"1fa0863cb5168395662e01180edc57d6c6f8b6f4"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"2c9cb9813d966c08841d4a2ec40b2e66fe928391","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                for item in manifest[:-1]"},{"line_number":616,"context_line":"                if item[\u0027bytes\u0027] \u003c self.conf.min_segment_size]"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        req.environ[\u0027swift.callback.slo_validator\u0027] \u003d size_checker"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        try:"},{"line_number":621,"context_line":"            # TODO: add support for versioning"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_e8063b23","line":618,"updated":"2018-10-17 09:14:37.000000000","message":"I was wondering when it got into the Swift but found it\u0027s still in progress at gerrit review https://review.openstack.org/#/c/609860 so I should go there first.","commit_id":"1fa0863cb5168395662e01180edc57d6c6f8b6f4"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"27a8c1c81fb0ea2db20142b7a2b419bb9782f37f","unresolved":false,"context_lines":[{"line_number":638,"context_line":"                    put_resp \u003d req.get_response("},{"line_number":639,"context_line":"                        self.app, \u0027PUT\u0027, body\u003djson.dumps(manifest),"},{"line_number":640,"context_line":"                        query\u003d{\u0027multipart-manifest\u0027: \u0027put\u0027,"},{"line_number":641,"context_line":"                               \u0027heartbeat\u0027: \u0027on\u0027},"},{"line_number":642,"context_line":"                        headers\u003dheaders)"},{"line_number":643,"context_line":"                    if put_resp.status_int \u003d\u003d 202:"},{"line_number":644,"context_line":"                        body \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_91732b1c","line":641,"updated":"2018-12-12 07:27:15.000000000","message":"I found this heatbeat causes the gate failure because the heatbeat will make 202 Accepted response first so S3Request cannot resolve the error response as BadSwiftRequest as we intended initially.\n\nThe resolution might be a choice from:\n\nA. Revert the heartbeat (trade-off with performance)\nB. Pickup the error handling to ErrorResponse block below, it seems like the error being into the block but I\u0027m not sure it\u0027s safely ported to there.\nC. Change exception (at raising or catching point) to catch the exception correctly. Maybe, this option causes more side-effect.\n\nWhat I can make sure has been as above, we still need to have consideration and discussion on the point.\n\nThanks.","commit_id":"df178fa811dc68d9add17f515eca9f984d3f57c4"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6ab1c41aa6f6ecda594bf0104c47d9de6c816625","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        }"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        container \u003d req.container_name + MULTIUPLOAD_SUFFIX"},{"line_number":573,"context_line":"        resp \u003d req.get_response(self.app, \u0027GET\u0027, container, \u0027\u0027, query\u003dquery)"},{"line_number":574,"context_line":"        objinfo \u003d json.loads(resp.body)"},{"line_number":575,"context_line":"        objtable \u003d dict((o[\u0027name\u0027],"},{"line_number":576,"context_line":"                         {\u0027path\u0027: \u0027/\u0027.join([\u0027\u0027, container, o[\u0027name\u0027]]),"}],"source_content_type":"text/x-python","patch_set":9,"id":"dfd5e7cf_f7356bdb","side":"PARENT","line":573,"updated":"2019-01-09 19:50:49.000000000","message":"yowch, that\u0027s gunna be out of date sometimes isn\u0027t it ;)","commit_id":"284bbdd391b24823f1f1154577b2b68575e7f7e9"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6ab1c41aa6f6ecda594bf0104c47d9de6c816625","unresolved":false,"context_lines":[{"line_number":601,"context_line":""},{"line_number":602,"context_line":"                info \u003d objtable.get(\"%s/%s/%s\" % (req.object_name, upload_id,"},{"line_number":603,"context_line":"                                                  part_number))"},{"line_number":604,"context_line":"                if info is None or info[\u0027etag\u0027] !\u003d etag:"},{"line_number":605,"context_line":"                    raise InvalidPart(upload_id\u003dupload_id,"},{"line_number":606,"context_line":"                                      part_number\u003dpart_number)"},{"line_number":607,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dfd5e7cf_3c60b801","side":"PARENT","line":604,"updated":"2019-01-09 19:50:49.000000000","message":"Best I can tell this was the part that popped when the listing was not up-to-date.\n\nessentially we\u0027re punting to SLO for the etag validation, which does a better job of it anyway.","commit_id":"284bbdd391b24823f1f1154577b2b68575e7f7e9"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6ab1c41aa6f6ecda594bf0104c47d9de6c816625","unresolved":false,"context_lines":[{"line_number":676,"context_line":"                    elif \u0027, Etag Mismatch\u0027 in msg:"},{"line_number":677,"context_line":"                        raise InvalidPart(upload_id\u003dupload_id)"},{"line_number":678,"context_line":"                    elif \u0027, 404 Not Found\u0027 in msg:"},{"line_number":679,"context_line":"                        raise InvalidPart(upload_id\u003dupload_id)"},{"line_number":680,"context_line":"                    else:"},{"line_number":681,"context_line":"                        raise"},{"line_number":682,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dfd5e7cf_573c77be","line":679,"updated":"2019-01-09 19:50:49.000000000","message":"... and all the validation check errors come out just the same!","commit_id":"fcccb52ff492f59bc26cc650761a3597216dd143"}],"test/unit/common/middleware/s3api/test_multi_upload.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6ab1c41aa6f6ecda594bf0104c47d9de6c816625","unresolved":false,"context_lines":[{"line_number":684,"context_line":"            (\u0027HEAD\u0027, \u0027/v1/AUTH_test/bucket+segments/object/X\u0027),"},{"line_number":685,"context_line":"            # Get the currently-uploaded segments"},{"line_number":686,"context_line":"            (\u0027GET\u0027, \u0027/v1/AUTH_test/bucket+segments?delimiter\u003d/\u0027"},{"line_number":687,"context_line":"                    \u0027\u0026format\u003djson\u0026prefix\u003dobject/X/\u0027),"},{"line_number":688,"context_line":"            # Create the SLO"},{"line_number":689,"context_line":"            (\u0027PUT\u0027, \u0027/v1/AUTH_test/bucket/object\u0027"},{"line_number":690,"context_line":"                    \u0027?heartbeat\u003don\u0026multipart-manifest\u003dput\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"dfd5e7cf_b784c35f","side":"PARENT","line":687,"updated":"2019-01-09 19:50:49.000000000","message":"so that\u0027s a good sign :D","commit_id":"284bbdd391b24823f1f1154577b2b68575e7f7e9"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6ab1c41aa6f6ecda594bf0104c47d9de6c816625","unresolved":false,"context_lines":[{"line_number":919,"context_line":"        msg \u003d (\u0027some/path: s3api requires that each segment be at least \u0027"},{"line_number":920,"context_line":"               \u0027%d bytes\u0027) % self.s3api.conf.min_segment_size"},{"line_number":921,"context_line":"        self.swift.register(\u0027PUT\u0027, \u0027/v1/AUTH_test/bucket/object\u0027,"},{"line_number":922,"context_line":"                            swob.HTTPBadRequest, {}, msg)"},{"line_number":923,"context_line":"        req \u003d Request.blank("},{"line_number":924,"context_line":"            \u0027/bucket/object?uploadId\u003dX\u0027,"},{"line_number":925,"context_line":"            environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027POST\u0027},"}],"source_content_type":"text/x-python","patch_set":9,"id":"dfd5e7cf_97817f4d","line":922,"updated":"2019-01-09 19:50:49.000000000","message":"yes, good, manifest upload fails, good good","commit_id":"fcccb52ff492f59bc26cc650761a3597216dd143"}]}
