)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"5101952e4f3b03c0af10290ac69a44301c888db6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"py3: everything account except the real things"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The the 80% of the work still remain in server and replicator,"},{"line_number":10,"context_line":"but let\u0027s knock this out."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I1e1dee8f8c77212183b0ef2b574b57ad1051d57e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_d3974739","line":9,"range":{"start_line":9,"start_character":51,"end_line":9,"end_character":61},"updated":"2018-10-18 17:15:34.000000000","message":"Oh yeah, I forgot that we ported db.py but not db_replicator.py...","commit_id":"6676d74f8f63e8349986cfd31bc958feda935f4c"}],"swift/account/reaper.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"5101952e4f3b03c0af10290ac69a44301c888db6","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                continue"},{"line_number":173,"context_line":"            container_shard \u003d None"},{"line_number":174,"context_line":"            for container_shard, node in enumerate(nodes):"},{"line_number":175,"context_line":"                if is_local_device(self.myips, None, node[\u0027ip\u0027], None) and \\"},{"line_number":176,"context_line":"                        (not self.bind_port or"},{"line_number":177,"context_line":"                         self.bind_port \u003d\u003d node[\u0027port\u0027]) and \\"},{"line_number":178,"context_line":"                        (device \u003d\u003d node[\u0027device\u0027]):"},{"line_number":179,"context_line":"                    break"},{"line_number":180,"context_line":"            else:"},{"line_number":181,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9341cf0b","line":178,"range":{"start_line":175,"start_character":16,"end_line":178,"end_character":51},"updated":"2018-10-18 17:15:34.000000000","message":"Off-topic: This feels like such a weird condition... I still don\u0027t entirely get it...\n\nWhy doesn\u0027t it match the replicator logic? https://github.com/openstack/swift/blob/2.19.0/swift/common/db_replicator.py#L760-L762","commit_id":"6676d74f8f63e8349986cfd31bc958feda935f4c"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"5101952e4f3b03c0af10290ac69a44301c888db6","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                    self.logger.exception("},{"line_number":287,"context_line":"                        _(\u0027Exception with containers for account %s\u0027), account)"},{"line_number":288,"context_line":"                marker \u003d containers[-1][0]"},{"line_number":289,"context_line":"                if marker \u003d\u003d \u0027\u0027:"},{"line_number":290,"context_line":"                    break"},{"line_number":291,"context_line":"            log \u003d \u0027Completed pass on account %s\u0027 % account"},{"line_number":292,"context_line":"        except (Exception, Timeout):"},{"line_number":293,"context_line":"            self.logger.exception("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7391939b","line":290,"range":{"start_line":289,"start_character":16,"end_line":290,"end_character":25},"updated":"2018-10-18 17:15:34.000000000","message":"Off-topic: How does this ever get hit??","commit_id":"6676d74f8f63e8349986cfd31bc958feda935f4c"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"5101952e4f3b03c0af10290ac69a44301c888db6","unresolved":false,"context_lines":[{"line_number":398,"context_line":"                                      % policy_index)"},{"line_number":399,"context_line":"                for obj in objects:"},{"line_number":400,"context_line":"                    obj_name \u003d obj[\u0027name\u0027]"},{"line_number":401,"context_line":"                    if isinstance(obj_name, six.text_type):"},{"line_number":402,"context_line":"                        obj_name \u003d obj_name.encode(\u0027utf8\u0027)"},{"line_number":403,"context_line":"                    pool.spawn(self.reap_object, account, container, part,"},{"line_number":404,"context_line":"                               nodes, obj_name, policy_index)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_332f9b8a","line":401,"updated":"2018-10-18 17:15:34.000000000","message":"Off-topic: Will this ever be false? Even before https://github.com/openstack/swift/commit/ddd5cc1 objects was coming out of json.loads(), so it should be unicode -- maybe this was a hold-over from when we used simplejson?","commit_id":"6676d74f8f63e8349986cfd31bc958feda935f4c"}]}
