)]}'
{"id":"openstack%2Fswift~613452","triplet_id":"openstack%2Fswift~master~I3e556f5b88f0e30661b8de59e995760446b71f97","project":"openstack/swift","branch":"master","topic":"s3api-auth","hashtags":[],"change_id":"I3e556f5b88f0e30661b8de59e995760446b71f97","subject":"s3api: Move authenticator logic to separate module","status":"ABANDONED","created":"2018-10-26 00:26:31.000000000","updated":"2026-04-17 21:36:39.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"520cc745aa2b713d49b4ae9d010eb171ed68bf6e","_number":613452,"virtual_id_number":613452,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":1,"date":"2018-11-03 00:59:12.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"date":"2018-11-07 21:15:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-11-03 00:59:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-11-07 21:15:39.000000000","updated_by":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"reviewer":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"state":"REVIEWER"}],"messages":[{"id":"976a38f2ee05a55bae08d56cf194f92e02d571f2","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2018-10-26 00:26:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b34dac28ca316f338d30c7af167fb0e6f0e4edbf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-26 04:33:55.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/52/613452/1/check/openstack-tox-docs/86c39b4/html/ : SUCCESS in 3m 45s\n- swift-tox-py27 http://logs.openstack.org/52/613452/1/check/swift-tox-py27/fbf200e/ : SUCCESS in 10m 27s\n- swift-tox-py35 http://logs.openstack.org/52/613452/1/check/swift-tox-py35/3153169/ : SUCCESS in 4m 27s\n- swift-tox-py36 http://logs.openstack.org/52/613452/1/check/swift-tox-py36/6ff97f7/ : SUCCESS in 5m 04s (non-voting)\n- swift-tox-func http://logs.openstack.org/52/613452/1/check/swift-tox-func/d501a0f/ : SUCCESS in 9m 23s\n- swift-tox-func-encryption http://logs.openstack.org/52/613452/1/check/swift-tox-func-encryption/3278c8e/ : SUCCESS in 9m 30s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/52/613452/1/check/swift-tox-func-domain-remap-staticweb/12f6c3d/ : SUCCESS in 9m 08s\n- swift-tox-func-ec http://logs.openstack.org/52/613452/1/check/swift-tox-func-ec/c67348e/ : SUCCESS in 9m 09s\n- swift-tox-func-s3api http://logs.openstack.org/52/613452/1/check/swift-tox-func-s3api/96af24e/ : FAILURE in 11m 17s\n- swift-tox-func-s3api-ceph-s3tests-tempauth http://logs.openstack.org/52/613452/1/check/swift-tox-func-s3api-ceph-s3tests-tempauth/7b6f146/ : FAILURE in 18m 49s (non-voting)\n- swift-probetests-centos-7 http://logs.openstack.org/52/613452/1/check/swift-probetests-centos-7/96f53fa/ : SUCCESS in 28m 21s\n- swift-dsvm-functional http://logs.openstack.org/52/613452/1/check/swift-dsvm-functional/0a03bdd/ : SUCCESS in 28m 38s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/52/613452/1/check/swift-dsvm-functional-ipv6/2ea4b05/ : SUCCESS in 28m 55s\n- swift-tox-lower-constraints http://logs.openstack.org/52/613452/1/check/swift-tox-lower-constraints/a99c1e4/ : SUCCESS in 9m 48s\n- openstack-tox-pep8 http://logs.openstack.org/52/613452/1/check/openstack-tox-pep8/7a41fe7/ : FAILURE in 4m 18s\n- swift-multinode-rolling-upgrade http://logs.openstack.org/52/613452/1/check/swift-multinode-rolling-upgrade/8ad4e38/ : SUCCESS in 14m 52s","accounts_in_message":[],"_revision_number":1},{"id":"184ae806c1bc4048e6e2a9c66de75c86d260fcdc","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2018-10-26 19:23:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"743ab2e733ef05477a2a1173876a5734303d22ab","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-27 00:51:34.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/52/613452/2/check/openstack-tox-docs/a9810f6/html/ : SUCCESS in 3m 44s\n- swift-tox-py27 http://logs.openstack.org/52/613452/2/check/swift-tox-py27/c808241/ : SUCCESS in 21m 17s\n- swift-tox-py35 http://logs.openstack.org/52/613452/2/check/swift-tox-py35/2260bcb/ : SUCCESS in 4m 56s\n- swift-tox-py36 http://logs.openstack.org/52/613452/2/check/swift-tox-py36/dbc1445/ : SUCCESS in 5m 19s (non-voting)\n- swift-tox-func http://logs.openstack.org/52/613452/2/check/swift-tox-func/7343661/ : SUCCESS in 10m 42s\n- swift-tox-func-encryption http://logs.openstack.org/52/613452/2/check/swift-tox-func-encryption/ba271e3/ : SUCCESS in 9m 42s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/52/613452/2/check/swift-tox-func-domain-remap-staticweb/7099c70/ : SUCCESS in 9m 46s\n- swift-tox-func-ec http://logs.openstack.org/52/613452/2/check/swift-tox-func-ec/08fd275/ : SUCCESS in 10m 31s\n- swift-tox-func-s3api http://logs.openstack.org/52/613452/2/check/swift-tox-func-s3api/f895b89/ : FAILURE in 9m 42s\n- swift-tox-func-s3api-ceph-s3tests-tempauth http://logs.openstack.org/52/613452/2/check/swift-tox-func-s3api-ceph-s3tests-tempauth/d507d8f/ : FAILURE in 8m 58s (non-voting)\n- swift-probetests-centos-7 http://logs.openstack.org/52/613452/2/check/swift-probetests-centos-7/92bf4dd/ : SUCCESS in 28m 44s\n- swift-dsvm-functional http://logs.openstack.org/52/613452/2/check/swift-dsvm-functional/968d73d/ : SUCCESS in 25m 46s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/52/613452/2/check/swift-dsvm-functional-ipv6/b59b0ca/ : SUCCESS in 26m 16s\n- swift-tox-lower-constraints http://logs.openstack.org/52/613452/2/check/swift-tox-lower-constraints/0b5143f/ : SUCCESS in 10m 16s\n- openstack-tox-pep8 http://logs.openstack.org/52/613452/2/check/openstack-tox-pep8/f015752/ : FAILURE in 5m 12s\n- swift-multinode-rolling-upgrade http://logs.openstack.org/52/613452/2/check/swift-multinode-rolling-upgrade/fa955ee/ : SUCCESS in 14m 28s","accounts_in_message":[],"_revision_number":2},{"id":"2ef9f027ca10107cd1272114d6655328a0ade530","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2018-10-30 18:44:49.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c395ff179987f072e33ba785d37a82030e65acd5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-30 23:47:06.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/52/613452/3/check/openstack-tox-docs/689fc7e/html/ : SUCCESS in 4m 23s\n- swift-tox-py27 http://logs.openstack.org/52/613452/3/check/swift-tox-py27/a106062/ : SUCCESS in 12m 24s\n- swift-tox-py35 http://logs.openstack.org/52/613452/3/check/swift-tox-py35/c2bcf61/ : SUCCESS in 5m 22s\n- swift-tox-py36 http://logs.openstack.org/52/613452/3/check/swift-tox-py36/c8c922d/ : SUCCESS in 5m 32s (non-voting)\n- swift-tox-func http://logs.openstack.org/52/613452/3/check/swift-tox-func/4913727/ : SUCCESS in 8m 45s\n- swift-tox-func-encryption http://logs.openstack.org/52/613452/3/check/swift-tox-func-encryption/6a511e7/ : SUCCESS in 15m 09s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/52/613452/3/check/swift-tox-func-domain-remap-staticweb/161181c/ : SUCCESS in 14m 34s\n- swift-tox-func-ec http://logs.openstack.org/52/613452/3/check/swift-tox-func-ec/193f14f/ : SUCCESS in 15m 41s\n- swift-tox-func-s3api http://logs.openstack.org/52/613452/3/check/swift-tox-func-s3api/1d5a640/ : SUCCESS in 10m 01s\n- swift-tox-func-s3api-ceph-s3tests-tempauth http://logs.openstack.org/52/613452/3/check/swift-tox-func-s3api-ceph-s3tests-tempauth/1afd5f0/ : FAILURE in 10m 24s (non-voting)\n- swift-probetests-centos-7 http://logs.openstack.org/52/613452/3/check/swift-probetests-centos-7/cc7f38e/ : FAILURE in 29m 57s\n- swift-dsvm-functional http://logs.openstack.org/52/613452/3/check/swift-dsvm-functional/66e5da2/ : SUCCESS in 22m 05s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/52/613452/3/check/swift-dsvm-functional-ipv6/011b3c0/ : SUCCESS in 31m 43s\n- swift-tox-lower-constraints http://logs.openstack.org/52/613452/3/check/swift-tox-lower-constraints/6a117d5/ : SUCCESS in 13m 54s\n- openstack-tox-pep8 http://logs.openstack.org/52/613452/3/check/openstack-tox-pep8/6e4819d/ : SUCCESS in 5m 31s\n- swift-multinode-rolling-upgrade http://logs.openstack.org/52/613452/3/check/swift-multinode-rolling-upgrade/633c1fe/ : SUCCESS in 14m 56s","accounts_in_message":[],"_revision_number":3},{"id":"53fc8c7c46fab27339750f47acc948f2690387a5","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2018-11-03 00:27:29.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"f83af4a1e408ea8d30e9f568c8e4897205819352","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-03 00:59:12.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/52/613452/4/check/openstack-tox-docs/493189b/html/ : SUCCESS in 3m 37s\n- swift-tox-py27 http://logs.openstack.org/52/613452/4/check/swift-tox-py27/d3124cd/ : SUCCESS in 10m 27s\n- swift-tox-py35 http://logs.openstack.org/52/613452/4/check/swift-tox-py35/5921cec/ : SUCCESS in 4m 24s\n- swift-tox-py36 http://logs.openstack.org/52/613452/4/check/swift-tox-py36/6d2b9bb/ : SUCCESS in 4m 33s (non-voting)\n- swift-tox-func http://logs.openstack.org/52/613452/4/check/swift-tox-func/6425bef/ : SUCCESS in 9m 24s\n- swift-tox-func-encryption http://logs.openstack.org/52/613452/4/check/swift-tox-func-encryption/a3a00b0/ : SUCCESS in 8m 19s\n- swift-tox-func-domain-remap-staticweb http://logs.openstack.org/52/613452/4/check/swift-tox-func-domain-remap-staticweb/c11ced5/ : SUCCESS in 8m 51s\n- swift-tox-func-ec http://logs.openstack.org/52/613452/4/check/swift-tox-func-ec/5ea71dd/ : SUCCESS in 8m 24s\n- swift-tox-func-s3api http://logs.openstack.org/52/613452/4/check/swift-tox-func-s3api/038d1e4/ : SUCCESS in 11m 14s\n- swift-tox-func-s3api-ceph-s3tests-tempauth http://logs.openstack.org/52/613452/4/check/swift-tox-func-s3api-ceph-s3tests-tempauth/c60a0a6/ : SUCCESS in 10m 38s (non-voting)\n- swift-probetests-centos-7 http://logs.openstack.org/52/613452/4/check/swift-probetests-centos-7/8761fe9/ : SUCCESS in 29m 49s\n- swift-dsvm-functional http://logs.openstack.org/52/613452/4/check/swift-dsvm-functional/e6f9766/ : SUCCESS in 22m 34s\n- swift-dsvm-functional-ipv6 http://logs.openstack.org/52/613452/4/check/swift-dsvm-functional-ipv6/7868b03/ : SUCCESS in 25m 11s\n- swift-tox-lower-constraints http://logs.openstack.org/52/613452/4/check/swift-tox-lower-constraints/d7975dd/ : SUCCESS in 10m 47s\n- openstack-tox-pep8 http://logs.openstack.org/52/613452/4/check/openstack-tox-pep8/42f2f70/ : SUCCESS in 5m 15s\n- swift-multinode-rolling-upgrade http://logs.openstack.org/52/613452/4/check/swift-multinode-rolling-upgrade/2f4aa38/ : SUCCESS in 14m 12s","accounts_in_message":[],"_revision_number":4},{"id":"520cc745aa2b713d49b4ae9d010eb171ed68bf6e","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2026-04-17 21:36:39.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"e8da8ce006a5c999c0b3f7f3a21a6df171cb45da","revisions":{"c1335912d6a2a5a38a2ede06f0de95e180779e38":{"kind":"REWORK","_number":1,"created":"2018-10-26 00:26:31.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/52/613452/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/52/613452/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/52/613452/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/52/613452/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/52/613452/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/52/613452/1"}}},"commit":{"parents":[{"commit":"6bb8229b75de74c11f46de54bbca2d10bfe3bada","subject":"Merge \"Require gettext for all non-SUSE distros\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6bb8229b75de74c11f46de54bbca2d10bfe3bada"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2018-08-31 16:43:28.000000000","tz":0},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2018-10-26 00:17:32.000000000","tz":0},"subject":"WIP: s3api: Move authenticator logic to separate module","message":"WIP: s3api: Move authenticator logic to separate module\n\nI didn\u0027t much care for the mix-in strategy for adding v4 support. Plus,\nthis lets us re-use the v4-signer (at least) later, if/when we add\nsupport for more AWS-like endpoints (such as STS).\n\nFor future work: stop doing validation work during S3Request.__init__\n(beyond *maybe* raising NotS3Request). swob.Request doesn\u0027t raise\nanything during __init__; it feels weird that this does.\n\nChange-Id: I3e556f5b88f0e30661b8de59e995760446b71f97\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c1335912d6a2a5a38a2ede06f0de95e180779e38"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c1335912d6a2a5a38a2ede06f0de95e180779e38"}]},"branch":"refs/heads/master"},"e2cc8b4279a588eab5ef7c0ce3c3f9429e28cc8b":{"kind":"REWORK","_number":2,"created":"2018-10-26 19:23:44.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/52/613452/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/52/613452/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/52/613452/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/52/613452/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/52/613452/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/52/613452/2"}}},"commit":{"parents":[{"commit":"6bb8229b75de74c11f46de54bbca2d10bfe3bada","subject":"Merge \"Require gettext for all non-SUSE distros\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6bb8229b75de74c11f46de54bbca2d10bfe3bada"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2018-08-31 16:43:28.000000000","tz":0},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2018-10-26 19:23:31.000000000","tz":-420},"subject":"WIP: s3api: Move authenticator logic to separate module","message":"WIP: s3api: Move authenticator logic to separate module\n\nI didn\u0027t much care for the mix-in strategy for adding v4 support. Plus,\nthis lets us re-use the v4-signer (at least) later, if/when we add\nsupport for more AWS-like endpoints (such as STS).\n\nFor future work: stop doing validation work during S3Request.__init__\n(beyond *maybe* raising NotS3Request). swob.Request doesn\u0027t raise\nanything during __init__; it feels weird that this does.\n\nChange-Id: I3e556f5b88f0e30661b8de59e995760446b71f97\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e2cc8b4279a588eab5ef7c0ce3c3f9429e28cc8b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e2cc8b4279a588eab5ef7c0ce3c3f9429e28cc8b"}]},"branch":"refs/heads/master"},"408c0c7b901d6fa9e21b9a86709b11dd1280bcc9":{"kind":"REWORK","_number":3,"created":"2018-10-30 18:44:49.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/52/613452/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/52/613452/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/52/613452/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/52/613452/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/52/613452/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/52/613452/3"}}},"commit":{"parents":[{"commit":"2cfe31551db57de2489208c7d0f53aab5549749c","subject":"Merge \"Allow multiple keymasters\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/2cfe31551db57de2489208c7d0f53aab5549749c"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2018-08-31 16:43:28.000000000","tz":0},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2018-10-30 18:44:22.000000000","tz":-420},"subject":"s3api: Move authenticator logic to separate module","message":"s3api: Move authenticator logic to separate module\n\nI didn\u0027t much care for the mix-in strategy for adding v4 support. Plus,\nthis lets us re-use the v4-signer (at least) later, if/when we add\nsupport for more AWS-like endpoints (such as STS).\n\nFor future work: stop doing validation work during S3Request.__init__\n(beyond *maybe* raising NotS3Request). swob.Request doesn\u0027t raise\nanything during __init__; it feels weird that this does.\n\nChange-Id: I3e556f5b88f0e30661b8de59e995760446b71f97\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/408c0c7b901d6fa9e21b9a86709b11dd1280bcc9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/408c0c7b901d6fa9e21b9a86709b11dd1280bcc9"}]},"branch":"refs/heads/master"},"e8da8ce006a5c999c0b3f7f3a21a6df171cb45da":{"kind":"REWORK","_number":4,"created":"2018-11-03 00:27:29.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/52/613452/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/52/613452/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/52/613452/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/52/613452/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/52/613452/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/52/613452/4"}}},"commit":{"parents":[{"commit":"2cfe31551db57de2489208c7d0f53aab5549749c","subject":"Merge \"Allow multiple keymasters\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/2cfe31551db57de2489208c7d0f53aab5549749c"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2018-08-31 16:43:28.000000000","tz":0},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2018-11-03 00:26:39.000000000","tz":0},"subject":"s3api: Move authenticator logic to separate module","message":"s3api: Move authenticator logic to separate module\n\nI didn\u0027t much care for the mix-in strategy for adding v4 support. Plus,\nthis lets us re-use the v4-signer (at least) later, if/when we add\nsupport for more AWS-like endpoints (such as STS).\n\nAdds a new config option, reject_non_aws_authorization, to allow or deny\nunrecognized authorization headers. Historically, we\u0027ve always rejected\nsuch headers (so default is True), which was getting covered by ceph\u0027s\ns3-tests.\n\nFor future work: stop doing validation work during S3Request.__init__\n(beyond *maybe* raising NotS3Request). swob.Request doesn\u0027t raise\nanything during __init__; it feels weird that this does.\n\nChange-Id: I3e556f5b88f0e30661b8de59e995760446b71f97\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e8da8ce006a5c999c0b3f7f3a21a6df171cb45da"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e8da8ce006a5c999c0b3f7f3a21a6df171cb45da"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}