)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0c936ffb876c03e56869d01d71e9c9e9275b1ddb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"container-replicator, and container-sharder which have been known to peg"},{"line_number":16,"context_line":"CPUs when they\u0027re not IO limited."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1784753"},{"line_number":19,"context_line":"Change-Id: Ib7f2497794fa2f384a1a6ab500b657c624426384"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_fcd84b80","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":10},"updated":"2018-10-29 22:35:54.000000000","message":"Partial-Bug. Still got\n\n- object-reconstructor\n- object-replicator\n- container-reconciler","commit_id":"059a3be75f4bcca97fc3161155cafac362275ed1"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"adec20aa6f552120622c3d9c8212efe30539270d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"container-replicator, and container-sharder which have been known to peg"},{"line_number":16,"context_line":"CPUs when they\u0027re not IO limited."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1784753"},{"line_number":19,"context_line":"Change-Id: Ib7f2497794fa2f384a1a6ab500b657c624426384"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_88030776","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":10},"in_reply_to":"3f79a3b5_fcd84b80","updated":"2018-10-30 14:24:21.000000000","message":"pfffhftttt that bug is too big :P","commit_id":"059a3be75f4bcca97fc3161155cafac362275ed1"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4b7bf8b4ef0be536afd6d31fbafc6955f6a1091d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Most daemons have a \"go as fast as you can then sleep for 30 seconds\""},{"line_number":10,"context_line":"strategy towards resource utilization; the object-updater and"},{"line_number":11,"context_line":"object-auditor however have some \"max_X_per_second\" options that allow"},{"line_number":12,"context_line":"operators much better control over how they spend their I/O budget."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change extends that pattern into the account-replicator,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_de93f258","line":11,"range":{"start_line":11,"start_character":34,"end_line":11,"end_character":38},"updated":"2018-10-30 17:25:20.000000000","message":"nit: Just X_per_second","commit_id":"2954473c0960f87c66a2d1cf03c57a3cee0f9cfc"}],"doc/source/deployment_guide.rst":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0c936ffb876c03e56869d01d71e9c9e9275b1ddb","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"**********************"},{"line_number":1173,"context_line":"[container-replicator]"},{"line_number":1174,"context_line":"**********************"},{"line_number":1175,"context_line":""},{"line_number":1176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_bc897370","line":1173,"updated":"2018-10-29 22:35:54.000000000","message":"Off-topic: hmm... we ought to add a [container-sharder] section...","commit_id":"059a3be75f4bcca97fc3161155cafac362275ed1"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"adec20aa6f552120622c3d9c8212efe30539270d","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"**********************"},{"line_number":1173,"context_line":"[container-replicator]"},{"line_number":1174,"context_line":"**********************"},{"line_number":1175,"context_line":""},{"line_number":1176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_c8cfbf52","line":1173,"in_reply_to":"3f79a3b5_bc897370","updated":"2018-10-30 14:24:21.000000000","message":"+1\n\nhttps://bugs.launchpad.net/swift/+bug/1800666","commit_id":"059a3be75f4bcca97fc3161155cafac362275ed1"}],"swift/common/db_replicator.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0c936ffb876c03e56869d01d71e9c9e9275b1ddb","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                                \u0027interval.\u0027"},{"line_number":206,"context_line":"                                % {\u0027type\u0027: self.server_type})"},{"line_number":207,"context_line":"        self.databases_per_second \u003d int("},{"line_number":208,"context_line":"            conf.get(\u0027databases_per_second\u0027, 50))"},{"line_number":209,"context_line":"        self.node_timeout \u003d float(conf.get(\u0027node_timeout\u0027, 10))"},{"line_number":210,"context_line":"        self.conn_timeout \u003d float(conf.get(\u0027conn_timeout\u0027, 0.5))"},{"line_number":211,"context_line":"        self.rsync_compress \u003d config_true_value("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_fcc12b82","line":208,"range":{"start_line":208,"start_character":22,"end_line":208,"end_character":42},"updated":"2018-10-29 22:35:54.000000000","message":"+1 on databases_per_second instead of max_databases_per_second; this matches the updater and auditor.","commit_id":"059a3be75f4bcca97fc3161155cafac362275ed1"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"adec20aa6f552120622c3d9c8212efe30539270d","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                                \u0027interval.\u0027"},{"line_number":206,"context_line":"                                % {\u0027type\u0027: self.server_type})"},{"line_number":207,"context_line":"        self.databases_per_second \u003d int("},{"line_number":208,"context_line":"            conf.get(\u0027databases_per_second\u0027, 50))"},{"line_number":209,"context_line":"        self.node_timeout \u003d float(conf.get(\u0027node_timeout\u0027, 10))"},{"line_number":210,"context_line":"        self.conn_timeout \u003d float(conf.get(\u0027conn_timeout\u0027, 0.5))"},{"line_number":211,"context_line":"        self.rsync_compress \u003d config_true_value("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_68878b0c","line":208,"range":{"start_line":208,"start_character":22,"end_line":208,"end_character":42},"in_reply_to":"3f79a3b5_fcc12b82","updated":"2018-10-30 14:24:21.000000000","message":"Done","commit_id":"059a3be75f4bcca97fc3161155cafac362275ed1"}],"test/unit/container/test_sharder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0c936ffb876c03e56869d01d71e9c9e9275b1ddb","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        n_databases \u003d [100]"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        def stub_iter(dirs):"},{"line_number":623,"context_line":"            for i in range(n_databases[0]):"},{"line_number":624,"context_line":"                yield i, \u0027/srv/node/sda/path/to/container.db\u0027, {}"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"        now \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_7ce51b3d","line":623,"range":{"start_line":623,"start_character":38,"end_line":623,"end_character":41},"updated":"2018-10-29 22:35:54.000000000","message":"nit: Since we aren\u0027t trying to update n_databases in the function, I don\u0027t think this list-wrapping is strictly necessary, but w/e.","commit_id":"059a3be75f4bcca97fc3161155cafac362275ed1"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"adec20aa6f552120622c3d9c8212efe30539270d","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        n_databases \u003d [100]"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        def stub_iter(dirs):"},{"line_number":623,"context_line":"            for i in range(n_databases[0]):"},{"line_number":624,"context_line":"                yield i, \u0027/srv/node/sda/path/to/container.db\u0027, {}"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"        now \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c86c9f6d","line":623,"range":{"start_line":623,"start_character":38,"end_line":623,"end_character":41},"in_reply_to":"3f79a3b5_7ce51b3d","updated":"2018-10-30 14:24:21.000000000","message":"Done","commit_id":"059a3be75f4bcca97fc3161155cafac362275ed1"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4b7bf8b4ef0be536afd6d31fbafc6955f6a1091d","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        n_databases \u003d [100]"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        def stub_iter(dirs):"},{"line_number":623,"context_line":"            for i in range(n_databases[0]):"},{"line_number":624,"context_line":"                yield i, \u0027/srv/node/sda/path/to/container.db\u0027, {}"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"        now \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_7e7c1e74","line":623,"range":{"start_line":623,"start_character":38,"end_line":623,"end_character":41},"in_reply_to":"3f79a3b5_c86c9f6d","updated":"2018-10-30 17:25:20.000000000","message":"Did not! :P","commit_id":"059a3be75f4bcca97fc3161155cafac362275ed1"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0c936ffb876c03e56869d01d71e9c9e9275b1ddb","unresolved":false,"context_lines":[{"line_number":643,"context_line":"            list(sharder.roundrobin_datadirs(None))"},{"line_number":644,"context_line":"        # 100 db at 1/s should take ~100s"},{"line_number":645,"context_line":"        run_time \u003d sum(clock[\u0027sleeps\u0027])"},{"line_number":646,"context_line":"        self.assertTrue(97 \u003c\u003d run_time \u003c 100, \u0027took %s\u0027 % run_time)"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"        sharder \u003d ContainerSharder({\u0027databases_per_second\u0027: 50})"},{"line_number":649,"context_line":"        n_databases \u003d [1000]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9ce83715","line":646,"range":{"start_line":646,"start_character":24,"end_line":646,"end_character":44},"updated":"2018-10-29 22:35:54.000000000","message":"I woulda thought we\u0027d have exact numbers we could use, since we\u0027re mocking out time.time...","commit_id":"059a3be75f4bcca97fc3161155cafac362275ed1"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4b7bf8b4ef0be536afd6d31fbafc6955f6a1091d","unresolved":false,"context_lines":[{"line_number":618,"context_line":"    def test_ratelimited_roundrobin(self):"},{"line_number":619,"context_line":"        with mock.patch(\u0027swift.common.db_replicator.ring.Ring\u0027,"},{"line_number":620,"context_line":"                        lambda *args, **kwargs: FakeRing()):"},{"line_number":621,"context_line":"            sharder \u003d ContainerSharder({\u0027databases_per_second\u0027: 1})"},{"line_number":622,"context_line":"        n_databases \u003d [100]"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"        def stub_iter(dirs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_fec7ce65","line":621,"updated":"2018-10-30 17:25:20.000000000","message":"I think you\u0027re going to want something like\n\n with self._mock_sharder(conf) as sharder:\n\nfrom the other tests... apparently the test tried to load my real internal-client.conf, or something?\n\nERROR: test_ratelimited_roundrobin (test.unit.container.test_sharder.TestSharder)\n----------------------------------------------------------------------\nTraceback (most recent call last):\n  File \"/vagrant/swift/test/unit/container/test_sharder.py\", line 621, in test_ratelimited_roundrobin\n    sharder \u003d ContainerSharder({\u0027databases_per_second\u0027: 1})\n  File \"/vagrant/swift/swift/container/sharder.py\", line 366, in __init__\n    allow_modify_pipeline\u003dFalse)\n  File \"/vagrant/swift/swift/common/internal_client.py\", line 153, in __init__\n    allow_modify_pipeline\u003dallow_modify_pipeline)\n  File \"/vagrant/swift/swift/common/wsgi.py\", line 409, in loadapp\n    return ctx.create()\n  File \"/usr/local/lib/python2.7/dist-packages/paste/deploy/loadwsgi.py\", line 710, in create\n    return self.object_type.invoke(self)\n  File \"/usr/local/lib/python2.7/dist-packages/paste/deploy/loadwsgi.py\", line 207, in invoke\n    app \u003d filter(app)\n  File \"/vagrant/swift/swift/common/middleware/crypto/kmip_keymaster.py\", line 171, in keymaster_filter\n    return KmipKeyMaster(app, conf)\n  File \"/vagrant/swift/swift/common/middleware/crypto/keymaster.py\", line 162, in __init__\n    self._root_secrets \u003d self._get_root_secret(conf)\n  File \"/vagrant/swift/swift/common/middleware/crypto/kmip_keymaster.py\", line 145, in _get_root_secret\n    config_file\u003dconf[\u0027__file__\u0027]\nAttributeError: __exit__\n\nSurely the mocking at https://github.com/openstack/swift/blob/2.19.0/test/unit/common/middleware/crypto/test_kmip_keymaster.py#L24-L26 isn\u0027t helping...","commit_id":"2954473c0960f87c66a2d1cf03c57a3cee0f9cfc"}]}
