)]}'
{"swift/common/utils.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"4e24e4c2a39fd53c6bca63fc0bf5d4315ed99633","unresolved":false,"context_lines":[{"line_number":4672,"context_line":"            return value.encode(\u0027utf-8\u0027)"},{"line_number":4673,"context_line":"        if not six.PY2 and isinstance(value, six.binary_type):"},{"line_number":4674,"context_line":"            return value.decode(\u0027utf-8\u0027)"},{"line_number":4675,"context_line":"        return value"},{"line_number":4676,"context_line":""},{"line_number":4677,"context_line":"    def _encode_bound(self, bound):"},{"line_number":4678,"context_line":"        if isinstance(bound, ShardRange.OuterBound):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_e07d96c3","line":4675,"updated":"2018-11-03 02:29:35.000000000","message":"I am not liking this approach (please see the general comment).","commit_id":"52105b97c0c0dda79009b70d25f409d23bda28c1"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"7d8659cc8bfeb063736b6b50c1d345f18d7c12f3","unresolved":false,"context_lines":[{"line_number":4672,"context_line":"            return value.encode(\u0027utf-8\u0027)"},{"line_number":4673,"context_line":"        if not six.PY2 and isinstance(value, six.binary_type):"},{"line_number":4674,"context_line":"            return value.decode(\u0027utf-8\u0027)"},{"line_number":4675,"context_line":"        return value"},{"line_number":4676,"context_line":""},{"line_number":4677,"context_line":"    def _encode_bound(self, bound):"},{"line_number":4678,"context_line":"        if isinstance(bound, ShardRange.OuterBound):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b2d6f725","line":4675,"in_reply_to":"3f79a3b5_e07d96c3","updated":"2018-11-05 18:38:30.000000000","message":"I\u0027ll back it out. It was something I tried before I tracked down the changes needed to merge_items/merge_shard_ranges in swift/container/backend.py","commit_id":"52105b97c0c0dda79009b70d25f409d23bda28c1"}],"swift/container/reconciler.py":[{"author":{"_account_id":26240,"name":"libaoan","email":"baoan_008@163.com","username":"baoan"},"change_message_id":"4f988bd5b153af478a54a3ea5caee0299a9f97f1","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        return False"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    if cmp_policy_info(info, remote_info) \u003c\u003d 0:"},{"line_number":103,"context_line":"        return info[\u0027storage_policy_index\u0027] !\u003d info[\u0027storage_policy_index\u0027]"},{"line_number":104,"context_line":"    return info[\u0027storage_policy_index\u0027] !\u003d remote_info[\u0027storage_policy_index\u0027]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_0a5a0f1e","line":103,"range":{"start_line":103,"start_character":73,"end_line":103,"end_character":75},"updated":"2018-11-06 00:11:12.000000000","message":"this line is always ture, why not return True?","commit_id":"b18c133d0fc16f074d96e4fd9c18fefa5dad3f1a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"563b79d938b7362e29de3764f6f507ba0971ecae","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        return False"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    if cmp_policy_info(info, remote_info) \u003c\u003d 0:"},{"line_number":103,"context_line":"        return info[\u0027storage_policy_index\u0027] !\u003d info[\u0027storage_policy_index\u0027]"},{"line_number":104,"context_line":"    return info[\u0027storage_policy_index\u0027] !\u003d remote_info[\u0027storage_policy_index\u0027]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_dd192a23","line":103,"range":{"start_line":103,"start_character":73,"end_line":103,"end_character":75},"in_reply_to":"3f79a3b5_0a5a0f1e","updated":"2018-11-07 00:54:09.000000000","message":"Good catch, that *is* rather tautological! I think we can even reduce it further, to just\n\n return cmp_policy_info(info, remote_info) \u003e 0\n\nsince we\u0027ve got the\n\n if remote_info[\u0027storage_policy_index\u0027] \u003d\u003d \\\n        info[\u0027storage_policy_index\u0027]:\n    return False\n\nabove.","commit_id":"b18c133d0fc16f074d96e4fd9c18fefa5dad3f1a"}]}