)]}'
{"etc/proxy-server.conf-sample":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6ec4cc5e144a5a5d53d32d37f0cd75efb3e0bd75","unresolved":false,"context_lines":[{"line_number":573,"context_line":"# and keymaster middlewares, change this to \u0027true\u0027 to service PUTs that include"},{"line_number":574,"context_line":"# an \u0027x-amz-server-side-encryption: AES256\u0027 header. Note that \u0027aws:kms\u0027 header"},{"line_number":575,"context_line":"# values will continue to cause 501 responses."},{"line_number":576,"context_line":"# allow_server_side_encryption \u003d false"},{"line_number":577,"context_line":"#"},{"line_number":578,"context_line":"# You can override the default log routing for this filter here:"},{"line_number":579,"context_line":"# log_name \u003d s3api"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3f79a3b5_df0365bb","line":576,"updated":"2018-12-06 00:40:12.000000000","message":"boo more knobs, plus we should knows this - can we do the thing where we just inspect the admin swift info s3api is just always smarter/better no operator knobs needed?","commit_id":"ac35784413e01d1787115d3849b842e49a3c7069"}],"swift/common/middleware/s3api/s3request.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"18a244a15837b49d2a9ed8077f0e1a05e180c7b0","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                    \u0027The encryption method specified is not supported\u0027)"},{"line_number":751,"context_line":"            if not self.allow_server_side_encryption or sse_value !\u003d \u0027AES256\u0027:"},{"line_number":752,"context_line":"                raise S3NotImplemented("},{"line_number":753,"context_line":"                    \u0027Server-side encryption is not supported.\u0027)"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        if \u0027x-amz-website-redirect-location\u0027 in self.headers:"},{"line_number":756,"context_line":"            raise S3NotImplemented(\u0027Website redirection is not supported.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_aea932db","line":753,"updated":"2018-11-28 22:41:58.000000000","message":"Not (necessarily) strictly true -- more accurately,\n\n \u0027%s server-side encryption is not supported\u0027 % sse_value","commit_id":"ac35784413e01d1787115d3849b842e49a3c7069"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"817b26078c95865c48ed584e3769e45c7dcc32cf","unresolved":false,"context_lines":[{"line_number":749,"context_line":"                    \u0027The encryption method specified is not supported\u0027)"},{"line_number":750,"context_line":"            encryption_enabled \u003d get_swift_info(admin\u003dTrue)[\u0027admin\u0027].get("},{"line_number":751,"context_line":"                \u0027encryption\u0027, {}).get(\u0027enabled\u0027)"},{"line_number":752,"context_line":"            if not encryption_enabled or sse_value !\u003d \u0027AES256\u0027:"},{"line_number":753,"context_line":"                raise S3NotImplemented("},{"line_number":754,"context_line":"                    \u0027Server-side encryption is not supported.\u0027)"},{"line_number":755,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_486ea8cb","line":752,"updated":"2018-12-07 02:10:27.000000000","message":"strong preference for the less ambiguous:\n\ndiff --git a/swift/common/middleware/s3api/s3request.py b/swift/common/middleware/s3api/s3request.py\nindex d12275487..440d48fdb 100644\n--- a/swift/common/middleware/s3api/s3request.py\n+++ b/swift/common/middleware/s3api/s3request.py\n@@ -749,7 +749,7 @@ class S3Request(swob.Request):\n                     \u0027The encryption method specified is not supported\u0027)\n             encryption_enabled \u003d get_swift_info(admin\u003dTrue)[\u0027admin\u0027].get(\n                 \u0027encryption\u0027, {}).get(\u0027enabled\u0027)\n-            if not encryption_enabled or sse_value !\u003d \u0027AES256\u0027:\n+            if sse_value !\u003d \u0027AES256\u0027 or not encryption_enabled:\n                 raise S3NotImplemented(\n                     \u0027Server-side encryption is not supported.\u0027)","commit_id":"8e95a93858dc215e2d2f7d48e035e6b5f1ab582a"}]}