)]}'
{"swift/common/utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"93ca29fa739b6dbfc4aff87ad876940cab0d8fea","unresolved":false,"context_lines":[{"line_number":2274,"context_line":"    to test if poll() is available on platform."},{"line_number":2275,"context_line":"    \"\"\""},{"line_number":2276,"context_line":"    try:"},{"line_number":2277,"context_line":"        select \u003d eventlet.patcher.original(\u0027select\u0027)"},{"line_number":2278,"context_line":"        if hasattr(select, \"poll\"):"},{"line_number":2279,"context_line":"            return \"poll\""},{"line_number":2280,"context_line":"        return \"selects\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_26d82222","line":2277,"updated":"2018-11-26 18:31:09.000000000","message":"Makes sense, and seems to match how eventlet itself checks for availability these days: https://github.com/eventlet/eventlet/blob/77bccbe/eventlet/hubs/poll.py#L6-L11","commit_id":"28b96ca79095f4f83116766862d69c358c7c8a39"}],"test/unit/common/test_utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"93ca29fa739b6dbfc4aff87ad876940cab0d8fea","unresolved":false,"context_lines":[{"line_number":4783,"context_line":"        with mock.patch.dict(\u0027sys.modules\u0027,"},{"line_number":4784,"context_line":"                             {\u0027select\u0027: SelectWithoutPoll,"},{"line_number":4785,"context_line":"                              \u0027__original_module_select\u0027: SelectWithPoll}):"},{"line_number":4786,"context_line":"            self.assertEqual(utils.get_hub(), \u0027poll\u0027)"},{"line_number":4787,"context_line":""},{"line_number":4788,"context_line":"        # Platform without poll() that call get_hub after eventlet patching"},{"line_number":4789,"context_line":"        with mock.patch.dict(\u0027sys.modules\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a6399240","line":4786,"updated":"2018-11-26 18:31:09.000000000","message":"Back out the change, test pops here, as expected.","commit_id":"28b96ca79095f4f83116766862d69c358c7c8a39"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"93ca29fa739b6dbfc4aff87ad876940cab0d8fea","unresolved":false,"context_lines":[{"line_number":4789,"context_line":"        with mock.patch.dict(\u0027sys.modules\u0027,"},{"line_number":4790,"context_line":"                             {\u0027select\u0027: SelectWithoutPoll,"},{"line_number":4791,"context_line":"                              \u0027__original_module_select\u0027: SelectWithoutPoll}):"},{"line_number":4792,"context_line":"            self.assertEqual(utils.get_hub(), \u0027selects\u0027)"},{"line_number":4793,"context_line":""},{"line_number":4794,"context_line":""},{"line_number":4795,"context_line":"class TestStatsdLogging(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_2674a203","line":4792,"updated":"2018-11-26 18:31:09.000000000","message":"Do we really need this last assertion? It matches the one on line 4780 exactly. Maybe just update the comment to something like\n\n # Platform without poll() -- before or after patching doesn\u0027t matter\n\n?","commit_id":"28b96ca79095f4f83116766862d69c358c7c8a39"},{"author":{"_account_id":28499,"name":"Romain de Joux","email":"romain.de-joux@ovhcloud.com","username":"rdejoux"},"change_message_id":"8d3da1c32c490d5146afa05ead4a67284321e2a5","unresolved":false,"context_lines":[{"line_number":4789,"context_line":"        with mock.patch.dict(\u0027sys.modules\u0027,"},{"line_number":4790,"context_line":"                             {\u0027select\u0027: SelectWithoutPoll,"},{"line_number":4791,"context_line":"                              \u0027__original_module_select\u0027: SelectWithoutPoll}):"},{"line_number":4792,"context_line":"            self.assertEqual(utils.get_hub(), \u0027selects\u0027)"},{"line_number":4793,"context_line":""},{"line_number":4794,"context_line":""},{"line_number":4795,"context_line":"class TestStatsdLogging(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4988ce1f","line":4792,"in_reply_to":"3f79a3b5_2674a203","updated":"2018-11-26 22:03:36.000000000","message":"I agree with you and I will push an updated test in few minutes.","commit_id":"28b96ca79095f4f83116766862d69c358c7c8a39"}]}