)]}'
{"bin/swift-recon":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"1bfa06d429f40a35cfc4fe497a62ed6096b9f558","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/python"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":3,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":4,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F86uI%3D","line":1,"updated":"2013-12-18 20:22:00.000000000","message":"Why is this change necessary?","commit_id":"1b1d7a6264e0e93b0bd57347f174079dcff4f3a7"},{"author":{"_account_id":1603,"name":"Florian Hines","email":"syn@ronin.io","username":"pandemicsyn"},"change_message_id":"93b1099090e1fdc07dd6decc534b13d598128f9a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/python"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":3,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":4,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F86oY%3D","line":1,"in_reply_to":"AAAATn%2F86uI%3D","updated":"2013-12-18 20:39:37.000000000","message":"autopep8 fail. let me push an update.","commit_id":"1b1d7a6264e0e93b0bd57347f174079dcff4f3a7"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"1bfa06d429f40a35cfc4fe497a62ed6096b9f558","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class Scout(object):"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    \"\"\""},{"line_number":62,"context_line":"    Obtain swift recon information"},{"line_number":63,"context_line":"    \"\"\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F86uA%3D","line":60,"updated":"2013-12-18 20:22:00.000000000","message":"Is this extra new line necessary?","commit_id":"1b1d7a6264e0e93b0bd57347f174079dcff4f3a7"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"1bfa06d429f40a35cfc4fe497a62ed6096b9f558","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class SwiftRecon(object):"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    \"\"\""},{"line_number":115,"context_line":"    Retrieve and report cluster info from hosts running recon middleware."},{"line_number":116,"context_line":"    \"\"\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F86t8%3D","line":113,"updated":"2013-12-18 20:22:00.000000000","message":"Is this required?","commit_id":"1b1d7a6264e0e93b0bd57347f174079dcff4f3a7"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"1bfa06d429f40a35cfc4fe497a62ed6096b9f558","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        for host in errors:"},{"line_number":267,"context_line":"            node \u003d urlparse(host).netloc"},{"line_number":268,"context_line":"            for entry in errors[host]:"},{"line_number":269,"context_line":"                print \"Errored: %s on %s\" % (entry, node)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        print \"\u003d\" * 79"},{"line_number":272,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F86t0%3D","line":269,"updated":"2013-12-18 20:22:00.000000000","message":"Perhaps \"Device errors: \" ?","commit_id":"1b1d7a6264e0e93b0bd57347f174079dcff4f3a7"},{"author":{"_account_id":1603,"name":"Florian Hines","email":"syn@ronin.io","username":"pandemicsyn"},"change_message_id":"93b1099090e1fdc07dd6decc534b13d598128f9a","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        for host in errors:"},{"line_number":267,"context_line":"            node \u003d urlparse(host).netloc"},{"line_number":268,"context_line":"            for entry in errors[host]:"},{"line_number":269,"context_line":"                print \"Errored: %s on %s\" % (entry, node)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        print \"\u003d\" * 79"},{"line_number":272,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F86oM%3D","line":269,"in_reply_to":"AAAATn%2F86t0%3D","updated":"2013-12-18 20:39:37.000000000","message":"sure thing.","commit_id":"1b1d7a6264e0e93b0bd57347f174079dcff4f3a7"}],"swift/common/middleware/recon.py":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"a070246241a67a6340145b62178129de1d6b2884","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            except OSError as err:"},{"line_number":197,"context_line":"                mounted \u003d str(err)"},{"line_number":198,"context_line":"            mpoint \u003d {\u0027device\u0027: entry, \u0027mounted\u0027: mounted}"},{"line_number":199,"context_line":"            if mpoint[\u0027mounted\u0027] is not True:"},{"line_number":200,"context_line":"                mountlist.append(mpoint)"},{"line_number":201,"context_line":"        return mountlist"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F86BA%3D","line":199,"updated":"2013-12-18 23:24:07.000000000","message":"Can you adjust the unit tests so that it covers both when this expression True and False? It appears to only test the False case (at least when I run the test_recon.py file only the else clause that I added with a breakpoint is not hit).\n\nIf the administrator has explicitly said not to check mount points, perhaps this will be misleading?","commit_id":"de4aaa1911bb3733060aed2796cc548b05ed467f"}]}