)]}'
{"test/unit/__init__.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"906f2dc178a949d3e186bf1f2c8ec54d0cd88f1b","unresolved":false,"context_lines":[{"line_number":924,"context_line":"        def getheaders(self):"},{"line_number":925,"context_line":"            etag \u003d self.etag"},{"line_number":926,"context_line":"            if not etag:"},{"line_number":927,"context_line":"                if isinstance(self.body, six.binary_type):"},{"line_number":928,"context_line":"                    etag \u003d \u0027\"\u0027 + md5(self.body).hexdigest() + \u0027\"\u0027"},{"line_number":929,"context_line":"                else:"},{"line_number":930,"context_line":"                    etag \u003d \u0027\"68b329da9893e34099c7d8ad5cb9c940\"\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_ab2b0d80","side":"PARENT","line":927,"updated":"2019-01-14 23:01:29.000000000","message":"I don\u0027t see what exactly this buys us, considering that \"binary_type\" is used everywhere anyway.","commit_id":"5b5ed29ab4566b20f6b6eecd6b9143bacd91ea9d"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d5523a4e59631e8b09a871c41e04469fd2e35732","unresolved":false,"context_lines":[{"line_number":924,"context_line":"        def getheaders(self):"},{"line_number":925,"context_line":"            etag \u003d self.etag"},{"line_number":926,"context_line":"            if not etag:"},{"line_number":927,"context_line":"                if isinstance(self.body, six.binary_type):"},{"line_number":928,"context_line":"                    etag \u003d \u0027\"\u0027 + md5(self.body).hexdigest() + \u0027\"\u0027"},{"line_number":929,"context_line":"                else:"},{"line_number":930,"context_line":"                    etag \u003d \u0027\"68b329da9893e34099c7d8ad5cb9c940\"\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_46ef5de8","side":"PARENT","line":927,"in_reply_to":"bfdaf3ff_ab2b0d80","updated":"2019-01-31 21:26:19.000000000","message":"I look forward to the day we don\u0027t need six :-D","commit_id":"5b5ed29ab4566b20f6b6eecd6b9143bacd91ea9d"}],"test/unit/obj/test_server.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"906f2dc178a949d3e186bf1f2c8ec54d0cd88f1b","unresolved":false,"context_lines":[{"line_number":8156,"context_line":"                conn.sock.fd._sock.close()"},{"line_number":8157,"context_line":"            else:"},{"line_number":8158,"context_line":"                conn.sock.fd.close()"},{"line_number":8159,"context_line":"        sleep(0)"},{"line_number":8160,"context_line":""},{"line_number":8161,"context_line":"        # and make sure it demonstrates the client disconnect"},{"line_number":8162,"context_line":"        log_lines \u003d self.logger.get_lines_for_level(\u0027info\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_cbe69145","side":"PARENT","line":8159,"updated":"2019-01-14 23:01:29.000000000","message":"Hmm... Why did you leave the sleep() in  test_expect_on_multiphase_put_diconnect() and other such places, but removed it here?\n\nPreviously, I had to add this because on py35 when we went to get logger lines, they pretty solidly were absent. When I added the sleep(0), something scheduled them to get logged and captured in our fake logger.\n\nBut I tested this patch in my environment and it passes. So I\u0027m inclined to approve it and then see what happens.","commit_id":"5b5ed29ab4566b20f6b6eecd6b9143bacd91ea9d"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"6747fecfbd8b28c8a6b71cb1582c6632be80c8fb","unresolved":false,"context_lines":[{"line_number":8156,"context_line":"                conn.sock.fd._sock.close()"},{"line_number":8157,"context_line":"            else:"},{"line_number":8158,"context_line":"                conn.sock.fd.close()"},{"line_number":8159,"context_line":"        sleep(0)"},{"line_number":8160,"context_line":""},{"line_number":8161,"context_line":"        # and make sure it demonstrates the client disconnect"},{"line_number":8162,"context_line":"        log_lines \u003d self.logger.get_lines_for_level(\u0027info\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_75eb1777","side":"PARENT","line":8159,"in_reply_to":"bfdaf3ff_cbe69145","updated":"2019-02-01 17:11:48.000000000","message":"Huh. Maybe you wee on to something...\n\nhttp://logs.openstack.org/83/630783/1/check/swift-tox-py35/9f3fa03/job-output.txt.gz#_2019-02-01_17_07_05_600495","commit_id":"5b5ed29ab4566b20f6b6eecd6b9143bacd91ea9d"}]}
