)]}'
{"test/unit/proxy/controllers/test_obj.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e9b5ad08a9824a3972c8d6b631af537350f10e21","unresolved":false,"context_lines":[{"line_number":2093,"context_line":"        got \u003d controller._determine_chunk_destinations(putters, self.policy)"},{"line_number":2094,"context_line":"        expected \u003d {}"},{"line_number":2095,"context_line":"        for i, p in enumerate(putters):"},{"line_number":2096,"context_line":"            expected[p] \u003d i"},{"line_number":2097,"context_line":"        self.assertEqual(got, expected)"},{"line_number":2098,"context_line":""},{"line_number":2099,"context_line":"        # now lets make a handoff at the end"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_2084080c","line":2096,"range":{"start_line":2096,"start_character":26,"end_line":2096,"end_character":27},"updated":"2019-01-15 16:26:46.000000000","message":"Off-topic: should this be\n\n self.policy.get_backend_index(i)\n\n? Maybe it doesn\u0027t matter in the context of this test...","commit_id":"ca4d6ec9924275b998d4748980ef8a3597bf7936"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e9b5ad08a9824a3972c8d6b631af537350f10e21","unresolved":false,"context_lines":[{"line_number":2096,"context_line":"            expected[p] \u003d i"},{"line_number":2097,"context_line":"        self.assertEqual(got, expected)"},{"line_number":2098,"context_line":""},{"line_number":2099,"context_line":"        # now lets make a handoff at the end"},{"line_number":2100,"context_line":"        orig_index \u003d putters[-1].node_index"},{"line_number":2101,"context_line":"        putters[-1].node_index \u003d None"},{"line_number":2102,"context_line":"        got \u003d controller._determine_chunk_destinations(putters, self.policy)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_20dde841","line":2099,"updated":"2019-01-15 16:26:46.000000000","message":"I wonder if this would be better served with something like\n\n def _test_one_handoff(index):\n     with mock.patch.object(putters[index], \u0027node_index\u0027, None):\n         got \u003d controller._determine_chunk_destinations(putters, self.policy)\n         self.assertEqual(got, expected)\n         # and maybe even add...\n         self.assertEqual([p.node_index for p in putters], [\n             None if x \u003d\u003d index else x\n             for x, _ in enumerate(putters)])\n\n # now lets make a handoff at the end\n _test_one_handoff(-1)\n # now lets make a handoff at the start\n _test_one_handoff(0)\n # now lets make a handoff in the middle\n _test_one_handoff(2)","commit_id":"ca4d6ec9924275b998d4748980ef8a3597bf7936"}]}