)]}'
{"test/probe/test_replication_servers_working.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"9302aa09690ff4ac2a93ffeb038b89547630bf43","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                except Exception:"},{"line_number":177,"context_line":"                    if time.time() - begin \u003e 60:"},{"line_number":178,"context_line":"                        raise"},{"line_number":179,"context_line":"                    time.sleep(1)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            # Now, delete file \"hashes.pkl\"."},{"line_number":182,"context_line":"            # Check, that all files were replicated."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_b55de816","side":"PARENT","line":179,"updated":"2019-02-18 16:25:01.000000000","message":"this is pretty unclear, what is it verifying, how long does it run, why would we expect the error and if we hit it what would fix it by waiting?!","commit_id":"0c316a134fd44f7254a9561796f088d9b7f9a9c3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"9302aa09690ff4ac2a93ffeb038b89547630bf43","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                        raise"},{"line_number":151,"context_line":"                    time.sleep(1)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"            self.replicators.stop()"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"            # Delete directories and files in objects storage without"},{"line_number":156,"context_line":"            # deleting file \"hashes.pkl\"."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_35801847","line":153,"updated":"2019-02-18 16:25:01.000000000","message":"I guess really the assumption here is that all hashes.pkl are in sync and their suffixes closed over.  Perhaps the loop above has already enforced that state...","commit_id":"61c9aa4bf3f7678fc0b7ec93fca7633ebb7e45ad"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"9302aa09690ff4ac2a93ffeb038b89547630bf43","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                        test_node, data_dir, directory)):"},{"line_number":171,"context_line":"                    self.assertFalse(os.path.isdir("},{"line_number":172,"context_line":"                        os.path.join(test_node, data_dir,"},{"line_number":173,"context_line":"                                     directory, input_dir)))"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"            self.replicators.start()"},{"line_number":176,"context_line":"            # Now, delete file \"hashes.pkl\"."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_35a7b80e","line":173,"updated":"2019-02-18 16:25:01.000000000","message":"clearly here the replicators don\u0027t replicate with hashes.pkl telling them we\u0027re in sync","commit_id":"61c9aa4bf3f7678fc0b7ec93fca7633ebb7e45ad"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"9302aa09690ff4ac2a93ffeb038b89547630bf43","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                        os.path.join(test_node, data_dir,"},{"line_number":173,"context_line":"                                     directory, input_dir)))"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"            self.replicators.start()"},{"line_number":176,"context_line":"            # Now, delete file \"hashes.pkl\"."},{"line_number":177,"context_line":"            # Check, that all files were replicated."},{"line_number":178,"context_line":"            for directory in os.listdir(os.path.join(test_node, data_dir)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_55811c4d","line":175,"updated":"2019-02-18 16:25:01.000000000","message":"and from here on the test works the same as before :+1:","commit_id":"61c9aa4bf3f7678fc0b7ec93fca7633ebb7e45ad"}]}