)]}'
{"swift/common/middleware/crypto/keymaster.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"618dbd256896a1566cdc4d71400c1a09f0b6097e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.alternate_fetch_keys \u003d None"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def _make_key_id(self, path, secret_id):"},{"line_number":51,"context_line":"        key_id \u003d {\u0027v\u0027: \u00271\u0027, \u0027path\u0027: path}"},{"line_number":52,"context_line":"        if secret_id:"},{"line_number":53,"context_line":"            # stash secret_id so that decrypter can pass it back to get the"},{"line_number":54,"context_line":"            # same keys"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_d57cf173","line":51,"range":{"start_line":51,"start_character":24,"end_line":51,"end_character":25},"updated":"2019-02-07 02:03:13.000000000","message":"This change almost certainly warrants a bump to v2.","commit_id":"df028ebbddc8e84d6c9651f030efad3189a29b83"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d1c87647b7d09a527a7e46695e4316d58d29a190","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.alternate_fetch_keys \u003d None"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _make_key_id(self, path, secret_id):"},{"line_number":52,"context_line":"        key_id \u003d {\u0027v\u0027: \u00271\u0027, \u0027path\u0027: path}"},{"line_number":53,"context_line":"        if secret_id:"},{"line_number":54,"context_line":"            # stash secret_id so that decrypter can pass it back to get the"},{"line_number":55,"context_line":"            # same keys"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_e2260617","side":"PARENT","line":52,"range":{"start_line":52,"start_character":18,"end_line":52,"end_character":26},"updated":"2019-02-08 02:03:43.000000000","message":"Version was previously hard-coded here, but no one was looking at it (since there was just the one version).","commit_id":"4cb94691861f66cc5d2f09dfd66c2920935d7ebc"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d1c87647b7d09a527a7e46695e4316d58d29a190","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                    path, secret_id\u003dsecret_id)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"                if self.obj:"},{"line_number":99,"context_line":"                    if self.obj.startswith(\u0027/\u0027) and version \u003d\u003d \u00271\u0027:"},{"line_number":100,"context_line":"                        path \u003d self.obj"},{"line_number":101,"context_line":"                    else:"},{"line_number":102,"context_line":"                        path \u003d path + \u0027/\u0027 + self.obj"},{"line_number":103,"context_line":"                    keys[\u0027object\u0027] \u003d self.keymaster.create_key("}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_6261b639","line":100,"range":{"start_line":99,"start_character":20,"end_line":100,"end_character":39},"updated":"2019-02-08 02:03:43.000000000","message":"...and this is what lets us still read data (even data PUT to somewhere like \"/v1/a/c//o\") that was written with old Swift.","commit_id":"43103319d0aa27f24e6520c0962bd19e55568ad4"}],"test/unit/common/middleware/crypto/test_keymaster.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f6ed37f140b54ef384d7fb42f089d72d1ba6a4cb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.verify_keys_for_path("},{"line_number":53,"context_line":"            \u0027/a/c/o\u0027, expected_keys\u003d(\u0027object\u0027, \u0027container\u0027))"},{"line_number":54,"context_line":"        self.verify_keys_for_path("},{"line_number":55,"context_line":"            \u0027/a/c//o\u0027, expected_keys\u003d(\u0027object\u0027, \u0027container\u0027))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_container_path(self):"},{"line_number":58,"context_line":"        self.verify_keys_for_path("}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_3ae1aad1","line":55,"updated":"2019-02-07 00:56:31.000000000","message":"Without the fixes in keymaster.py:\n\n FAIL: test_object_path (test.unit.common.middleware.crypto.test_keymaster.TestKeymaster)\n ----------------------------------------------------------------------\n Traceback (most recent call last):\n   File \"/vagrant/swift/test/unit/common/middleware/crypto/test_keymaster.py\", line 55, in test_object_path\n     \u0027/a/c//o\u0027, expected_keys\u003d(\u0027object\u0027, \u0027container\u0027))\n   File \"/vagrant/swift/test/unit/common/middleware/crypto/test_keymaster.py\", line 83, in verify_keys_for_path\n     self.assertEqual(path, id[\u0027path\u0027])\n AssertionError: \u0027/a/c//o\u0027 !\u003d \u0027/o\u0027\n - /a/c//o\n + /o\n \n     \"\"\"Fail immediately, with the given message.\"\"\"\n \u003e\u003e  raise self.failureException(\"\u0027/a/c//o\u0027 !\u003d \u0027/o\u0027\\n- /a/c//o\\n+ /o\\n\")","commit_id":"df028ebbddc8e84d6c9651f030efad3189a29b83"}]}
