)]}'
{"test/probe/common.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"fa75332242d8582908bcb9f1bc74b01a1b28ab74","unresolved":false,"context_lines":[{"line_number":365,"context_line":"            config_paths\u003dself.configs)"},{"line_number":366,"context_line":"        for server in Manager([\u0027proxy-server\u0027]):"},{"line_number":367,"context_line":"            for conf in server.conf_files():"},{"line_number":368,"context_line":"                self.configs[\u0027proxy-server\u0027] \u003d conf"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def setUp(self):"},{"line_number":371,"context_line":"        resetswift()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_60ff2eab","line":368,"updated":"2019-02-12 18:36:55.000000000","message":"So how\u0027s this going to work with my noauth proxy? Are we relying on the fact that the conf files come out alphabetically?","commit_id":"771963c92654338011d3dc907044b2ee3f405dd3"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"3955db19e3acadd2875e47287c15aaf4b87cf6c8","unresolved":false,"context_lines":[{"line_number":365,"context_line":"            config_paths\u003dself.configs)"},{"line_number":366,"context_line":"        for server in Manager([\u0027proxy-server\u0027]):"},{"line_number":367,"context_line":"            for conf in server.conf_files():"},{"line_number":368,"context_line":"                self.configs[\u0027proxy-server\u0027] \u003d conf"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def setUp(self):"},{"line_number":371,"context_line":"        resetswift()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_b18ebb76","line":368,"in_reply_to":"9fdfeff1_33c887a6","updated":"2019-04-30 16:55:31.000000000","message":"*shrug* probably mostly harmless","commit_id":"771963c92654338011d3dc907044b2ee3f405dd3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"a3534b8906b64faf4f4f888cd612e39de692f4a1","unresolved":false,"context_lines":[{"line_number":365,"context_line":"            config_paths\u003dself.configs)"},{"line_number":366,"context_line":"        for server in Manager([\u0027proxy-server\u0027]):"},{"line_number":367,"context_line":"            for conf in server.conf_files():"},{"line_number":368,"context_line":"                self.configs[\u0027proxy-server\u0027] \u003d conf"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def setUp(self):"},{"line_number":371,"context_line":"        resetswift()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_33c887a6","line":368,"in_reply_to":"9fdfeff1_60ff2eab","updated":"2019-02-13 16:34:52.000000000","message":"yeah, this part is sketchy - OMM I used [\u0027proxy-server.proxy\u0027] to get just the one I want, but that resulted in an empty list in the gate environment","commit_id":"771963c92654338011d3dc907044b2ee3f405dd3"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"fa75332242d8582908bcb9f1bc74b01a1b28ab74","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            proxy_conf \u003d readconf(self.configs[\u0027proxy-server\u0027],"},{"line_number":384,"context_line":"                                  section_name\u003d\u0027app:proxy-server\u0027)"},{"line_number":385,"context_line":"            proxy_ipport \u003d (proxy_conf.get(\u0027bind_ip\u0027, \u0027127.0.0.1\u0027),"},{"line_number":386,"context_line":"                            int(proxy_conf.get(\u0027bind_port\u0027, 8080)))"},{"line_number":387,"context_line":"            self.ipport2server[proxy_ipport] \u003d \u0027proxy\u0027"},{"line_number":388,"context_line":"            self.url, self.token, self.account \u003d check_server("},{"line_number":389,"context_line":"                proxy_ipport, self.ipport2server)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_a022f650","line":386,"range":{"start_line":386,"start_character":60,"end_line":386,"end_character":64},"updated":"2019-02-12 18:36:55.000000000","message":"I wonder a little, whether this ought to just be an established, well-known port on which the proxy-server-under-test should be running...","commit_id":"771963c92654338011d3dc907044b2ee3f405dd3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"a3534b8906b64faf4f4f888cd612e39de692f4a1","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            proxy_conf \u003d readconf(self.configs[\u0027proxy-server\u0027],"},{"line_number":384,"context_line":"                                  section_name\u003d\u0027app:proxy-server\u0027)"},{"line_number":385,"context_line":"            proxy_ipport \u003d (proxy_conf.get(\u0027bind_ip\u0027, \u0027127.0.0.1\u0027),"},{"line_number":386,"context_line":"                            int(proxy_conf.get(\u0027bind_port\u0027, 8080)))"},{"line_number":387,"context_line":"            self.ipport2server[proxy_ipport] \u003d \u0027proxy\u0027"},{"line_number":388,"context_line":"            self.url, self.token, self.account \u003d check_server("},{"line_number":389,"context_line":"                proxy_ipport, self.ipport2server)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_7337efb1","line":386,"range":{"start_line":386,"start_character":60,"end_line":386,"end_character":64},"in_reply_to":"9fdfeff1_a022f650","updated":"2019-02-13 16:34:52.000000000","message":"i mean that\u0027s what it was before?  Maybe that was better?\n\nit was just sort of opportunistic, i\u0027d be happy to pull this part out.","commit_id":"771963c92654338011d3dc907044b2ee3f405dd3"}],"test/probe/test_container_failures.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"a3534b8906b64faf4f4f888cd612e39de692f4a1","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            device \u003d onode[\u0027device\u0027]"},{"line_number":135,"context_line":"            hash_str \u003d hash_path(self.account, container)"},{"line_number":136,"context_line":"            server_conf \u003d readconf(self.configs[\u0027container-server\u0027][node_id])"},{"line_number":137,"context_line":"            devices \u003d server_conf[\u0027app:container-server\u0027][\u0027devices\u0027]"},{"line_number":138,"context_line":"            obj_dir \u003d \u0027%s/%s/containers/%s/%s/%s/\u0027 % (devices,"},{"line_number":139,"context_line":"                                                      device, opart,"},{"line_number":140,"context_line":"                                                      hash_str[-3:], hash_str)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_f373df7e","line":137,"updated":"2019-02-13 16:34:52.000000000","message":"e.g. the per-node devices dir","commit_id":"771963c92654338011d3dc907044b2ee3f405dd3"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"fa75332242d8582908bcb9f1bc74b01a1b28ab74","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        node_timeout \u003d int(proxy_conf.get(\u0027node_timeout\u0027, 10))"},{"line_number":169,"context_line":"        pool \u003d GreenPool()"},{"line_number":170,"context_line":"        try:"},{"line_number":171,"context_line":"            with Timeout(node_timeout + 5):"},{"line_number":172,"context_line":"                pool.spawn(run_test, 1, False)"},{"line_number":173,"context_line":"                pool.spawn(run_test, 2, True)"},{"line_number":174,"context_line":"                pool.spawn(run_test, 3, True)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_e0b23e06","line":171,"updated":"2019-02-12 18:36:55.000000000","message":"I\u0027m kind of tempted to put this in /etc/swift/test.conf instead...","commit_id":"771963c92654338011d3dc907044b2ee3f405dd3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"a3534b8906b64faf4f4f888cd612e39de692f4a1","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        node_timeout \u003d int(proxy_conf.get(\u0027node_timeout\u0027, 10))"},{"line_number":169,"context_line":"        pool \u003d GreenPool()"},{"line_number":170,"context_line":"        try:"},{"line_number":171,"context_line":"            with Timeout(node_timeout + 5):"},{"line_number":172,"context_line":"                pool.spawn(run_test, 1, False)"},{"line_number":173,"context_line":"                pool.spawn(run_test, 2, True)"},{"line_number":174,"context_line":"                pool.spawn(run_test, 3, True)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_1371c376","line":171,"in_reply_to":"9fdfeff1_e0b23e06","updated":"2019-02-13 16:34:52.000000000","message":"that would work... probably about just as good if we can make the ansibles do the updates...\n\nthere\u0027s lots of other places in probe tests we look at on disk configuration... we just hadn\u0027t done the proxy before near as I can tell.\n\nI think the node_timeout + 5 is probably more clear than the magic number that was there before...","commit_id":"771963c92654338011d3dc907044b2ee3f405dd3"}],"tools/playbooks/saio_single_node_setup/setup_saio.yaml":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"3955db19e3acadd2875e47287c15aaf4b87cf6c8","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    - name: set the options in the proxy config file"},{"line_number":156,"context_line":"      shell:"},{"line_number":157,"context_line":"        cmd: |"},{"line_number":158,"context_line":"          crudini --set /etc/swift/proxy-server.conf app:proxy-server node_timeout 20"},{"line_number":159,"context_line":"        executable: /bin/bash"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    - name: copy the SAIO scripts for resetting the environment"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffb9cba7_710603d1","line":158,"range":{"start_line":158,"start_character":83,"end_line":158,"end_character":85},"updated":"2019-04-30 16:55:31.000000000","message":"FWIW, I just spotted https://github.com/openstack/devstack/blob/master/lib/swift#L402-L406 in devstack... which might be a little overboard, but certainly lends credence to the idea that 20 won\u0027t be too much. Should we also update conn_timeout or client_timeout? Should we tweak more than just the proxy config?","commit_id":"771963c92654338011d3dc907044b2ee3f405dd3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"e2d30fb4ebfd2293fbc337829799df9a1ea94a73","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    - name: set the options in the proxy config file"},{"line_number":156,"context_line":"      shell:"},{"line_number":157,"context_line":"        cmd: |"},{"line_number":158,"context_line":"          crudini --set /etc/swift/proxy-server.conf app:proxy-server node_timeout 20"},{"line_number":159,"context_line":"        executable: /bin/bash"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    - name: copy the SAIO scripts for resetting the environment"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffb9cba7_2c11105e","line":158,"range":{"start_line":158,"start_character":83,"end_line":158,"end_character":85},"in_reply_to":"ffb9cba7_710603d1","updated":"2019-04-30 19:15:25.000000000","message":"sounds reasonable!  I think it\u0027d be great for more probetests to use the configured values of the SUT and also in make whatever tuning changes we can to improve reliability of tests in the gate.\n\nBut unless there\u0027s another edit needed to change I\u0027d prefer to do additional tuning changes in follow-ups.\n\nAs for the 2m timeout in devstack... I\u0027m not sure that\u0027s apples to apples since the machine in that case will have more \"stuff\" going on it than here during probetests.  But we can always increase the timeout more if it proves needed.","commit_id":"771963c92654338011d3dc907044b2ee3f405dd3"}]}