)]}'
{"test/unit/common/test_db_replicator.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"8c30853187292b11986bd689640829c0b72447c6","unresolved":false,"context_lines":[{"line_number":1823,"context_line":"        # part 2 does not belong on sdq"},{"line_number":1824,"context_line":"        self._make_fake_db(\u0027sdq\u0027, 2, \u0027bcbcbcbc15d3835053d568c57e2c83b5\u0027)"},{"line_number":1825,"context_line":""},{"line_number":1826,"context_line":"    def tearDown(self):"},{"line_number":1827,"context_line":"        rmtree(self.root, ignore_errors\u003dTrue)"},{"line_number":1828,"context_line":""},{"line_number":1829,"context_line":"    def test_scary_warnings(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_b931df5b","line":1826,"updated":"2019-02-12 06:25:05.000000000","message":":-(","commit_id":"8be9483d3e817a7a88d03cf614b722c0f03f474c"}],"test/unit/container/test_backend.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"8c30853187292b11986bd689640829c0b72447c6","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        # Test ContainerBroker.is_deleted() and get_info_is_deleted()"},{"line_number":129,"context_line":"        ts_iter \u003d make_timestamp_iter()"},{"line_number":130,"context_line":"        db_path \u003d os.path.join("},{"line_number":131,"context_line":"            tempdir, \u0027part\u0027, \u0027suffix\u0027, \u0027hash\u0027, \u0027db_dir\u0027, \u0027container.db\u0027)"},{"line_number":132,"context_line":"        broker \u003d ContainerBroker(db_path, account\u003d\u0027a\u0027, container\u003d\u0027c\u0027)"},{"line_number":133,"context_line":"        broker.initialize(next(ts_iter).internal, 0)"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_3973af18","line":131,"updated":"2019-02-12 06:25:05.000000000","message":"?\n\nOk, so looking at real data, I see\n\n /srv/node4/sdb4/containers/242/194/f22a8645a2ab8b3c000408953db9b194/f22a8645a2ab8b3c000408953db9b194.db\n\nand working backwards, I see\n\n f22a8645a2ab8b3c000408953db9b194.db \u003d container.db\n\n f22a8645a2ab8b3c000408953db9b194 \u003d hash\n\n 194 \u003d suffix\n\n 242 \u003d part\n\nI guess the extra layer is because we assume the db file will be a certain depth below the drive root, and we use that to go up and create /srv/node4/sdb4/tmp when deleting... could we stick \u0027db_dir\u0027 at the front? Maybe even call it \u0027containers\u0027? I just feel like I\u0027ll be so much less confused the next time I read these tests...","commit_id":"8be9483d3e817a7a88d03cf614b722c0f03f474c"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d624e0889f3e0a72a0f752f3ece7678fde2af91f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        # Test ContainerBroker.is_deleted() and get_info_is_deleted()"},{"line_number":129,"context_line":"        ts_iter \u003d make_timestamp_iter()"},{"line_number":130,"context_line":"        db_path \u003d os.path.join("},{"line_number":131,"context_line":"            tempdir, \u0027part\u0027, \u0027suffix\u0027, \u0027hash\u0027, \u0027db_dir\u0027, \u0027container.db\u0027)"},{"line_number":132,"context_line":"        broker \u003d ContainerBroker(db_path, account\u003d\u0027a\u0027, container\u003d\u0027c\u0027)"},{"line_number":133,"context_line":"        broker.initialize(next(ts_iter).internal, 0)"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_45cd5c2f","line":131,"in_reply_to":"9fdfeff1_2d1a84cb","updated":"2019-02-12 18:12:04.000000000","message":"Not worse! Definitely made things better -- I back out the change and sure enough, there\u0027s a /tmp/tmp/.lock hanging around after the test! I just want to keep things straight :-)","commit_id":"8be9483d3e817a7a88d03cf614b722c0f03f474c"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"b6273cdbc56e3113dad330a5b3b05047edc8509e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        # Test ContainerBroker.is_deleted() and get_info_is_deleted()"},{"line_number":129,"context_line":"        ts_iter \u003d make_timestamp_iter()"},{"line_number":130,"context_line":"        db_path \u003d os.path.join("},{"line_number":131,"context_line":"            tempdir, \u0027part\u0027, \u0027suffix\u0027, \u0027hash\u0027, \u0027db_dir\u0027, \u0027container.db\u0027)"},{"line_number":132,"context_line":"        broker \u003d ContainerBroker(db_path, account\u003d\u0027a\u0027, container\u003d\u0027c\u0027)"},{"line_number":133,"context_line":"        broker.initialize(next(ts_iter).internal, 0)"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_2d1a84cb","line":131,"in_reply_to":"9fdfeff1_3973af18","updated":"2019-02-12 14:42:16.000000000","message":"I see, I purported to fix the problem, but made it worse.","commit_id":"8be9483d3e817a7a88d03cf614b722c0f03f474c"}]}
